Commit Graph

3280 Commits

Author SHA1 Message Date
SilentSpike
947f9657db Port minor QoL tweaks to other QA services
Use of MouseEnter and MouseLeave is nicer for SVGs since it won't fire
multiple times (shouldn't happen hear anyway as only one element).

Triggering redraw after forcing related elements visible causes them to
render without having to pan manually.
2020-02-03 23:01:01 +00:00
SilentSpike
af5b64a477 Allow translation with numerical token replacement
Just escapes the special regex characters when creating a new RegExp so
that numerical keys can be used (e.g. my use case of replacing an
arbitrary number of tokens from an array). Otherwise it is interpreted
as a repetition.
2020-02-03 23:01:01 +00:00
SilentSpike
09e7b23665 Add Osmose issues UI and filtering
Filters out errors not present in the data .json file to enable
selective support since Osmose has a wide variety of errors which may be
too advanced for iD.

Also added processing for the elements associated with an error for
forced visibility and highlighting.
2020-02-03 23:01:01 +00:00
SilentSpike
e11d97b38c Add Osmose QA layer and service
Initial implementation - need to add UI for the errors and correctly set
up support for the desired error types provided by osmose.
2020-02-03 23:01:01 +00:00
Bryan Housel
eb0c297bbd Rewrite the issue gathering code to not use for..of 2020-02-03 17:25:34 -05:00
Quincy Morgan
13d8c078b4 Fix weak preset check 2020-02-03 13:58:34 -05:00
Bryan Housel
4aa4686e7f Fix test failures in localized and suspicious_names 2020-02-03 12:38:17 -05:00
Bryan Housel
b2b2689fb2 Use the ES6 export for martinez-polygon-clipping 2020-02-03 12:38:17 -05:00
Quincy Morgan
b4bc5305a1 Enable the issues section for multiple selected features (close #7324) 2020-02-03 12:17:14 -05:00
Quincy Morgan
e7c3ba0fd7 Show the same fields for the same features in multiselection regardless of what order they were selected in 2020-02-03 11:13:29 -05:00
Bryan Housel
06eac7c9d0 Don't bundle the nsi brands anymore, fetch from CDN at runtime
(re: #4994)
2020-02-01 17:40:56 -05:00
Bryan Housel
743dc0a83a Don't bundle the nsi brands anymore, fetch from CDN at runtime
(re: #4994)
2020-01-31 22:07:21 -05:00
Quincy Morgan
1c7a150854 Fix issue with fields in commit UI 2020-01-31 14:26:33 -05:00
Quincy Morgan
2783408fc3 Add tooltips to mixed values in semicombo, multicombo, and radio fields 2020-01-31 14:07:16 -05:00
Quincy Morgan
af928e3dc1 Support radio fields during multiselections 2020-01-31 13:02:30 -05:00
Quincy Morgan
8d9adbd902 Lock the name field if any of the selected features should be locked (re: #7306) 2020-01-31 11:23:42 -05:00
Quincy Morgan
b3262a71dc Use newlines instead of semicolons to separate mutliselection tag values in tooltips (re: #7306) 2020-01-31 10:49:31 -05:00
Quincy Morgan
512d8974a6 Merge branch '2.x' into multiselection-field-editing 2020-01-30 17:20:04 -05:00
Bryan Housel
6e5cb45c17 Don't bundle the imagery anymore, fetch from dist/data at runtime
(re: #4994)
2020-01-30 17:10:41 -05:00
Quincy Morgan
15e9599ff7 Support editing the Name and Multilingual Name fields during multiselection 2020-01-30 17:09:19 -05:00
Quincy Morgan
1b331bb678 Add mechanism for fields to support editing during multiselection (re: #7276)
Add `utilCombinedTags` method and use it for the raw tag editor as well as fields
Pass `entityIDs` array into fields instead of single `entity` object
Give field revertion its own path separate from `change`
Add multiselection editing to fields in files: access, address, check, combo, cycleway, input, maxspeed, textarea, and wikidata
2020-01-30 13:53:29 -05:00
Bryan Housel
33a2dafc10 Fetch wmf-sitematrix from CDN.. No need to depend on it anymore. 2020-01-30 09:48:37 -05:00
Bryan Housel
e19bcb77d5 Require init() call before coreContext starts doing things
(closes #7304)
2020-01-29 19:27:12 -05:00
Bryan Housel
fb4d658860 Don't bundle the community index anymore, fetch from CDN instead
Start fetching and preparing it just before the changeset gets sent
2020-01-29 15:24:26 -05:00
Bryan Housel
b8a8927d33 Start preparing uiSuccess early when saving changeset
This gives us some time to fetch and prepare the community index
2020-01-29 15:23:37 -05:00
Bryan Housel
9154a6a554 context.asset should pass-through absolute URLs 2020-01-29 15:22:06 -05:00
Bryan Housel
89724cfb1b Remove support for debug rendering of the community index
We have http://openstreetmap.community now for this, and it eliminates
another place in the code where that data would have been needed.
This commit also ES6ifies svgDebug.
2020-01-29 13:35:25 -05:00
Bryan Housel
c481f90e7d Stop bundling wmf-sitematrix, move it extern
This also includes a bunch of tweaks to make the tests work
in both PhantomJS and modern browsers like Chrome.

Basically - introduce some more async into the test code so that
the coreData.get promise is guaranteed to settle.  Because in
PhantomJS the promise is polyfilled, and Chrome it's native, they
work slightly differently.
2020-01-29 12:30:11 -05:00
Bryan Housel
567eeac587 Make several data external instead of bundled:
Also dist/data/* contains minified files now

These are now external and will fetch as needed:
-export { dataAddressFormats } from './address-formats.json';
-export { dataDeprecated } from './deprecated.json';
-export { dataDiscarded } from './discarded.json';
-export { dataLanguages } from './languages.json';
-export { dataPhoneFormats } from './phone-formats.json';
-export { dataShortcuts } from './shortcuts.json';
-export { dataTerritoryLanguages } from './territory-languages.json';
2020-01-28 22:21:31 -05:00
Bryan Housel
6d81a00daf Let caller modify the coreData fileMap, and add tests 2020-01-28 10:27:45 -05:00
Quincy Morgan
89ce98f510 Don't require services/osm in order to get max OSM character lengths 2020-01-28 09:28:23 -05:00
Bryan Housel
b949cc6bb6 Sometimes the issue cache has junk in it.
I got this to happen after some issues had been detected on the live map,
then starting the intro walkthrough (which replaces the graph).

No time now to dig into the root cause, but this might make the problem go
away so the tutorial doesn't get too weird.
2020-01-27 17:38:29 -05:00
Bryan Housel
d69cf532e0 Merge branch 'dataloader' into 2.x 2020-01-27 17:17:46 -05:00
Bryan Housel
31e007fc83 Create a data loader and move the intro graph into dist/data
(re: #3403)
2020-01-27 17:15:00 -05:00
Quincy Morgan
6dc02d7f22 Properly hide the input field on semicombos when there aren't enough characters remaining to add another value (re: #6817) 2020-01-27 16:35:15 -05:00
Quincy Morgan
17ae12b3d7 Address most common places where tag keys or values could exceed the 255 character API limit (close #6817) 2020-01-27 15:57:55 -05:00
Bryan Housel
883f35a99b indent 2020-01-27 12:28:55 -05:00
Bryan Housel
6b7bb75315 Prefix the stateful/internal variables with _ 2020-01-27 12:09:53 -05:00
Bryan Housel
2a2668b01b Can't use ES6 fat-arrow functions with arguments
see buble bug https://github.com/bublejs/buble/issues/208
2020-01-24 17:22:03 -05:00
Bryan Housel
08c850a98f ES6ify context 2020-01-24 17:16:32 -05:00
Quincy Morgan
7c5cbb121f Fix "Add field" label 2020-01-24 10:59:10 -05:00
Quincy Morgan
3dc0361dc8 Add improved "zoom to" icon 2020-01-22 12:43:24 -05:00
Quincy Morgan
c477950556 Re-add "zoom to this" button 2020-01-22 10:44:40 -05:00
Quincy Morgan
fd2b97331c Add label to "change feature type" button in inspector and make it a collapsible section (close #6811) 2020-01-22 09:19:54 -05:00
Quincy Morgan
6bb2997306 Enable changing the preset of multiple selected features (re: #7276)
Fix issue where preset tag reference wouldn't load
Change "Change feature" tooltip to more accurate "Change feature type"
2020-01-21 15:19:51 -05:00
Quincy Morgan
a364c52f47 Make "Multiple Values" placeholder italic 2020-01-20 13:55:38 -05:00
Quincy Morgan
14dba080b0 Fix inspector keytrap behavior 2020-01-20 13:55:06 -05:00
Quincy Morgan
d4dd92bc78 Don't append new line to raw tag text if the text is empty 2020-01-20 13:00:44 -05:00
Quincy Morgan
667406c6e0 Remove "all" from the inspector section names 2020-01-20 11:51:00 -05:00
Quincy Morgan
48bda8ba67 Move selected feature list to a collapsible inspector section (close #7273) 2020-01-20 11:34:51 -05:00