Quincy Morgan
228af9a000
Move areaKeys and setAreaKeys to modules/osm/tags
2019-04-26 12:53:05 -07:00
Quincy Morgan
ecc217f5d8
Add validation rule to flag impossible oneway highways and waterways ( close #6216 )
2019-04-26 12:04:43 -07:00
Quincy Morgan
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
Bryan Housel
0a77a494aa
Merge branch 'master' into validation_and_change_perf
2019-04-10 14:22:20 -04:00
Quincy Morgan
17f2c5c0f4
Add Zip Line preset
2019-04-05 09:40:35 -07:00
Bryan Housel
765d765477
Pick a fake loc value where equality tests actually work
2019-04-03 17:25:10 -04:00
Bryan Housel
167824a530
Make sure all nodes have an actual loc property
...
- This is to make difference comparisons easier
- The only nodes that didn't have a `loc` were fake nodes we made for testing
- So this commit also fixes the `osmIntersection` code and tests.
2019-04-03 16:20:45 -04:00
Bryan Housel
d5abe468b9
Remove rest of the lodash iterators: map, reduce, forEach
...
(re: #6087 )
2019-03-29 15:14:21 -04:00
Bryan Housel
3896b2282f
Remove lodash isNaN, isNumber, isString, bind, uniqBy
...
(re: 6087)
2019-03-27 23:11:45 -04:00
Quincy Morgan
748c9c9598
Filter out deprecated tag values from combobox suggestions ( close #6084 )
2019-03-27 17:15:10 -04:00
Bryan Housel
5b4aa529de
Replace lodash uniq
...
(re: 6087)
2019-03-27 02:43:25 -04:00
Bryan Housel
5e1ff74199
Replace lodash difference, intersects, union
...
(re: 6087)
2019-03-27 01:22:11 -04:00
Bryan Housel
1ce4f0ad6a
Remove lodash without
...
(re: #6087 )
2019-03-25 21:56:54 -04:00
Bryan Housel
5280d07bad
Remove lodash reject (re: #6087 )
2019-03-23 12:51:13 -04:00
Bryan Housel
76e0d13729
Remove lodash every and filter
...
(re: #6087 )
2019-03-23 01:22:56 -04:00
Bryan Housel
7a6c63fcc5
Remove lodash extend (re: #6087 )
2019-03-23 00:38:39 -04:00
Bryan Housel
7e6f68a1b2
Remove lodash some
...
(re: #6087 )
2019-03-23 00:07:52 -04:00
Bryan Housel
0e90167513
Remove lodash clone
...
(re: #6087 )
2019-03-22 23:18:25 -04:00
Bryan Housel
ff4f8f005f
Remove lodash find and findIndex
...
(re: #6087 )
2019-03-22 17:31:41 -04:00
Bryan Housel
11bfeaabfc
Add browser-polyfills, remove lodash assign, compact, values
...
(re: #6087 )
2019-03-22 17:14:41 -04:00
Bryan Housel
c7e375cbd7
Preserve directionality of sided way when joining to non-sided ways
...
(closes #6033 )
2019-03-21 22:19:05 -04:00
Quincy Morgan
0781b70f38
Add drag-and-drop reordering of relation members ( close #2283 )
2019-03-15 12:22:24 -04:00
Quincy Morgan
8ac6ede028
Add highway=footway when setting pier, platform, and foot racing track presets
...
Add highway=bridleway when setting horse racetrack preset
Style racetracks with highway tag with white/yellow pattern
2019-03-12 14:01:15 -04:00
Quincy Morgan
93df5d42d9
Flag and upgrade deprecated tags in a semicolon-delimited tag value ( close #6038 )
2019-03-11 10:22:28 -04:00
Bryan Housel
3f8911c149
Merge pull request #5999 from openstreetmap/squarish
...
Improve orthogonalization action
2019-03-01 23:28:23 -05:00
Bryan Housel
b47ab4ac50
Change orthogonalize to support degenerate shapes, non-closed ways
...
Also adds a handful of useful vector math functions to geo module
2019-02-28 22:52:45 -05:00
Quincy Morgan
a4e0bcb29c
Make misplaced multipolygon tags check more consistent
2019-02-26 08:53:00 -05:00
Quincy Morgan
12b1af7002
Don't say tags imply area for tags that iD doesn't have a preset for ( close #5933 )
2019-02-25 12:42:39 -05:00
Quincy Morgan
bfefea422b
Use iD's area tag logic for the tag_suggests_area validation
2019-02-05 13:55:59 -05:00
Quincy Morgan
8771a33716
Merge branch 'master' into validation
2019-02-05 11:30:24 -05:00
Quincy Morgan
c39c584b52
Fix false positive for deprecated tag validation
2019-02-04 18:36:42 -05:00
SilentSpike
781558e56b
Remove redundant source property
2019-02-04 18:40:06 +00:00
SilentSpike
ddf44377e8
Fix errors without templates not working
2019-02-04 18:12:21 +00:00
SilentSpike
d7147996ed
Merge remote-tracking branch 'upstream/master' into unify
2019-02-04 17:17:17 +00:00
SilentSpike
450c549ea5
Remove old error type files
2019-02-04 16:54:07 +00:00
SilentSpike
3ed13e9a4a
Convert KeepRight to use generic error type
2019-02-04 16:54:07 +00:00
SilentSpike
20ed8b50c9
Add generic QA error
...
I've converted the improveOSM errors to use this new generic QA error
structure which should allow for more general code to be used in
behaviour and UI.
Sidebar preview is currently broken, but will be fixed shortly.
2019-02-04 16:53:59 +00:00
Quincy Morgan
8c51411ad6
Merge branch 'master' into validation
2019-02-04 08:58:10 -05:00
Bryan Housel
f1b5efc81a
Revise the list of oneway aerialways (notably, drop yes)
...
(re: #5843 )
2019-02-02 15:30:42 -05:00
SilentSpike
ee5f9f3bf2
Use consistent short service name
2019-02-01 22:51:02 +00:00
SilentSpike
214cf41019
Use more generic classes for errors
2019-02-01 22:50:57 +00:00
SilentSpike
4d89810721
Add ImproveOSM service
...
Only processing one-way errors for now
2019-02-01 22:50:54 +00:00
Quincy Morgan
9785021f44
Rename simpleMultipolygon functions to oldMultipolygon
...
Return old_multipolygon validation issues for the relations as well as the outer ways
Remove console logging
Don't run missing_tag validation for relations with old_multipolygon issues
2019-02-01 15:19:28 -05:00
Quincy Morgan
09bc2a6e6c
Merge branch 'master' into validation
2019-01-30 16:44:14 -05:00
Bryan Housel
7138acc652
Properly export areaKeys, fix preset and maprules tests
2019-01-30 15:29:37 -05:00
Quincy Morgan
b21dd1d5d6
Add tooltip and updated message to deprecated_tags validation issue
...
Add a quick fix to upgrade deprecated tags
Add more deprecated tag data
2019-01-24 14:09:12 -05:00
Bryan Housel
7986fcbfbf
Merge branch 'keep-right_QA'
2019-01-04 21:37:19 -05:00
Quincy Morgan
cfbb86f88c
Change the initial view of the sidebar on selection
2018-12-19 17:44:41 -05:00
Thomas Hervey
18278371aa
WIP: identifying variables in errors
2018-12-19 13:38:40 -05:00
Thomas Hervey
31f35b0389
added basics to sidebar
2018-12-19 13:35:26 -05:00
