Commit Graph

99 Commits

Author SHA1 Message Date
Quincy Morgan 228af9a000 Move areaKeys and setAreaKeys to modules/osm/tags 2019-04-26 12:53:05 -07:00
Quincy Morgan d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Quincy Morgan 34792d7fbf Don't add field defaults when upgrading tags to a specific replacement 2019-04-03 10:57:42 -07:00
Quincy Morgan b12e7277df Add countryCodes property to preset schema
Copy countryCodes from name suggestion index
Use countryCodes to filter the preset search results (close #6124)
2019-03-28 11:44:05 -04:00
Bryan Housel 3896b2282f Remove lodash isNaN, isNumber, isString, bind, uniqBy
(re: 6087)
2019-03-27 23:11:45 -04:00
Quincy Morgan 53625a9364 Fix issues with the walkthrough 2019-03-27 17:41:15 -04:00
Bryan Housel 5b4aa529de Replace lodash uniq
(re: 6087)
2019-03-27 02:43:25 -04:00
Bryan Housel 4821bf0a68 Remove lodash omit
(re: #6087)
2019-03-26 14:12:45 -04:00
Bryan Housel 1ce4f0ad6a Remove lodash without
(re: #6087)
2019-03-25 21:56:54 -04:00
Bryan Housel 5280d07bad Remove lodash reject (re: #6087) 2019-03-23 12:51:13 -04:00
Bryan Housel 7e6f68a1b2 Remove lodash some
(re: #6087)
2019-03-23 00:07:52 -04:00
Bryan Housel 0e90167513 Remove lodash clone
(re: #6087)
2019-03-22 23:18:25 -04:00
Bryan Housel ff4f8f005f Remove lodash find and findIndex
(re: #6087)
2019-03-22 17:31:41 -04:00
Bryan Housel 11bfeaabfc Add browser-polyfills, remove lodash assign, compact, values
(re: #6087)
2019-03-22 17:14:41 -04:00
Quincy Morgan 4addd0e216 Add presets for basic indoor features (close #6082)
Don't use deprecated presets to determine area keys
2019-03-22 11:40:03 -04:00
Quincy Morgan 705f15aadd Speed up search by cacheing preset text values and not scrolling to focused node as often 2019-03-21 11:19:20 -04:00
Quincy Morgan 7e92f6aa89 Combine vertex and point geometries into a single Point fallback preset 2019-03-18 12:36:20 -04:00
Quincy Morgan 933569f8c6 Inherit check fields even if they define the preset 2019-03-13 12:59:06 -04:00
Quincy Morgan 9216c93334 Remove item from recents when removing it as a favorite from the ribbon so it doesn't still appear 2019-03-08 11:21:19 -05:00
Quincy Morgan 8e0ed8cd8b Make recent presets reorder-able in the ribbon 2019-03-08 10:54:18 -05:00
Quincy Morgan 4a39d8a444 Automatically show recent presets in the top bar ribbon 2019-03-08 10:10:31 -05:00
Quincy Morgan 213d0ee3e8 Move preset favoriting functions from core/context.js to presets/index.js
Make recent presets persistent and compatible with favorite presets
2019-03-07 16:49:29 -05:00
Quincy Morgan 7eb007d27a Make recent presets geometry-specific 2019-03-07 12:14:18 -05:00
Quincy Morgan 9c19a1d714 Nicer display of name suggestion index presets 2019-03-06 12:19:44 -05:00
Quincy Morgan 36ad1b0242 Use "building" label instead of "area" when adding POIs as buildings 2019-03-06 11:39:17 -05:00
Quincy Morgan d99fe79b6e Always show generic presets when searching 2019-03-04 17:47:20 -05:00
Quincy Morgan 734731bfda Make categories not geometry-specific 2019-03-04 13:39:30 -05:00
Quincy Morgan 3723c741f1 Add border to point icons in top bar 2019-03-02 14:47:48 -05:00
Quincy Morgan 4a82604cab Add search-to-add functionality 2019-02-28 15:00:00 -05:00
Quincy Morgan 12b1af7002 Don't say tags imply area for tags that iD doesn't have a preset for (close #5933) 2019-02-25 12:42:39 -05:00
Quincy Morgan ced652806b Fix an issue where some tagged nodes or existing vertices could not be snapped to (close #5942) 2019-02-25 08:54:30 -05:00
Quincy Morgan 63caa02cea Allow presets to inherit multiCombo and semiCombo fields even if they define the preset 2019-02-19 15:48:50 -05:00
Quincy Morgan 96a1ec92c7 Fix prior commit
Apply same node snap suppression behavior to dragging vertices as to drawing ways
2019-02-15 10:28:43 -05:00
Quincy Morgan 11dc86ca9b Add check for entity geometry type in allowsVertex function (re: #5875) 2019-02-11 09:59:43 -05:00
Bryan Housel 6e45796be7 Merge pull request #5875 from openstreetmap/dont-snap-non-vertices
Dont snap to non-vertices
2019-02-10 22:13:09 -05:00
Bryan Housel fbe584c7ec Lookup docs for some presets on wikidata, not wikibase
(re: #5823)

Now `uiTagReference` can accept a `qid` param for presets where we want this
(such as brands)
2019-02-08 16:27:33 -05:00
Max Grossman b7786fd081 if on address interpolation, match and don't look through keys...
ref #5811
2019-02-01 17:58:15 -05:00
Max Grossman 58e31bc45a initial update to draw modes and hover behavior
ref #5811
2019-02-01 17:34:40 -05:00
Bryan Housel 17bbc3d5a2 Slightly improve suggestion placement, preset search performance
- avoid lodash _filter when native filter is ok for arrays
- for suggestions use `originalName` instead of adding/removing the en-dash
- bump up importance of leading suggestions, but do a strict leading search

more on that last point:
For normal presets, we count a string as leading if it follows a space.
e.g. "office" will match "Law Office"
We don't really want this for suggestion presets though
e.g. "bell" should not match "Taco Bell"
2019-01-29 21:56:23 -05:00
Bryan Housel 20bcfc5730 Delimit name-suggestion-preset names on en-dash, not hyphen
To avoid conflicts with hyphenated names, or bilingual names
with hyphens in them (like used in Brussels)
2019-01-23 09:44:24 -05:00
Quincy Morgan bb4d0a9282 Fixes false error when a preset inherits fields from a preset with no fields 2019-01-17 15:40:42 -05:00
Quincy Morgan 9f7ef21e5c The additional fields dropdown now mixes universal and moreFields and is sorted alphabetically 2019-01-17 11:37:05 -05:00
Quincy Morgan 9ad217dce3 Fixed broken preset field inheritance 2019-01-17 09:49:48 -05:00
Bryan Housel 0773fedb8f Fix undefined fieldID.indexOf('{') > -1 causing tests to fail 2019-01-16 22:13:56 -05:00
Bryan Housel d506487069 Use the full preset path in name() instead of just first 2 parts 2019-01-15 17:15:35 -05:00
Quincy Morgan 4252c5cb36 Presets no longer inherit fields for keys that define them 2019-01-15 13:52:03 -05:00
Quincy Morgan 4b2c380b18 Changed preset field inheritance to target specific presets rather than just the parent preset 2019-01-15 13:07:58 -05:00
Quincy Morgan ae7c099c8a Moved field inheritance resolution from the data build to the preset initialization
Removed the data build check for duplicate values between fields and moreFields
Renamed the shop field from Type to Shop Type
Renamed the beauty field from Shop Type to Beauty Specialty
Added the brand field to the shop preset under moreFields
2019-01-15 09:53:26 -05:00
Bryan Housel 5a2049b421 Drop extra whitespace, make sure service exists before using it 2018-12-18 15:38:53 -05:00
Max Grossman 8f33a85a12 make collection.index function to handle failing tests 2018-12-17 17:16:10 -05:00