Commit Graph

38 Commits

Author SHA1 Message Date
Quincy Morgan d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel 7fe0380d7d Make sure icon fill colors can be overridden 2019-02-04 13:01:35 -05:00
Bryan Housel fadd8e2e8a Switch KeepRight markers to use touch targets
This makes it easier to select the KeepRight issue and avoid selecting
the OSM geometry underneath them
2019-01-04 21:17:38 -05:00
Bryan Housel cd9203975d Use touch targets for notes, fix a few bugs with note dragging
(closes #5213)
2019-01-04 15:48:39 -05:00
Bryan Housel 4494c3ab9c Fix comment box style, remove unused vars for eslint 2019-01-02 15:46:25 -05:00
Bryan Housel 0334e7b353 Visibility stuff
- Draw ellipse below note shadow
- Use brighter color for new note
- Use thicker stroke for note shadow (same width as point)
2018-07-24 00:16:37 -04:00
Bryan Housel 6dcb879990 Remove notes and deselect any selected note when disabling notes layer 2018-07-23 23:39:10 -04:00
Bryan Housel a3dc0e8213 Shrink annotations, add margin between note header and comments 2018-07-23 23:20:34 -04:00
Thomas Hervey 00bb733736 changed note annotation icons 2018-07-21 22:49:12 -04:00
Thomas Hervey 373353f40d added breathe behavior & cleaned hover/select styling on notes 2018-07-21 15:54:47 -04:00
Thomas Hervey bf9b19359a WIP drag note 2018-07-20 21:41:44 -04:00
Thomas Hervey b017616993 added new note icon and completed sidebar 2018-07-18 09:38:59 -04:00
Thomas Hervey af2b67663b added new-note button 2018-07-17 11:35:27 -04:00
Bryan Housel 694cc60893 Add thread dots to note header icon, disable comments on closed nodes 2018-07-16 16:53:45 -04:00
Bryan Housel 70f87632c7 Cleaner note icon rendering
Before: We drew 2 fontawesome comment icons, on on top of the other
After: Moved icon into iD spritesheet and gave it an actual `stroke` property that can be styled
2018-07-16 13:18:38 -04:00
Thomas Hervey bd1586500e added tests for notes service 2018-07-13 15:01:43 -04:00
Bryan Housel 8a1079c3c6 Update notes on status change 2018-07-13 00:15:30 -04:00
Thomas Hervey eafae6c58c WIP: update service calls; todo: note update event handling 2018-07-10 13:50:36 -04:00
Thomas Hervey 0f49514fbb updated: removed centering when clicking a note 2018-07-08 10:27:44 -05:00
Bryan Housel 7b42743513 pacify some eslint warnings 2018-07-07 23:00:48 -04:00
Thomas Hervey 73ee5c2fc9 fixed select_note mode, cleaned note_editor, TODO: enable note save 2018-07-03 22:45:51 -04:00
Bryan Housel b14d1b5061 resolve conflicts, fix a few minor bugs prob caused by merging:
- don't insert multiple times into the rtree in `services/osm.js`
- use `d.id` instead of `d.key` as the key in `svg/notes.js`
2018-07-03 16:40:07 -04:00
Bryan Housel a474e3bb9f Working on note editor style and ui, simplify d3 code 2018-07-02 12:35:07 -04:00
Thomas Hervey 2c22fe00a2 updated: hacky note hovering; todo: complete note click handling 2018-07-02 10:44:47 -04:00
Bryan Housel 13a30c050f Add some dots if there is a comment thread 2018-07-02 00:00:06 -04:00
Bryan Housel f3d31f3075 Update css styles for notes
- open notes are red (default)
- resolved notes are green
- orange on hover
- yellow on select (also added centerEase to note location)
2018-06-30 10:44:28 -04:00
Bryan Housel 2f8efee26a Draw 2x icons (shadow and fill) so they stand out more 2018-06-30 03:47:03 -04:00
Bryan Housel 229484a940 Cleanup osm service notes and caches, remove state variable
This seems like a lot but the main things here are:
- remove the _loadingTiles "global" variable.  It was causing problems because
it was being checked from the callbacks, which are async.
- cleanup the caches
- use DOM API getElementsByTagName('id') to get note id
- set a lower tilezoom z13 for notes (meaning: fetch larger bounding boxes)
2018-06-30 03:46:42 -04:00
Thomas Hervey b3f7b06f66 merged: services/notes into /osm; todo: fix some caching & rendering 2018-06-29 20:01:30 -04:00
Thomas Hervey 737ccfcfba updated: siebar displays note details on hover (via svg) 2018-06-29 14:43:01 -04:00
Thomas Hervey 0859d00195 updated: notes svg to prevent duplicate appending 2018-06-25 12:45:16 -04:00
Thomas Hervey 1878397387 remove console.log, change icon 2018-06-22 21:34:16 -04:00
Thomas Hervey dab46d2778 updated: notes rendering 2018-06-22 17:43:07 -04:00
Thomas Hervey 45761008bf cleaned: extraneous details in notes 2018-06-21 11:13:38 -04:00
Thomas Hervey 3df01e27c0 added: svg notes, TODO: add icon, test 2018-06-20 17:38:45 -04:00
Thomas Hervey cf2a9ad935 added: notes api service, parse and callback stubs 2018-06-19 17:01:56 -04:00
Thomas Hervey 3de1fd8e6f reformatted svg/notes 2018-06-19 10:45:58 -04:00
Thomas Hervey 1ed915e69c added: map data notes toggle 2018-06-19 10:31:26 -04:00