Quincy Morgan
ecc217f5d8
Add validation rule to flag impossible oneway highways and waterways ( close #6216 )
2019-04-26 12:04:43 -07:00
Quincy Morgan
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
Bryan Housel
2ebbb68604
Restore tooltips on rule checkboxes, separate 'tip' and 'reference'
...
Reference will show on clicking info button, and can contain more
useful information than a tooltip can.
2019-04-19 13:24:55 -04:00
Bryan Housel
01d2e3eaf3
Replace validator tooltip with reference function, add tag diff
2019-04-16 17:07:53 -04:00
Bryan Housel
294ce00211
substitute 'info' for 'data' (so I can use 'info' for an info drawer)
2019-04-15 16:56:21 -04:00
Bryan Housel
9100ce3ee4
Don't validate vertices which extend beyond the downloaded map
...
(closes #5938 )
2019-04-10 13:40:06 -04:00
Bryan Housel
6508edf820
Avoid anonymous functions as validators
...
Givnig them names makes it easier to understand in the profiler
2019-04-05 09:50:22 -04:00
Quincy Morgan
e71b139171
Simplify almost junction validation
2019-04-03 16:41:26 -07:00
Quincy Morgan
6641f62685
Reduce duplicate code in almost junction validation
2019-04-03 15:44:45 -07:00
Quincy Morgan
cbae090f08
Fix crash in almost junction validation
2019-04-03 14:23:21 -07:00
Bryan Housel
3673a7c7e7
Remove lodash cloneDeep
...
(re #6087 )
- some were able to do a different approach
(validations/almost_junction, and settings/*)
- some were replaced with custom speedy cloners
(in orthogonalize clonePoints and osm.js cloneNoteCache)
- some just replaced with JSON.parse(JSON.stringify()))
2019-03-29 17:18:40 -04:00
Quincy Morgan
af5012107f
Fix crash when drawing a favorite highway
2019-02-27 11:44:47 -05:00
Quincy Morgan
2d6c49b92b
Ignore proposed features for crossings ways, almost junction, and disconnected way validations ( close #5922 )
2019-02-21 10:14:25 -05:00
Quincy Morgan
ba68d921fe
Add icons for crossing ways fixes and almost junction connection fix
2019-02-20 09:02:05 -05:00
Quincy Morgan
b43796a4c7
Don't flag almost junctions for points endpoints that also occur earlier in the way
2019-02-19 09:16:32 -05:00
Quincy Morgan
397097ac1f
Tweak issue and fix strings
...
Different strings for one vs. a combination of deprecated tags
2019-02-15 14:24:11 -05:00
Quincy Morgan
1821c3e955
Update fixes UI for icons, link styling, and non-actionable fixes
...
Fix several bugs
2019-02-14 15:56:04 -05:00
Bryan Housel
c4fe42653a
s/coordinates/loc and replace legacy names in tests
...
In iD codebase `loc` is usually a single coordinate pair
and `coordinates` is usually an array of pairs
2019-02-12 21:18:25 -05:00
Bryan Housel
14896b0ce5
Documentation, and move validation type up to top of each file
2019-02-12 16:07:08 -05:00
Bryan Housel
251a83ff7a
Nitpicky code formatting stuff
...
- no multiline var declaration
- squish together and alphabatize imports
- linebreaks for readability
2019-02-11 13:55:58 -05:00
Bryan Housel
a6e05b8ac5
Rename for consistency - these are called "annotations" elsewhere
2019-02-11 13:36:02 -05:00
Quincy Morgan
5b8fea9e87
Use existing nodes where possible in the crossing ways connection fix
...
Fix a lint warning
2019-02-06 15:03:29 -05:00
Quincy Morgan
50fcff6ec9
Only check the edge nodes for almost junction merge fix
2019-02-06 14:12:19 -05:00
Quincy Morgan
7765baf03b
Make merge threshold consistent for almost_junction and tag_suggests_area connection fixes
2019-02-06 13:12:58 -05:00
Quincy Morgan
b25d75a6cc
Use existing nodes where possible in almost junction connection fix
2019-02-06 12:47:12 -05:00
Quincy Morgan
8545ebde8e
Add self-intersection check before flagging almost junction issues
2019-02-06 11:29:58 -05:00
Quincy Morgan
d3946894e8
Standardize deprecated_tag and missing_tag rule type ids
...
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan
973697b8ba
Run all validators in the validations folder if not manually run
...
Remove ValidationIssueType and ValidationIssueSeverity objects
2019-02-01 13:38:17 -05:00
Quincy Morgan
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
