4afd071a00
Add "Connect this feature" fix to disconnected ways if continuing drawing isn't possible
2019-05-03 12:59:18 -07:00
dbc3978d71
Add non-actionable fix recommendation to move very close points apart
2019-05-03 12:15:26 -07:00
ddc9d16b62
Merge pull request #6302 from openstreetmap/text-raw-tag-editor
...
Text raw tag editor / Copy-paste tags
2019-05-03 14:53:08 -04:00
b1d00db874
Show very close node issues on the parent way as well as on the points themselves ( close #6304 )
2019-05-03 10:40:12 -07:00
7b4a9a43b0
Change utilTagDiff to return an object with details
2019-05-02 22:59:41 -04:00
bfc944e30a
Fix two potential exceptions and one lint warning
2019-05-02 16:26:33 -07:00
ba9fd58fa9
Don't flag roads connected only to ferry routes as disconnected ( close #6287 )
...
Use common routable highway tag list for disconnected way check
2019-05-02 14:49:27 -07:00
0a71fd1e4f
Fix false positive for impossible oneway when connected way is circular
2019-05-02 12:18:21 -07:00
752bc72e7c
Fix issue where close nodes validation may not detect issues in some cases
2019-05-02 12:03:09 -07:00
b4dacdad2a
Reduce very close nodes validation threshold ( close #6292 )
...
Use spherical distances for very close nodes validation
Don't flag very close nodes from different ways
Don't flag very close nodes if both have interesting tags
Update very close nodes validation reference string
2019-05-02 11:39:12 -07:00
ed9a436318
Move common tag diffing code from validators into utilTagDiff
2019-05-02 11:16:15 -04:00
a4ebbaf7f5
Don't use the issue loc as a differentiator for all issues
2019-04-30 13:16:03 -07:00
26f1e29072
Merge branch 'master' into ignoring-issues
...
# Conflicts:
# data/core.yaml
# dist/locales/en.json
2019-04-30 13:05:07 -07:00
9d6b461d0e
Apply the crossing tag of the path to the node even if it's not a footpath when connecting crossing ways
2019-04-30 11:53:03 -07:00
07573091ad
Don't add a "crossing" tag to ambiguous crossings when connecting crossing ways via the quick fix (re: #6244 )
2019-04-30 11:46:15 -07:00
942d55a4bf
Update strings for duplicate node validation
...
Use routable highway tags for duplicate node validation instead of any highway tag
2019-04-30 10:18:22 -07:00
18dff285d0
add validation for very close node on road
...
addresses issue #6241
also made a change in inspector, so that when an untagged entity has issues,
show the entity editor so that the issues are visible when an item is clicked
in the issues pane.
2019-04-29 22:59:27 -04:00
375779882d
Add ability to ignore warnings
...
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
2019-04-29 17:52:32 -07:00
59bd6194e0
Add "autofix" for the unsquare building validation
2019-04-26 14:56:39 -07:00
ecc217f5d8
Add validation rule to flag impossible oneway highways and waterways ( close #6216 )
2019-04-26 12:04:43 -07:00
7d29a98a14
Add subtype to some validation issues
2019-04-25 10:35:27 -07:00
42de00e640
Add validation warning for "fixme" tags ( close #6214 )
2019-04-24 16:59:57 -07:00
aa91c2d768
Move old multipolygon warning into Outdated Tags rule ( close #6218 )
2019-04-24 15:46:50 -07:00
6a9c7b97a8
Don't flag websites on residential buildings
2019-04-24 15:21:49 -07:00
13f7e536dc
Move highway=road validation warning to the missing_tag validation rule (re: #6218 )
2019-04-24 15:19:57 -07:00
b30c91828f
Don't flag buildings with lots of nodes or buildings connected to other buildings as unsquare (re: #6215 )
2019-04-24 14:52:41 -07:00
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
34fcd01f98
Add validation warning for unsquare buildings
2019-04-23 15:50:52 -07:00
61da61d7fd
Add missing button arg to modeDrawLine, ensure using current entities
2019-04-22 20:00:53 -04:00
b5c5a00abc
Get rid of the many_deletions validation 🔪
...
It just doesn't fit in with all of the other validations that work on
entities, and it's not an actionable warning anyway.
https://github.com/openstreetmap/iD/pull/6140#issuecomment-483014618
2019-04-19 13:33:29 -04:00
2ebbb68604
Restore tooltips on rule checkboxes, separate 'tip' and 'reference'
...
Reference will show on clicking info button, and can contain more
useful information than a tooltip can.
2019-04-19 13:24:55 -04:00
9c4881cade
Change autofix to accept arguments to perform, implement "fix all"
2019-04-17 17:51:29 -04:00
0d70f0670d
Better test for whether untagged entities can be deleted
...
Now entities can always be deleted if the user created them in the first
place.. We skip asking `operationDelete.disabled()` because there are reasons
why this may return true.
A thing that could happen before:
- User creates an untagged entity
- Quits browser and restarts iD
- Restores history
- The entity happens to be in a part of the map that hasn't been loaded yet,
so `operationDelete.disabled()` returns true, and the issue ends up
as a 'warning' instead of an 'error'
2019-04-16 22:56:43 -04:00
01d2e3eaf3
Replace validator tooltip with reference function, add tag diff
2019-04-16 17:07:53 -04:00
294ce00211
substitute 'info' for 'data' (so I can use 'info' for an info drawer)
2019-04-15 16:56:21 -04:00
15e73d2836
Trying out simpler outdated_tags code, with tag diff
2019-04-14 17:25:51 -04:00
5a0f21fa7a
Add ability for a fix to be auto, and add auto fix buttons
...
This also changes some of the list items that were previously buttons to divs,
since we can't nest buttons.
2019-04-13 10:50:47 -04:00
da1fe8343a
Remove mode checking code from missing_tag, as these validate anytime
...
This was causing it to not immediately flag "area with no tags" as an error.
(until the user edited the area some other way)
2019-04-12 12:49:47 -04:00
569cbd1a92
entity.v can be 0, so check for === undefined instead
2019-04-11 14:40:34 -04:00
0a77a494aa
Merge branch 'master' into validation_and_change_perf
2019-04-10 14:22:20 -04:00
9100ce3ee4
Don't validate vertices which extend beyond the downloaded map
...
(closes #5938 )
2019-04-10 13:40:06 -04:00
6e6ed7fad5
eslint fixes
2019-04-05 19:01:12 +01:00
1328054b08
Allow for multiple invalid sources
2019-04-05 18:49:14 +01:00
6508edf820
Avoid anonymous functions as validators
...
Givnig them names makes it easier to understand in the profiler
2019-04-05 09:50:22 -04:00
8b1c0551cc
WIP: understand state held by the validator, avoid translations
...
- Make sure all state variables prefixed with `_`
- Add explicit `init`/`reset` methods
(graph/entity refs should never persist through a save to OSM)
- Thinking of how best cache validation results
2019-04-05 09:28:36 -04:00
65e04acb2f
Flag features that mention Google in the "source" tag ( close #6135 )
2019-04-04 08:32:03 -07:00
e71b139171
Simplify almost junction validation
2019-04-03 16:41:26 -07:00
6641f62685
Reduce duplicate code in almost junction validation
2019-04-03 15:44:45 -07:00
cbae090f08
Fix crash in almost junction validation
2019-04-03 14:23:21 -07:00
34792d7fbf
Don't add field defaults when upgrading tags to a specific replacement
2019-04-03 10:57:42 -07:00
Quincy Morgan