96c8bcb152
Add tooltip to delete feature fix explaining if it's disabled ( close #6588 )
2019-11-13 14:52:57 -05:00
24c72b64d1
Load issue fixes dynamically instead of cacheing them ( close #7037 )
2019-11-13 14:35:01 -05:00
c32cca2a71
Add additional comment to close nodes validation
2019-11-11 15:34:55 +01:00
bc39b0eb25
Don't flag nonstandard brands with a matching not:brand:wikidata tag ( close #6577 )
2019-11-11 14:56:05 +01:00
40edee1275
Don't flag very close nodes with different house or unit numbers ( close #6998 )
2019-11-11 13:40:37 +01:00
e85b6b9c45
Include default field values when upgrading a preset with a specific replacement ( close #7033 )
2019-11-11 13:25:49 +01:00
538829d171
Don't flag nonstandard brands from incompatible countries ( close #6513 )
2019-11-07 19:08:50 +01:00
3886f2dad8
Merge branch '2.15-building-crossing-layers' into 2.x
2019-10-24 15:15:06 -04:00
769c95af55
Add non-actionable fix suggestion for "Fix Me" request issues
2019-10-14 11:03:49 +02:00
56f31adcf1
Always sort the entity issues list deterministically
...
Don't skip validations just because a different validation produced issues
2019-10-12 17:01:03 +02:00
abd94a940f
Show non-actionable "Connect this feature" fix for disconnected roads and paths with both ends as noexits
...
Correctly reverse the "continue" fix icons for the right-to-left layout
2019-10-11 17:04:45 +02:00
d7bde50649
Locate impossible way issues at the questionable node, not at the center of the way's extent
2019-10-10 15:08:54 +02:00
bd1e1b34ff
Add subtypes to crossing_ways validation warnings
...
Allow the `indoor` tag to indicate a crossing feature is indoors
2019-10-09 15:24:42 +02:00
a3d6097d40
Rename "Fix Me" Requests validation rule to more general Help Requests
...
Add subtypes to almost_junction and disconnected_way validation rules
Add additional validation documentation (re: #6100 )
2019-10-09 15:00:28 +02:00
d57807478e
Start validation documentation (re: #6100 )
...
Add subtypes to close_nodes and unsquare_way validations
2019-10-09 12:43:38 +02:00
7251a2ab90
Make "edited issues" mean "issues the user created" instead of "issues for features edited by the user"
...
Only include issues created by the user in the "warnings" changeset tags
Include counts of issues resolved by the user in the changeset tags (close #6459 )
Don't include "fixme" issue counts in "warnings" changeset tags since they're not created by the user (close #6658 )
Don't cache crossing ways issues at the rule level
2019-10-04 16:50:44 +02:00
badde3d583
Add warning for features with names that equal values in their not:name tag ( close #6411 )
2019-10-04 11:06:27 +02:00
f5995dffb0
Cherry pick crossing buildings fix
2019-10-03 20:09:49 +02:00
0dc890a9ee
Show more specific message when nonstandard brand has simply incomplete tags ( close #6909 )
2019-10-03 15:25:18 +02:00
9ccace9022
Don't warn about websites missing http:// or https:// ( close #6831 )
2019-10-01 18:34:20 +02:00
6a515576f1
Add an "Extract this point" quick fix for points-as-vertices validation warnings (re: #6319 )
2019-10-01 18:21:03 +02:00
525916da74
Recategorize tags_suggests_area validation rule into mismatched_geometry rule
...
Warn about points tagged as vertices and vertices tagged as points (close #6319 )
2019-09-26 10:56:30 +02:00
b8b8c66d02
Warn when multilingual feature names appear to be generic ( close #6876 )
2019-09-24 13:22:02 +02:00
1abcc7fccf
Show warning for elevator nodes that are disconnected from the highway network ( close #6812 )
...
Simplify disconnected way validation code
2019-09-13 15:17:48 -04:00
16747cf888
Cherry pick generic brand name fix
2019-08-15 13:49:02 -05:00
070cfec7c7
Specify that connecting waterways and highways with the fix will add a ford ( close #6734 )
2019-08-09 09:34:35 -05:00
5984f6b118
Don't flag google books as an incompatible data source ( close #6556 )
2019-07-09 09:58:39 -04:00
8003e7b3d3
Allow the layer and level tag to differentiate very close points ( close #6612 )
2019-07-05 10:17:15 -04:00
ca2c6b1098
Allow for some tags (takeaway) to be kept thru a NSI upgrade
...
(closes #6530 , closes #6581 )
2019-06-30 01:42:43 -04:00
2307125842
Remove existing NSI keys before upgrading to a NSI preset
...
(closes #6575 )
2019-06-30 01:24:42 -04:00
b10ae96d62
Don't suggest adding nonsquare=yes to physically unsquare buildings ( close #6332 )
2019-06-16 18:47:32 -04:00
67f7995559
Avoid stale "connect endpoints" fix for "tags imply area" that could cause invalid areas ( close #6525 )
...
Lower match score for man_made/bridge preset
2019-06-12 09:31:06 -04:00
2eff493d37
Add outdated tags validation issue subtype for noncanonical brands
...
Add specific warning message for noncanonical brands (close #6443 )
Don't allow autofixing noncanonical brand issues
2019-06-10 11:39:42 -04:00
f402748706
Fix email validation for unicode characters
...
Also fix format validation for lists with excess whitespace (6494#issuecomment-499620002).
2019-06-10 11:02:56 -04:00
1ed73b6531
Convert validation rules to validate against a specific graph, not always the current graph (re: #6459 )
2019-06-06 16:27:31 -04:00
0b8ddd9240
Fix email and website validation for empty values
2019-06-06 13:55:53 -04:00
f02238ce23
Fix varied validation messages and redeclaration
...
I've hijacked the data property for the purposes of changing the message
based on whether multiple values in a list are erroneous
2019-06-06 13:55:53 -04:00
591e41f5ec
Fix email and website validation for list values
...
Also improved the UI message to be more clear for websites and simplify
"is tagged with" to "has" which works in context.
2019-06-06 13:55:53 -04:00
770cffe7de
Add email and website format validation
...
Simple validation following the HTML5 standard for emails as we don't
expect POIs to have convoluted email addresses. Only checks the
`website` and `email` tags as these are what iD currently supports with
fields.
2019-06-06 13:55:53 -04:00
44349c8015
Swap wikidata/wikipedia for brand: tags if possible
...
(closes #6416 )
This also ignores any features with an office tag, to avoid
changing a wikipedia/wikidata tag on a corporate office.
2019-05-24 14:24:10 -04:00
149a0b43b3
Use latest entity at time of fix for private_data validation too
...
(re: #6407 )
2019-05-23 19:40:10 -04:00
5440467db0
Undo 5b8db55b4 and instead get latest entity at time of fix
...
Per conversation w @quincylvania we need the issue ids to remain
stable so that users can ignore them.
So instead of forcing a refresh by changing the `id` we will grab current
versions of entities at fix time so that tags aren't replaced wrongly.
2019-05-23 18:52:32 -04:00
5b8db55b47
Need issue id to actually change for d3 to replace it
...
(re: #6407 )
What's happening here is that the validator is updating the issues, but the
entity_issues component leaves the original issue in the list because the `id`
has not changed.
Need to review all the validators to see if others have this problem too.
2019-05-22 23:47:53 -04:00
28db4df86b
Flag detached points that are very close together ( close #6394 )
...
Fix lint error
2019-05-22 15:50:20 -04:00
030b4b3efa
Flag almost junctions between highways and themselves ( close #6373 )
2019-05-22 14:12:23 -04:00
82ab18dd8b
Show better warning message if tags and incomplete rather than deprecated ( close #6410 )
2019-05-22 09:38:47 -04:00
9a8623748f
Don't flag private data only buildings that are also offices ( close #6404 )
...
Flag private data on building=houseboat
2019-05-22 08:40:48 -04:00
460f136819
Lower default threshold for unsquare building detection to 5 degrees
...
Use the detection threshold for the action when fixing unsquare buildings
Don't disallow unsquare autofixing based on maximum angle
Disallow unsquare autofixing for features with wikidata tags
Don't toggle rule when selecting degree threshold field in Safari
Apply the change when pressing enter in the degree threshold field
Select the input when clicking the degree threshold field
Use the min or max threshold instead of the default when an input is out of bounds
2019-05-20 15:48:01 -04:00
39784cdd1f
Merge in master
2019-05-20 14:38:52 -04:00
e599488121
Lower the very close nodes warning threshold for buildings, building parts, and paths (re: #6374 )
...
Flag very close nodes in indoor features but with an extremely small threshold
2019-05-20 11:21:50 -04:00
Quincy Morgan