Commit Graph

38 Commits

Author SHA1 Message Date
Quincy Morgan
4d8d27f3c4 Rely more on mapillary selected photo key than photoviewer datum
Remove mapillary map feature selection outline when closing photoviewer
2019-12-11 17:53:03 -05:00
Quincy Morgan
0d5bd8b277 Store selected mapillary image by its key rather than its object
Properly sort selected mapillary signs and features above unselected ones
2019-12-11 17:15:36 -05:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
0edd10001e Removing more lodash: isEmpty, isNumber, some map/reduce/forEach
(re: #6087)
2019-03-27 13:32:35 -04:00
Quincy Morgan
7d0080a642 Persist the photo overlay layers via the URL query string (re: #5813) 2019-03-14 16:48:08 -04:00
Quincy Morgan
c65a4d038e Add photo overlay filter options for hiding flat and pano photos (close #5433) 2019-03-14 14:24:21 -04:00
Max Grossman
7f837c7e0c no need to generate service variable
ref #5929
2019-02-01 14:01:17 -05:00
Max Grossman
d894521143 just don't close viewer...
ref #5829
2019-02-01 13:55:10 -05:00
SilentSpike
129c28fb25 Fix street imagery selection highlight persistence
Root cause was the `select` mode removing the "selected" class from all
elements upon `exit()`. Easy fix is to use a different class (here
"currentView") for street imagery elements.
2019-01-29 13:26:53 +00:00
SilentSpike
99f7a90387 Fix imagery layers resetting eachother's classes
Fixes:
- Selecting a bubble then enabling a second imagery layer removes the hovered and selected highlighting
- If multiple imagery layers are enabled and you select a bubble it only temporarily becomes highlighted
- If multiple imagery layers are enabled and a bubble is highlighted, hovering over another imagery layer's bubble will remove the selected and hovered highlighting

Basically these all came down to style updates resetting all layers for
cases other than when the viewport was changed (where doing so makes
sense because the selected bubble/sequence needs to update as a result).

See #5494
2019-01-29 13:25:47 +00:00
SilentSpike
da41d9d921 Fix mouseover events on imagery layer bubbles
This is just a minor thing that doesn't usually alter visible behaviour.

The mouseover and mouseout events would fire when moving between child
elements of the svg group which was unnecessary.
2019-01-29 13:24:01 +00:00
Bryan Housel
1731ce4651 Partition viewport by tiles, not by pixels
(closes #4297)

The previous approach split the viewport up by pixels, but each time the view
moved, the pixels would change, so it was not a stable selection of the
streetview data, and the markers would fight for position as the user moved
around.

This approach uses utilTiler to partition the view into stable tiles.
2018-11-14 14:48:42 -05:00
Matias Volpe
c000da07af Leave directional indicator only for current image 2018-07-19 09:49:00 -03:00
Matias Volpe
aac394a487 Update directional indicator based off of current bearing in Mapillary JS 2018-07-19 08:45:28 -03:00
Bryan Housel
6d7659b3bb Refactor common helper code to svg/helpers.js, add area nopes 2017-12-21 10:36:02 -05:00
Bryan Housel
d53637618e Draw selected marker big, fix draw ordering issues, fix close button 2017-11-09 11:27:36 -05:00
Bryan Housel
9dac13a915 Show only linestrings at low zooms 2017-11-08 16:46:53 -05:00
Bryan Housel
0702c66834 Improve sign hover/selected, fix Mapillary viewer setup for signs layer 2017-11-08 15:30:45 -05:00
Bryan Housel
4571fd0563 Highlight selected/hovered streetview tracks, fade unselected
Also some code cleanups and nitpicky variable renames
More consistency in Mapillary/OpenStreetCam services
2017-11-08 00:35:44 -05:00
Bryan Housel
fb063aa2c5 Render panoramic Mapillary viewfields as a sphere instead of arc
(closes #3154)
2017-11-07 01:04:11 -05:00
Bryan Housel
095dc19164 Add sequence linestrings to mapillary photo layer too 2017-11-06 21:32:03 -05:00
Bryan Housel
9edae82673 Convert lodah-es and d3 to named imports for svg 2017-09-25 23:16:24 -04:00
Bryan Housel
b21c2933af Faster layer disable/enable transitions 2017-09-18 22:02:16 -04:00
Bryan Housel
941d026b7c Adjust max Mapillary pages fetched per zoom, min viewfield zoom
For performance around densely mapped areas like SF
2016-11-17 12:07:14 -05:00
Bryan Housel
9ee790c1cc Don't need to pass dimensions to sublayers.. use projection.clipExtent
(the dimensions call to layers is to set width/height on svg surface element)
2016-10-30 22:40:11 -04:00
Bryan Housel
7c5a4df64d Hide Mapillary viewfields at low zoom 2016-10-29 13:28:17 -04:00
Bryan Housel
5c5e90c411 Upgrades for mapillary 2.0.0 2016-10-28 14:23:21 -04:00
Bryan Housel
053074d076 Export live binding for services in iD.services, fix init/reset
(closes #3324)

Previously we allowed devs to swap out services that they didn't need.
This became difficult now that ES6 exports are immutable bindings.
But we can wrap the immutable bindings themselves in a live object,
to get back the flexibility that we used to have.

This change also drops the `taginfo` accessor on Context, since devs who want
to swap out taginfo service with something else can now do so through the live
binding.  `iD.services.taginfo = myTaginfo()`
2016-10-14 10:38:09 -04:00
Bryan Housel
3102a4ae6a Rename all the things to include pseudonamespaces 2016-10-04 19:06:20 -04:00
Bryan Housel
a6d683eaf7 Code cleanups in svg, ui for selection merging, fix Mapillary. 2016-09-17 23:26:49 -04:00
Bryan Housel
a86f34b4ef Pacify eslint, get build and tests running again 2016-08-26 01:15:07 -04:00
Tom MacWright
a59b0d9fdf Fix transitions and multis 2016-08-24 10:42:34 -04:00
Tom MacWright
cdb533fa84 Begin d3 v4 update 2016-08-21 15:19:27 -04:00
Tom MacWright
8819d3d061 Remove continued iD references (#3341)
* Remove continued iD references

* make build.js safe enough to dodge json plugin bug

* Package as an iife to avoid var name issue
2016-08-10 20:06:45 -07:00
Tom MacWright
604d1e2719 import lodash (#3257) 2016-07-19 12:04:16 -04:00
Kushan Joshi
fc680a2e9a external modules for services 2016-07-06 14:39:58 -04:00
Kushan Joshi
b3492b17a0 external modules for SVG 2016-07-06 14:39:14 -04:00
Beau Gunderson
fb838645ae refactor svg into ES6 modules for #3118 2016-06-16 11:58:23 -07:00