Bryan Housel
ddc9d16b62
Merge pull request #6302 from openstreetmap/text-raw-tag-editor
...
Text raw tag editor / Copy-paste tags
2019-05-03 14:53:08 -04:00
Bryan Housel
16ec25753d
Support escaping of tricky characters, support quoted strings
...
keys or values can be quoted or unquoted:
- leisure=park
- leisure="park"
- "leisure"=park
- "leisure"="park"
2019-05-03 14:42:35 -04:00
Quincy Morgan
cc85897348
Fix map pane animation on RTL layout ( close #6290 )
2019-05-03 11:05:10 -07:00
Bryan Housel
22b7e03d3b
Disable spellcheck in the tag textarea
2019-05-03 10:39:38 -04:00
Bryan Housel
8a4e822fd7
If All Fields section is hidden, focus textarea and put cursor at end
2019-05-03 10:33:50 -04:00
Bryan Housel
fbe5389ecb
Set textarea height to fit content
2019-05-03 10:14:53 -04:00
Bryan Housel
c95860f36d
Convert changes in the textarea back to tag changes
2019-05-02 23:01:33 -04:00
Bryan Housel
61819058d3
Avoid frequent reflow from setting scrollTop
...
(possibly re: #6289 )
2019-05-02 14:21:57 -04:00
Bryan Housel
b17e4e4f1d
Add 'list'/'text' toggle buttons
2019-05-02 13:49:26 -04:00
Bryan Housel
cebe4ced8a
Preserve user's preference for 'list'/'text' view for the raw tag editor
2019-05-02 11:17:06 -04:00
Bryan Housel
af97f09150
Remove "key=value" pasting into raw tag editor key
...
(Reverts: #6211 , #5070 , #5024 )
The old code allows users to circumvent the readonly tag protection
see https://github.com/openstreetmap/iD/issues/6185#issuecomment-488692351
We'll offer a text-mode instead, with stricter checks on which keys can be modified.
2019-05-02 10:22:37 -04:00
Quincy Morgan
a180c794cb
Merge branch 'master' into ignoring-issues
2019-05-01 20:13:49 -07:00
Quincy Morgan
712f8bcb03
Avoid having hidden issues strings for both singular and multiple variations
2019-05-01 20:13:09 -07:00
Bryan Housel
ea40634ac6
Add list<->text toggle for raw tag editor
2019-05-01 21:53:43 -04:00
Bryan Housel
087f252b18
When removing a tag, remove it from _indexedKeys too
...
(re: d026f2f / #5927 )
So that if the user decides to put it back, it will be sorted to the
end and not inserted back at its original position in the middle
2019-05-01 19:17:59 -04:00
Quincy Morgan
eeaad79cb1
Display info about hidden issues in the "no issues" UI
2019-05-01 14:50:56 -07:00
Quincy Morgan
1c15338bd5
Make reset ignored button consistent with enable/disable all rules buttons
2019-05-01 12:13:10 -07:00
Quincy Morgan
56544303ca
Merge branch 'master' into ignoring-issues
2019-05-01 11:58:39 -07:00
Quincy Morgan
52d92f125c
Add button to reset ignored issues
...
Don't cache issue extent
2019-04-30 16:32:36 -07:00
Bryan Housel
d026f2f296
Add index property to tag rows, don't reorder on modifying key
...
(closes #5927 )
2019-04-30 18:22:11 -04:00
Quincy Morgan
26f1e29072
Merge branch 'master' into ignoring-issues
...
# Conflicts:
# data/core.yaml
# dist/locales/en.json
2019-04-30 13:05:07 -07:00
Quincy Morgan
ddae6641b3
Fix issue where preset list would not appear when adding new features ( close #6271 )
2019-04-30 09:42:24 -07:00
Bryan Housel
dbb10bb155
Just update save count on all changes
...
(closes #6239 )
2019-04-30 10:02:00 -04:00
Ming Gao
18dff285d0
add validation for very close node on road
...
addresses issue #6241
also made a change in inspector, so that when an untagged entity has issues,
show the entity editor so that the issues are visible when an item is clicked
in the issues pane.
2019-04-29 22:59:27 -04:00
Bryan Housel
a3605f9b74
Comment out "anchor encoding" for wiki links
...
(closes #6232 )
2019-04-29 22:53:16 -04:00
Quincy Morgan
375779882d
Add ability to ignore warnings
...
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
2019-04-29 17:52:32 -07:00
Bryan Housel
fceb1a86f7
Merge pull request #6245 from openstreetmap/d3-v5
...
d3 v5
2019-04-29 15:46:08 -04:00
Quincy Morgan
ea05d4e672
Unhighlight features when clicking issue quick fix ( close #6219 )
2019-04-26 16:26:19 -07:00
Quincy Morgan
3fad3513c1
Don't zoom to the feature and remove hover-highlighting upon clicking the issue fix button in the issues pane
2019-04-26 16:05:10 -07:00
Quincy Morgan
239c622044
Don't tag redundant ignored warnings counts on changesets
2019-04-26 13:02:13 -07:00
Bryan Housel
b99be67169
When calling an errback from a Promise.catch, pass err.message
2019-04-25 21:58:36 -04:00
Quincy Morgan
7d29a98a14
Add subtype to some validation issues
2019-04-25 10:35:27 -07:00
Quincy Morgan
f2ca5316b0
Add total ignored warnings count to changeset tags (re: #6123 )
2019-04-25 09:34:07 -07:00
Quincy Morgan
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
Bryan Housel
48b1ddc925
Rename fetch to fetchComboData to not conflict with fetch API
2019-04-24 16:24:36 -04:00
Bryan Housel
a37ce90af7
Move "Fix All" from bottom of list to top
2019-04-23 17:42:14 -04:00
Quincy Morgan
4948474118
Set the default validation filters to be My Edits / Everywhere (re: #6223 )
2019-04-23 10:34:10 -07:00
Bryan Housel
7e04175559
Add Enable All / Disable All validation rules links
...
(closes #5986 )
2019-04-23 13:01:15 -04:00
Bryan Housel
1d4770a3c6
Merge pull request #6211 from AndreasHae/feature/split-multiple-tags
...
Handle multiple tags when splitting up in tag editor
2019-04-23 11:05:03 -04:00
Bryan Housel
a3bc164c43
Redraw entity editor fields on addition, deletion too
...
This is important to make the turn restriction editor work
2019-04-23 01:07:38 -04:00
Bryan Housel
3fe9d75f35
Fix issues with issue cache for entities that no longer exist
2019-04-22 19:35:23 -04:00
Andreas Hässler
e49fdce215
Add missing semicolons
2019-04-22 23:43:55 +02:00
Andreas Hässler
2596b97dbc
Do not use ES6 features
2019-04-22 16:38:33 +02:00
Andreas Hässler
faa178797d
Handle multiple tags when splitting up
2019-04-22 16:22:59 +02:00
Bryan Housel
bbf4495f5c
pacify eslint
2019-04-19 23:44:49 -04:00
Bryan Housel
7c85cc997e
Merge branch 'master' into validation_and_change_perf
2019-04-19 22:44:04 -04:00
Quincy Morgan
b566ef05b5
Add Option+W shortcut to toggle the OSM data layer ( close #6104 )
2019-04-19 14:51:53 -07:00
Bryan Housel
51c1088c1b
Merge branch 'master' into validation_and_change_perf
2019-04-19 15:18:23 -04:00
Bryan Housel
b5c5a00abc
Get rid of the many_deletions validation 🔪
...
It just doesn't fit in with all of the other validations that work on
entities, and it's not an actionable warning anyway.
https://github.com/openstreetmap/iD/pull/6140#issuecomment-483014618
2019-04-19 13:33:29 -04:00
Bryan Housel
2ebbb68604
Restore tooltips on rule checkboxes, separate 'tip' and 'reference'
...
Reference will show on clicking info button, and can contain more
useful information than a tooltip can.
2019-04-19 13:24:55 -04:00