Commit Graph

42 Commits

Author SHA1 Message Date
Tobias Zwick f1d9b82831 inherit preset.removeTags from preset.addTags if not defined 2019-04-30 09:50:47 +02:00
Quincy Morgan 228af9a000 Move areaKeys and setAreaKeys to modules/osm/tags 2019-04-26 12:53:05 -07:00
Quincy Morgan d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Quincy Morgan 34792d7fbf Don't add field defaults when upgrading tags to a specific replacement 2019-04-03 10:57:42 -07:00
Bryan Housel 5b4aa529de Replace lodash uniq
(re: 6087)
2019-03-27 02:43:25 -04:00
Bryan Housel 4821bf0a68 Remove lodash omit
(re: #6087)
2019-03-26 14:12:45 -04:00
Bryan Housel 0e90167513 Remove lodash clone
(re: #6087)
2019-03-22 23:18:25 -04:00
Quincy Morgan 705f15aadd Speed up search by cacheing preset text values and not scrolling to focused node as often 2019-03-21 11:19:20 -04:00
Quincy Morgan 933569f8c6 Inherit check fields even if they define the preset 2019-03-13 12:59:06 -04:00
Quincy Morgan 3723c741f1 Add border to point icons in top bar 2019-03-02 14:47:48 -05:00
Quincy Morgan 12b1af7002 Don't say tags imply area for tags that iD doesn't have a preset for (close #5933) 2019-02-25 12:42:39 -05:00
Quincy Morgan 63caa02cea Allow presets to inherit multiCombo and semiCombo fields even if they define the preset 2019-02-19 15:48:50 -05:00
Bryan Housel fbe584c7ec Lookup docs for some presets on wikidata, not wikibase
(re: #5823)

Now `uiTagReference` can accept a `qid` param for presets where we want this
(such as brands)
2019-02-08 16:27:33 -05:00
Bryan Housel 17bbc3d5a2 Slightly improve suggestion placement, preset search performance
- avoid lodash _filter when native filter is ok for arrays
- for suggestions use `originalName` instead of adding/removing the en-dash
- bump up importance of leading suggestions, but do a strict leading search

more on that last point:
For normal presets, we count a string as leading if it follows a space.
e.g. "office" will match "Law Office"
We don't really want this for suggestion presets though
e.g. "bell" should not match "Taco Bell"
2019-01-29 21:56:23 -05:00
Bryan Housel 20bcfc5730 Delimit name-suggestion-preset names on en-dash, not hyphen
To avoid conflicts with hyphenated names, or bilingual names
with hyphens in them (like used in Brussels)
2019-01-23 09:44:24 -05:00
Quincy Morgan bb4d0a9282 Fixes false error when a preset inherits fields from a preset with no fields 2019-01-17 15:40:42 -05:00
Quincy Morgan 9ad217dce3 Fixed broken preset field inheritance 2019-01-17 09:49:48 -05:00
Bryan Housel 0773fedb8f Fix undefined fieldID.indexOf('{') > -1 causing tests to fail 2019-01-16 22:13:56 -05:00
Bryan Housel d506487069 Use the full preset path in name() instead of just first 2 parts 2019-01-15 17:15:35 -05:00
Quincy Morgan 4252c5cb36 Presets no longer inherit fields for keys that define them 2019-01-15 13:52:03 -05:00
Quincy Morgan 4b2c380b18 Changed preset field inheritance to target specific presets rather than just the parent preset 2019-01-15 13:07:58 -05:00
Quincy Morgan ae7c099c8a Moved field inheritance resolution from the data build to the preset initialization
Removed the data build check for duplicate values between fields and moreFields
Renamed the shop field from Type to Shop Type
Renamed the beauty field from Shop Type to Beauty Specialty
Added the brand field to the shop preset under moreFields
2019-01-15 09:53:26 -05:00
Max Grossman 96e44be69c merge 2.12.2 2018-12-13 11:22:32 -05:00
Max Grossman f3e6459191 working on preset visibility 2018-12-13 11:16:24 -05:00
Quincy Morgan 4285f2f5c0 Added "moreFields" property to the field schema
The "Add field" dropdown can now be used to add preset-specific fields in addition to universal fields
2018-12-09 13:51:57 -08:00
Bryan Housel ea9e3008a5 addTags() -> setTags() / removeTags() -> unsetTags()
This avoids overriding the `addTags` and `removeTags` objects with functions
2018-11-21 12:59:43 -05:00
Bryan Housel 622621ca89 Improve suggestion combo behavior in the name field
- adds minItems(1) so it will match
- displays up to 10 suggestions
- correctly removes old tags by setting the `undefined`
- adjust the name distance scoring
- only shows name suggestions if the preset can benefit from them
  (i.e. a generic/fallback or a preset that has some suggestions in the index)
2018-11-21 11:15:03 -05:00
Bryan Housel 8abc39461b Fallback Area preset should preserve the area=yes tag
(closes #4424)
2017-10-10 20:54:41 -04:00
Bryan Housel d53e473474 Convert lodah-es and d3 to named imports for presets 2017-09-25 14:20:24 -04:00
Bryan Housel 9c738cb5b7 Restore preset ordering test with leading terms (regressed in af776501)
The ordering did not actually change, but the test was failing because
it was throwing away the preset terms.. preset.terms() actually returns
translated terms not original terms, and should default to returning the
original terms when translations are not available (like in testing).
2017-09-10 12:56:07 -04:00
Bryan Housel 9882cf1d7b Don't rm old preset tags post merge, but do rm area=yes when setting preset
(closes #4114)
2017-06-22 17:49:45 -04:00
Bryan Housel eda2650d7b Omit name tag when looking up preset documentation
(closes #4059)
2017-05-21 22:05:40 -04:00
Bryan Housel 86c5db8c70 Add ability to specify the reference lookup for presets
(closes #3227)
2017-05-07 11:52:30 -04:00
Bryan Housel 5e7919e78c Consider matchScore when sorting the preset list 2017-03-12 19:01:15 -04:00
Bryan Housel 3102a4ae6a Rename all the things to include pseudonamespaces 2016-10-04 19:06:20 -04:00
Bryan Housel a86f34b4ef Pacify eslint, get build and tests running again 2016-08-26 01:15:07 -04:00
Tom MacWright 6341d4e4b5 one-shot build (#3266)
* One-shot development

* Move jsonp to module
* Tooltip -> module
* Remove d3.jsonp
* Fix tooltip lint
* Load all libs but d3 itself with require
* Add top-level brfs

* Unformat intro graph
2016-08-10 15:25:19 -07:00
Minh Nguyễn e99afbe1c1 Fixed taginfo for relation presets
taginfo’s relation/wiki_pages method no longer places results in a data property.

Also, only use relation/wiki_pages for top-level relation presets. More specific presets behave like non-relation presets. For example, the bicycle route relation has the tags type=route route=bicycle, so route=bicycle is what we’re interested in.

Fixes #3297.
2016-08-02 00:18:52 -07:00
Tom MacWright af776501d3 Require locale, second pass (#3259)
* Require locale, second pass

* Remove t global, remove t where it isn't needed
2016-07-21 16:20:13 -04:00
Tom MacWright 604d1e2719 import lodash (#3257) 2016-07-19 12:04:16 -04:00
Bryan Housel 0b3df36da0 Replace diacritics when doing fuzzy searches
(closes #3159)
2016-07-07 23:54:00 -04:00
Beau Gunderson 4dbce64b7d migrate presets to ES6 modules for #3118 2016-06-14 20:44:05 -07:00