Commit Graph

41 Commits

Author SHA1 Message Date
Bryan Housel e981cd5dd5 Switch mapillary and openstreetcam tests to work async
- can't reliably use sinon.spy to tell whether a thing has been called,
  so we listen for events instead and check server.requests()
- make sure to request the next page before dispatching `loadedImages` so
  we can `server.respond()` to the request in the event handler if we want to
- also moves `localeDateString` in the openstreetcam service from parsing
  code to display code, because it's very slow (we can just do this for the
  images we look at, instead of all images we fetch)
2019-04-29 15:31:08 -04:00
Bryan Housel e6bc9d9e8f Swap out d3-request, swap in d3-fetch 2019-04-24 16:25:25 -04:00
Bryan Housel 4a8c20c56e Remove lodash forEach
(re: 6087)
2019-03-28 19:50:20 -04:00
Bryan Housel 5e1ff74199 Replace lodash difference, intersects, union
(re: 6087)
2019-03-27 01:22:11 -04:00
Bryan Housel ff4f8f005f Remove lodash find and findIndex
(re: #6087)
2019-03-22 17:31:41 -04:00
Quincy Morgan 7d0080a642 Persist the photo overlay layers via the URL query string (re: #5813) 2019-03-14 16:48:08 -04:00
SilentSpike 129c28fb25 Fix street imagery selection highlight persistence
Root cause was the `select` mode removing the "selected" class from all
elements upon `exit()`. Easy fix is to use a different class (here
"currentView") for street imagery elements.
2019-01-29 13:26:53 +00:00
SilentSpike 99f7a90387 Fix imagery layers resetting eachother's classes
Fixes:
- Selecting a bubble then enabling a second imagery layer removes the hovered and selected highlighting
- If multiple imagery layers are enabled and you select a bubble it only temporarily becomes highlighted
- If multiple imagery layers are enabled and a bubble is highlighted, hovering over another imagery layer's bubble will remove the selected and hovered highlighting

Basically these all came down to style updates resetting all layers for
cases other than when the viewport was changed (where doing so makes
sense because the selected bubble/sequence needs to update as a result).

See #5494
2019-01-29 13:25:47 +00:00
Bryan Housel 1731ce4651 Partition viewport by tiles, not by pixels
(closes #4297)

The previous approach split the viewport up by pixels, but each time the view
moved, the pixels would change, so it was not a stable selection of the
streetview data, and the markers would fight for position as the user moved
around.

This approach uses utilTiler to partition the view into stable tiles.
2018-11-14 14:48:42 -05:00
Bryan Housel 08e9476f3e Fix photoviewer resize event 2018-11-06 13:09:04 -05:00
Bryan Housel 2fa593421f Rename scaleExtent to zoomExtent, slightly simplify getTiles() 2018-07-22 01:15:44 -04:00
Bryan Housel 7be9439c35 Use geoScaleToZoom to calculate zoom in Mapillary, OpenStreetCam 2018-07-21 21:59:35 -04:00
Bryan Housel c0b77d8226 remove unneeded dimensions argument (projection clipExtent has it) 2018-07-21 21:44:14 -04:00
Bryan Housel cd3d576276 rename geoTile -> tiler 2018-07-21 21:27:44 -04:00
Bryan Housel 02713e48fb Move cache management out of tiler, it's responsibilty of service
Also remove some unused code and eslint warnings
2018-07-21 11:11:39 -04:00
Bryan Housel d1fe81b905 rename utilTile -> utilTiler 2018-07-21 10:07:56 -04:00
Bryan Housel e4d829ec06 Have the tiler return filtered results - re: skipNullIsland 2018-07-21 10:03:40 -04:00
Thomas Hervey 386d375b7a fix excessive note tiling and network request 2018-07-19 10:51:39 -04:00
Thomas Hervey c563abaf7a pass dimensions to tile 2018-07-18 15:49:04 -04:00
Thomas Hervey 5bf3f7ed3e Merge branch 'master' into refactor-loadTiles 2018-07-18 07:26:56 -04:00
Bryan Housel e221dcae58 Dispatch new dimensions with photoview resize, resize all layers
-Adds ability to resize OpenStreetCam and Bing Streetside layers
-Also slightly increases the width of the resize handles
-Also limits max resize so it won't go larger than the map
2018-07-17 17:06:59 -04:00
Thomas Hervey d4b1622667 moved getTiles and filtering to utils 2018-07-14 19:15:25 -04:00
Bryan Housel cd7cdd95e9 Add "View on Bing Maps" link, cleanup css
(closes #5125)
2018-07-10 02:04:39 -04:00
Bryan Housel 696895fb98 Add forward/backward controls to Streetside viewer
re: #5125

There is some cleverness here to search for the best nearby bubble
instead of just relying on the next and previous sequence keys.
2018-07-10 01:10:18 -04:00
Bryan Housel e493bb4c64 Reset marker for panoramic/viewfield when switching steetview layer 2018-06-13 15:00:05 -04:00
Bryan Housel 18ab596f58 Improve int'l date/time strings on imagery and history tools
(closes #4594)
2017-12-06 15:27:54 -05:00
Bryan Housel cfa1759367 Add scroll zooming support to the OpenStreetCam viewer
(closes #4561)
2017-11-25 00:11:16 -05:00
Bryan Housel 91f9da0f06 Switch openstreetcam from http to https to avoid mixed content issues
(closes #4527)
2017-11-14 13:42:23 -05:00
Bryan Housel 1dd437a1f2 Hide mapillary-js attribution and just handle it in iD
(closes #4526)

What we were doing before was d3.selecting the attribution line and
inserting the capture date into it. This was confusing the viewer
(which updates asynchronously) so that the sitelink would never update.
To make things easier, we'll just hide the viewer's built in attribution
and construct the attribution line the way we want it.
2017-11-14 11:32:42 -05:00
Bryan Housel d53637618e Draw selected marker big, fix draw ordering issues, fix close button 2017-11-09 11:27:36 -05:00
Bryan Housel 0702c66834 Improve sign hover/selected, fix Mapillary viewer setup for signs layer 2017-11-08 15:30:45 -05:00
Bryan Housel 4571fd0563 Highlight selected/hovered streetview tracks, fade unselected
Also some code cleanups and nitpicky variable renames
More consistency in Mapillary/OpenStreetCam services
2017-11-08 00:35:44 -05:00
Bryan Housel d44b754656 Implement sequence step forward/backward 2017-11-06 16:06:25 -05:00
Bryan Housel 5f2b257ddc Swap clockwise/counterclockwise rotation buttons, change glyphs 2017-11-06 15:52:08 -05:00
Bryan Housel e439ea406a Cache sequence info, draw sequence linestrings 2017-11-06 15:48:44 -05:00
Bryan Housel eefbb68dda Add viewer controls.. Rotation works and will cache val per sequence 2017-11-06 10:41:17 -05:00
Bryan Housel ccc8153370 Standardize on "@user | captured_at | sitelink" for attribution 2017-11-05 22:46:53 -05:00
Bryan Housel 51fa9280a4 Add attribution line for openstreetcam 2017-11-03 21:20:14 -04:00
Bryan Housel dd75737fce Add loading spinner 2017-11-03 20:32:04 -04:00
Bryan Housel 6dd71ebf91 Fix loading of images from OpenStreetCam API, add viewer
\o/
2017-11-03 16:48:18 -04:00
Bryan Housel 00b30e29f0 WIP: Add OpenStreetCam support
todo: Need to figure out API issue with bbox, then imageviewer
2017-11-02 22:04:47 -04:00