Commit Graph

230 Commits

Author SHA1 Message Date
Quincy Morgan
760134c2aa Add check for possible missing activeEntity in drag_node 2019-05-08 12:17:36 -04:00
Bryan Housel
8f9dc7afb4 Improve localization of "Thank you for editing the map around.."
(closes #6269)
2019-05-04 13:24:46 -04:00
Bryan Housel
d7a569c425 Merge branch 'defer-select-for-6028' 2019-05-01 14:49:31 -04:00
Quincy Morgan
907df1c10e Include relation members when forcing relations visible in all cases, not just selection (re: 6eeaf94076) 2019-05-01 11:08:52 -07:00
Bryan Housel
d3f767d6f4 Code cleanups, prefix state variables with _ 2019-05-01 13:48:36 -04:00
Quincy Morgan
6eeaf94076 Show members of selected relations even when their feature layer is otherwise hidden (close #6220) 2019-04-24 17:28:56 -07:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
0a77a494aa Merge branch 'master' into validation_and_change_perf 2019-04-10 14:22:20 -04:00
Bryan Housel
81127d71f3 Cache disabled() results in straighten action for consistent response
What could happen was:
- user could right click on a line
- this would trigger `disabled()` checks for each operation buttons
- the line was not fully downloaded, so would return `disabled()` 'not_downloaded'
  (and also start download of the missing tiles)
- then the tooltip would pop into existence, calling `tooltip()`
- which calls `disabled()` again
- but this time it's fine and the `disabled()` is false
- so you'd see a greyed out button but the tooltip said everyting is ok and
  you can click the button anyway

I fixed this by just caching the disabled test.  This is probably ok anyway
because these tests can be expensive, and then the user will see a consistent
message like "The line is not yet fully downloaded".

If the user clicks off the line and back onto it, iD will reenter select mode,
rebuild the menu, redo the disabled test, and they will see the button enabled.
2019-04-10 10:19:23 -04:00
Quincy Morgan
9d029a37a8 Delete newly-created untagged relations when deselecting them (close #3812) 2019-04-07 13:39:51 -07:00
Quincy Morgan
bf391c997a Fix issue where Points walkthrough could not be completed in some cases due to downgrade operation (re: #6103) 2019-04-02 20:23:27 -07:00
Quincy Morgan
8779e1a6dc Add Downgrade operation to remove most tags from features but retain address and building tags instead of immediate deletion 2019-04-02 11:09:08 -04:00
Bryan Housel
d5abe468b9 Remove rest of the lodash iterators: map, reduce, forEach
(re: #6087)
2019-03-29 15:14:21 -04:00
Bryan Housel
5b4aa529de Replace lodash uniq
(re: 6087)
2019-03-27 02:43:25 -04:00
Bryan Housel
5e1ff74199 Replace lodash difference, intersects, union
(re: 6087)
2019-03-27 01:22:11 -04:00
Quincy Morgan
67fc051632 Tweak newFeature in select mode 2019-03-26 16:34:23 -04:00
Bryan Housel
1ce4f0ad6a Remove lodash without
(re: #6087)
2019-03-25 21:56:54 -04:00
Bryan Housel
76e0d13729 Remove lodash every and filter
(re: #6087)
2019-03-23 01:22:56 -04:00
Bryan Housel
0e90167513 Remove lodash clone
(re: #6087)
2019-03-22 23:18:25 -04:00
Bryan Housel
ff4f8f005f Remove lodash find and findIndex
(re: #6087)
2019-03-22 17:31:41 -04:00
Bryan Housel
11bfeaabfc Add browser-polyfills, remove lodash assign, compact, values
(re: #6087)
2019-03-22 17:14:41 -04:00
Quincy Morgan
fc6bf79ed1 Make Add Note shortcut translatable 2019-03-05 12:04:13 -05:00
Quincy Morgan
062872c4f0 Merge tags instead of adding new point when adding a point to a point
Fix lint error
2019-03-05 09:39:55 -05:00
Quincy Morgan
b828ada0e2 Don't allow adding point-only features as vertices 2019-03-04 17:04:35 -05:00
Quincy Morgan
971b901b21 Add 1 as the hotkey for focusing the search bar 2019-03-02 15:37:15 -05:00
Quincy Morgan
5ed5a7536b Show preset browser when adding generic point, line, or area 2019-03-01 09:07:41 -05:00
Quincy Morgan
1058a2cb27 Fix instances where adding favorite preset would not add tags 2019-02-27 12:27:54 -05:00
Quincy Morgan
2da011c3ca Remove unused string
Don't show preset browser when adding a favorite point
Don't automatically open the sidebar when selecting a non-new feature
2019-02-27 12:20:23 -05:00
Quincy Morgan
dead97e321 Reduce parameters for add modes
Tweak CSS classes
2019-02-26 15:17:04 -05:00
Quincy Morgan
a3424aa4b1 Merge branch 'master' into squash-favorite-preset 2019-02-26 14:25:34 -05:00
Quincy Morgan
ced652806b Fix an issue where some tagged nodes or existing vertices could not be snapped to (close #5942) 2019-02-25 08:54:30 -05:00
Quincy Morgan
7da37384f1 Fix an issue where stale missing tag errors could persist when canceling drawing a new way (close #5918)
Don't show missing tags error for a feature that is still being drawn (re: #5898)
2019-02-21 09:48:46 -05:00
Brian Hatchl
1faa6ad839 Favorite preset 2019-02-20 15:23:58 -05:00
Quincy Morgan
708c5e8155 Fix crash when undoing an added line past the first node 2019-02-19 12:10:05 -05:00
Quincy Morgan
b483832a80 Remove unused parameter 2019-02-18 14:14:36 -05:00
Quincy Morgan
058a8ee8ff Merge branch 'master' into validation 2019-02-15 12:03:57 -05:00
Quincy Morgan
96a1ec92c7 Fix prior commit
Apply same node snap suppression behavior to dragging vertices as to drawing ways
2019-02-15 10:28:43 -05:00
Quincy Morgan
c7e861c0ca Merge branch 'master' into validation 2019-02-14 12:16:23 -05:00
SilentSpike
a7e0c779b3 Persist forced visible entities on move/rotate 2019-02-12 22:25:47 +00:00
Quincy Morgan
ceee3c1a4b Merge branch 'master' into validation 2019-02-11 10:23:50 -05:00
Bryan Housel
151e2685d4 Force selectedIDs to be visible
(re: #5880)
2019-02-11 10:01:54 -05:00
Quincy Morgan
db319e8ff5 Merge branch 'master' into validation 2019-02-11 07:59:29 -05:00
Bryan Housel
ba44c80076 Force visible any entities related to a selected error
(closes #5880)
2019-02-10 23:29:49 -05:00
Bryan Housel
6e45796be7 Merge pull request #5875 from openstreetmap/dont-snap-non-vertices
Dont snap to non-vertices
2019-02-10 22:13:09 -05:00
Quincy Morgan
8771a33716 Merge branch 'master' into validation 2019-02-05 11:30:24 -05:00
SilentSpike
b55830485d Fix use of old variable name 2019-02-04 22:55:47 +00:00
SilentSpike
781558e56b Remove redundant source property 2019-02-04 18:40:06 +00:00
Quincy Morgan
8c51411ad6 Merge branch 'master' into validation 2019-02-04 08:58:10 -05:00
SilentSpike
214cf41019 Use more generic classes for errors 2019-02-01 22:50:57 +00:00
SilentSpike
4f2646d567 Add basic title + description UI 2019-02-01 22:50:54 +00:00