Commit Graph

38 Commits

Author SHA1 Message Date
Quincy Morgan
b57e5a75b8 Tweak issue pane icon badge 2019-02-15 12:19:48 -05:00
Bryan Housel
6a560861b2 Add notification badge to Issue pane icon 2019-02-13 16:56:17 -05:00
Bryan Housel
c292a32a66 Better message padding, remove double tooltip 2019-02-13 13:47:00 -05:00
Bryan Housel
448fe498bd Only recenter view if necessary, select after delay, fix maprules type 2019-02-12 17:25:54 -05:00
Bryan Housel
81bd734849 WIP uiEntityIssues cleanups, simplify
fixes are still not being applied properly
2019-02-11 20:44:02 -05:00
Bryan Housel
f4ccd8a3dc Update issue text/icon on update selection 2019-02-11 16:22:24 -05:00
Bryan Housel
a5ffec5665 utilHighlightEntities accept an array instead of calling it in a loop 2019-02-11 12:40:23 -05:00
Quincy Morgan
149e1b3e4d Removed unused string 2019-02-11 11:41:18 -05:00
Quincy Morgan
83f8cd97f6 Add feature highlighting when hovering over their corresponding issues 2019-02-11 09:45:33 -05:00
Quincy Morgan
ca8c91563b Add issue count to section title in entity editor
Remove redundant string
2019-02-04 16:48:54 -05:00
Quincy Morgan
bfb5285dc9 Fix tests and lint warnings 2019-02-04 13:34:27 -05:00
Quincy Morgan
190fc4f434 Add message to the issues pane for when there are no issues 2019-02-04 12:06:25 -05:00
Quincy Morgan
977e667453 Remove non-functional issue options from UI 2019-02-04 11:15:05 -05:00
Quincy Morgan
2677a88df4 Zoom to ways and relations upon clicking on their issues in the issues pane 2019-02-04 10:27:35 -05:00
Quincy Morgan
6514f645d1 Add error and warning count to the list titles
Hide error and warnings lists when there are no errors or warnings
2019-02-04 09:28:01 -05:00
Quincy Morgan
251d83f86c Show warnings and errors in different lists in the issues pane 2019-02-01 16:38:48 -05:00
Quincy Morgan
46f3cea33a Reorganize validation code
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
77c4d41855 Restore many deletions warning with tooltip and nicer message
Add tooltips back to issues pane list
Fix crash when restoring without having loaded the edited area
2019-01-30 15:48:06 -05:00
Quincy Morgan
94c8f9f9f7 Update text for features to edit 2019-01-29 14:48:18 -05:00
Quincy Morgan
80c7aedb39 Fix bug with issues pane 2019-01-29 11:59:01 -05:00
Quincy Morgan
33ae009936 Clarify wording of old_multipolygon issue and tooltip
Add quick fix for old_multipolygon issue
2019-01-24 11:01:41 -05:00
Quincy Morgan
01e2370cbd Add background color to the issue pane list 2019-01-24 08:37:46 -05:00
Quincy Morgan
7b288ef95d Add basic zoom-to-clicked-issue behavior 2019-01-23 15:25:55 -05:00
Quincy Morgan
4f1cb0dc46 Made the entity issues UI update when the issues reload 2019-01-14 12:33:32 -05:00
Quincy Morgan
2207a6c3a4 Added severity tooltip to issue icon 2018-12-19 18:35:17 -05:00
Andrew Wong
6e749c70ef listening to user generated history changes for validation 2018-12-19 17:28:34 -05:00
Quincy Morgan
490143d1a8 Added Issues section to the entity sidebar
Fixed bug where stale issues would stick around in the issues pane
2018-12-19 16:12:33 -05:00
Quincy Morgan
59b0252b0e Fixed several linting errors 2018-12-19 13:22:48 -05:00
Quincy Morgan
fb182dca37 Removed unneeded code in the issues pane 2018-12-19 13:10:03 -05:00
Quincy Morgan
6a931f9be6 Added colors to issue list icons
Corrected icon for warnings
Made disconnected_highway issue a warning instead of an error
2018-12-19 13:07:47 -05:00
Quincy Morgan
a95af00b1d Added icons to issues list 2018-12-19 12:40:42 -05:00
Quincy Morgan
a05e259628 Added some initial styling for issues list 2018-12-19 11:28:29 -05:00
Quincy Morgan
ff95e6a337 Merge branch 'validationIssueDataModel' into validation 2018-12-19 10:59:45 -05:00
Quincy Morgan
903cb63efe Renamed validations to issues in relevant places
Made the issue pane get the issues from the issue manager rather than validating itself
2018-12-19 10:41:58 -05:00
Xiaoming Gao
07a53fe6ea Extend data model for validation issues
Add the Issues pane

1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
  (1) add a severity level field (useful for identify save-blocking issues later)
  (2) replace single entity with an array of entities (useful for issues involving multiple entities)
  (3) add a coordinates field for highlighting the location of the issue on the map
  (4) add a fixes field for possible automatic fixes

3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
Quincy Morgan
0d0521c936 Moved feature applicability into the issue manager class 2018-12-19 10:32:14 -05:00
Quincy Morgan
c1240af464 Added options UI in the Issues pane with edited vs all features selection
Added basic issues list in the Issues pane
2018-12-18 17:04:40 -05:00
Quincy Morgan
cf0214d06a Add the Issues pane 2018-12-18 11:11:15 -05:00