Commit Graph

2582 Commits

Author SHA1 Message Date
John Firebaugh
7ec1222402 Try to insert relation members at a sensible index (#1539) 2013-06-05 16:00:53 -07:00
John Firebaugh
2d7cc2a2d1 Preserve member order as much as possible 2013-06-05 16:00:12 -07:00
John Firebaugh
33cf029d43 Extract and refactor iD.geo.joinMemberWays 2013-06-05 16:00:12 -07:00
John Firebaugh
467d01d339 First pass at "Add to Relation" (#1539) 2013-06-05 11:22:00 -07:00
John Firebaugh
3312c4aa4c Partially revert "Remove unnecessary grid classes"
This reverts commit 840c08f672.
2013-06-05 10:28:58 -07:00
John Firebaugh
d79b618947 Optimize feature list 2013-06-05 10:20:00 -07:00
John Firebaugh
47fbc31daf Cache browser detection 2013-06-04 18:38:33 -07:00
John Firebaugh
82a4f9c366 Avoid duplicate hover events 2013-06-04 18:33:23 -07:00
John Firebaugh
840c08f672 Remove unnecessary grid classes
These instances are mostly or entirely overridden by more
specific rules.
2013-06-04 18:03:25 -07:00
John Firebaugh
1557c6451b Improve feature list performance 2013-06-04 17:52:09 -07:00
John Firebaugh
f9ecf906d2 Need to include member in key function 2013-06-04 11:42:25 -07:00
John Firebaugh
a1d7d05155 Feature List (#1545) 2013-06-04 10:37:24 -07:00
John Firebaugh
6befa984db Fall back to ref tag for displayed feature name 2013-06-03 18:32:27 -07:00
John Firebaugh
20a2c4055b Fix preset search DOM structure 2013-06-03 17:31:04 -07:00
John Firebaugh
cc4f6b16a5 Fix tests 2013-06-03 17:04:01 -07:00
John Firebaugh
4b8ecc2dd7 Fix focus when undoing with autofocused preset search (fixes #1570) 2013-06-03 16:56:30 -07:00
John Firebaugh
1d7e168763 Don't need a separate 'select' event 2013-06-03 16:49:01 -07:00
John Firebaugh
a853de7b87 Fix vertex showing on hover 2013-06-03 16:43:41 -07:00
John Firebaugh
c68635062c Fix sidebar UI behaviors
* Restore preset search autofocus (fixes #1566)
* Should show hover in draw modes, not preset list
2013-06-03 16:28:30 -07:00
John Firebaugh
a84a3364cc selection -> selectedIDs
Overloading "selection" is a bad idea.
2013-06-03 15:48:03 -07:00
John Firebaugh
eebd9aa030 Remove unused 2013-06-03 15:30:23 -07:00
John Firebaugh
d5910dc97d Hide tag reference in hover state (fixes #1561) 2013-06-03 11:10:49 -07:00
John Firebaugh
b7f29a4407 Fix walkthrough (fixes #1568) 2013-06-03 10:39:43 -07:00
John Firebaugh
27ebc01f81 Fix intro reveal size (#1567) 2013-06-03 10:27:57 -07:00
John Firebaugh
fc692d8707 When deleting a vertex, reselect another vertex if possible
Fixes #1457.
2013-05-31 17:36:08 -07:00
John Firebaugh
5156358b07 Minimize number of sidebar rerenders 2013-05-31 16:27:47 -07:00
John Firebaugh
29e6880fc0 Calculate nearest streets only when needed 2013-05-31 16:18:43 -07:00
John Firebaugh
3b34b35d10 Render only the visible inspector pane 2013-05-31 16:18:18 -07:00
John Firebaugh
e98b489041 Remove unused 2013-05-31 14:31:23 -07:00
John Firebaugh
a51e932800 Do preventDefault behavior on ⌘Z and ⌘⇧Z
This prevents some instances of https://bugs.webkit.org/show_bug.cgi?id=117092,
and generally we don't ever want the default undo
behavior when these handlers are triggered.
2013-05-31 14:31:23 -07:00
John Firebaugh
0724e204e8 Don't preventDefault on mousedown events
This prevents focus/blur events from getting dispatched,
which was the root cause of #1295.

Fixes #1295.
2013-05-31 14:27:37 -07:00
John Firebaugh
f02df04102 Ensure all combobox inputs have a carat
Previously, the second combobox input for a given parent
element would wind up without a carat, because the data
bind would match the first carat.

Fixes #1549.
2013-05-30 15:50:40 -07:00
John Firebaugh
814535ad34 Add preventDefault on button clicks (fixes #1551) 2013-05-30 15:45:50 -07:00
John Firebaugh
3981279747 Fix member list redraws
d3 does not store the keys produced by a data bind -- it
recomputes them on the fly. The key function that was used
referred to `entity`, with the intent that rows referring
to the previous entity would wind up in the exit selection.
But since the key is recomputed for the existing bindings,
and at that point `entity` refers to the new entity, that
portion of the key effectively always matched.

While here, fix deletion of incomplete members (don't know
what the geometry is, so can't do geometry-specific annotations).

Fixes #1548.
2013-05-30 11:45:02 -07:00
saman bb
a145105a71 starting to style commit sidebar. 2013-05-30 01:52:50 -04:00
saman bb
4e63980834 fix whitespace. 2013-05-30 00:58:27 -04:00
saman bb
60449617a9 big cleanup of UI toggles, removed lots of redundancy,ect. 2013-05-30 00:53:07 -04:00
John Firebaugh
9874e417eb Fix "View on OSM" in sidebar footer
Fixes #1473.
2013-05-29 20:24:37 -07:00
John Firebaugh
e83423c7e2 Refactor UndoRedo, fix initial tooltip state
Fixes #1487.
2013-05-29 19:42:54 -07:00
John Firebaugh
c2fa4da23c Use "Unknown" if field doesn't define a placeholder
Fixes #1509
2013-05-29 19:21:07 -07:00
John Firebaugh
405fc899a9 Restore background color and close button to save headers 2013-05-29 19:11:49 -07:00
John Firebaugh
3a7c184e69 Move the save dialog to the sidebar 2013-05-29 17:47:33 -07:00
Saman Bemel-Benrud
b8b1a358e9 more animation fixes. 2013-05-29 20:30:56 -04:00
John Firebaugh
8c2c5357c7 Fix typo, localize 2013-05-29 16:10:57 -07:00
John Firebaugh
4bdd49b5fc Adjustments to multipolygon preset
* It shouldn't appear as a search result for simple areas.
* Changing to another area preset shouldn't remove the
  type=multipolygon tag.
* It shouldn't be preferred to the Building preset, which
  matches with score 0.5.

Fixes #1546.
2013-05-29 16:00:34 -07:00
Saman Bemel-Benrud
b7d2578fb8 adding placeholders for access preset. 2013-05-29 15:54:29 -04:00
Saman Bemel-Benrud
52aa970296 click preset icon to return to preset grid. 2013-05-29 15:40:12 -04:00
John Firebaugh
b55e7bb111 Fix one way marker rendering (fixes #1534) 2013-05-29 12:02:47 -07:00
John Firebaugh
e959002e03 Don't show preset list on hover (fixes #1535) 2013-05-29 11:12:42 -07:00
John Firebaugh
22342808b5 Add content wrapper (fixes #1532) 2013-05-29 11:00:07 -07:00