Commit Graph

570 Commits

Author SHA1 Message Date
John Firebaugh
7ec1222402 Try to insert relation members at a sensible index (#1539) 2013-06-05 16:00:53 -07:00
John Firebaugh
2d7cc2a2d1 Preserve member order as much as possible 2013-06-05 16:00:12 -07:00
John Firebaugh
33cf029d43 Extract and refactor iD.geo.joinMemberWays 2013-06-05 16:00:12 -07:00
John Firebaugh
a84a3364cc selection -> selectedIDs
Overloading "selection" is a bad idea.
2013-06-03 15:48:03 -07:00
John Firebaugh
3a7c184e69 Move the save dialog to the sidebar 2013-05-29 17:47:33 -07:00
John Firebaugh
4bdd49b5fc Adjustments to multipolygon preset
* It shouldn't appear as a search result for simple areas.
* Changing to another area preset shouldn't remove the
  type=multipolygon tag.
* It shouldn't be preferred to the Building preset, which
  matches with score 0.5.

Fixes #1546.
2013-05-29 16:00:34 -07:00
John Firebaugh
40526764bf Test / fix ChangePreset action 2013-05-29 08:44:59 -07:00
John Firebaugh
c14e2e600e Fix strokes sometimes being clipped as polygons
Fixes #1527.
2013-05-28 20:30:41 -07:00
John Firebaugh
5a8bf0fada Fix tests 2013-05-28 19:50:40 -07:00
John Firebaugh
56f8b9e4a9 Fixup after merge 2013-05-28 16:56:49 -07:00
John Firebaugh
1e8052182d Merge pull request #1247 from systemed/create-multipolygon
ability to create multipolygons
2013-05-28 16:56:22 -07:00
John Firebaugh
788bb13665 Fix tests 2013-05-28 15:02:50 -07:00
John Firebaugh
d088b39d34 Fix tests 2013-05-28 11:54:05 -07:00
John Firebaugh
884d2d0732 Add hover indicator in sidebar 2013-05-26 14:07:10 -07:00
John Firebaugh
a61e0c9fd4 Fix preset search 2013-05-24 17:17:41 -07:00
John Firebaugh
16e5f5e2ce Extract Entity#isUsed 2013-05-24 15:46:05 -07:00
John Firebaugh
5868875833 Split "other" preset into geometry specific fallbacks
This way the name and icon can be geometry-specific.
2013-05-24 11:14:59 -07:00
John Firebaugh
9c86e2a86c Display relation members and memberships in inspector
* Preset icon of relation/member
* Preset name of relation/member
* Name of relation/member
* Role
* Delete button

All currently unstyled.
2013-05-22 17:41:59 -07:00
John Firebaugh
cac654e8ab Add iD.actions.ChangeMember 2013-05-22 17:41:06 -07:00
John Firebaugh
1276672783 Add iD.actions.DeleteMember 2013-05-22 17:37:26 -07:00
John Firebaugh
ee4ec4e252 Fix tests 2013-05-22 17:36:41 -07:00
John Firebaugh
affdc987e4 Rename removeMember -> removeMembersWithID 2013-05-22 17:28:51 -07:00
John Firebaugh
4ae4b33663 Extract iD.ui.Disclosure 2013-05-22 16:51:18 -07:00
John Firebaugh
ebadc90ac7 Rename Taglist -> RawTagEditor 2013-05-22 16:51:18 -07:00
John Firebaugh
b70b287dee Rename TagEditor -> EntityEditor
It's going to be used to edit relation memberships as well
as tags.
2013-05-22 12:16:57 -07:00
John Firebaugh
fb01868a3c PresetGrid -> PresetList 2013-05-22 10:22:15 -07:00
John Firebaugh
bf21744077 Only draw intersections for {high,water,rail,aero}way lines
Fixes #1471
2013-05-20 17:16:36 -07:00
John Firebaugh
bd2c7ba756 Render bridge casing for bridge=viaduct, etc.
Fixes #1500.
2013-05-20 16:49:55 -07:00
John Firebaugh
67d95595ba Points always need full re-render (#569) 2013-05-20 12:05:31 -07:00
John Firebaugh
1db99586c4 Render only new features when a data tile is loaded 2013-05-20 12:05:31 -07:00
John Firebaugh
293bb23876 Graph#rebase must invalidate transients 2013-05-18 09:20:57 -07:00
John Firebaugh
2e4207f99b Cache geometry 2013-05-17 15:31:27 -07:00
John Firebaugh
da9602795c Don't allow deleting incomplete relations
This will fail with an "entity not found" error.
2013-05-16 16:43:41 -07:00
John Firebaugh
d238e4eaeb Convert Tail to a behavior
This avoids an extra mousemove listener in base modes.
2013-05-14 17:51:24 -07:00
John Firebaugh
6431fca8a3 Fix area caching (fixes #1485) 2013-05-14 16:52:02 -07:00
John Firebaugh
878a4c0074 Don't need member tags for area strokes
Member tags are for multipolygon members, and multipolygon
member strokes are rendered by iD.svg.Lines.
2013-05-13 21:45:26 -07:00
John Firebaugh
9502729f5e Optimize presets.match
Previous implementation was linear in the number of
presets. This should be near constant time.
2013-05-13 21:07:26 -07:00
John Firebaugh
525d37c647 Preset#matchTags -> Preset#matchScore 2013-05-13 17:48:18 -07:00
John Firebaugh
9495f8f1c0 Optimize area rendering
Use iD.svg.Path for caching, and teach iD.svg.Path to
round coordinates.
2013-05-13 17:48:18 -07:00
John Firebaugh
ba08ba6109 Fix tests 2013-05-13 13:07:30 -07:00
John Firebaugh
fd1573fa08 Abandon iD.svg.MemberClasses
Substantial performance hit for something that's barely used.
2013-05-13 12:46:01 -07:00
John Firebaugh
70e5411114 Optimize vertex rendering
* Cache icon
* Append rather than insert
* Do fewer things on update
* Don't create a fill unless needed
* Don't apply tag and member classes (never used)
* Drop down to raw setAttribute (d3 is slow :trollface:)
2013-05-13 09:37:48 -07:00
John Firebaugh
6060e886cb Reduce calls to iD.svg.TagClasses
For fills and shadows, style changes can happen only when
a new version of the feature is produced. If we include a
version number in the key, we need only call TagClasses on
the enter selection.

We cannot apply the same optimization for strokes, since
stroke style can depend on the tags of parent relations
as well.
2013-05-13 09:37:48 -07:00
John Firebaugh
0ae54abdcc Extract iD.actions.DiscardTags 2013-05-13 09:26:41 -07:00
John Firebaugh
a53d5cbb44 Optimize label hover
Add entity IDs to the element class list, so that specific
elements can be selected by ID rather than needing `filter`.
2013-05-12 11:47:48 -07:00
Tom MacWright
e434cab107 Basic tests for padByMeters 2013-05-09 12:25:38 -04:00
John Firebaugh
c7dedcb5ba Fix test 2013-05-08 13:28:40 -07:00
Tom MacWright
d585fb1ceb Test another corner case in geo 2013-05-08 09:12:16 -04:00
Tom MacWright
cadd50a7d5 Test iD.util.editDistance 2013-05-08 09:09:42 -04:00
John Firebaugh
08949d2fe9 Redo iD.geo.chooseIndex
It now calculates proper orthogonal projections and finds
the minimal one. Rename it iD.geo.chooseEdge and minimize
its coupling to context.

This version also copes with 0- and 1-node ways.

Fixes #1428.
2013-05-07 18:35:45 -07:00