Bryan Housel
322951bdc0
Add polyfill for Object.getOwnPropertySymbols for sinon
...
(closes #6001 )
2019-03-02 18:18:44 -05:00
Bryan Housel
3f8911c149
Merge pull request #5999 from openstreetmap/squarish
...
Improve orthogonalization action
2019-03-01 23:28:23 -05:00
Bryan Housel
fab6bd1d33
Support orthogonalizing a single vertex, add tests
...
(closes #2205 )
2019-03-01 23:20:50 -05:00
Bryan Housel
e64693eea5
Upgrade tests from legacy iD.Difference to iD.coreDifference
2019-03-01 16:03:21 -05:00
Bryan Housel
dd234df05b
Add tests for geoVecNormalize, geoVecNormalizedDot, geoVecProject
2019-03-01 14:09:33 -05:00
Bryan Housel
cb51c16c8f
Expand actionOrthogonalize tests, fix abs issue in canOrthogonalize
2019-03-01 13:45:00 -05:00
Quincy Morgan
4eabf2da07
Add unit tests for old multipolygon validation
2019-02-26 12:09:16 -05:00
Quincy Morgan
8a9399edb7
Add line geometry to traffic_calming=island preset (re: #5945 )
...
Add more unit tests for tag_suggests_area
Replace "finds" with "flags" in validation unit test labels
2019-02-26 11:30:03 -05:00
Quincy Morgan
12d770a05e
Add unit tests for missing role validation
2019-02-26 11:00:00 -05:00
Quincy Morgan
1f21b029fd
Move tag upgrade fix to an action and add unit tests
2019-02-26 10:42:12 -05:00
Quincy Morgan
12b1af7002
Don't say tags imply area for tags that iD doesn't have a preset for ( close #5933 )
2019-02-25 12:42:39 -05:00
Quincy Morgan
12a44421c3
Account for indoor features in crossing ways validation
...
Recommend using an appropriate structure/layer/level for crossing ways validation
Flag crossing highways on different levels but without bridges or tunnels
2019-02-19 11:43:05 -05:00
Quincy Morgan
c7e861c0ca
Merge branch 'master' into validation
2019-02-14 12:16:23 -05:00
Bryan Housel
c4fe42653a
s/coordinates/loc and replace legacy names in tests
...
In iD codebase `loc` is usually a single coordinate pair
and `coordinates` is usually an array of pairs
2019-02-12 21:18:25 -05:00
Quincy Morgan
bc5912881b
Add code tests for hidden boundary relation members (re: #5601 )
2019-02-11 16:31:51 -05:00
Quincy Morgan
db319e8ff5
Merge branch 'master' into validation
2019-02-11 07:59:29 -05:00
Bryan Housel
ba44c80076
Force visible any entities related to a selected error
...
(closes #5880 )
2019-02-10 23:29:49 -05:00
Bryan Housel
26368522c9
Batch changes from raw tag editor so blur/remove tag don't conflict
...
(closes #5878 )
2019-02-10 22:08:13 -05:00
Quincy Morgan
1564f73de6
Merge branch 'master' into validation
2019-02-07 20:51:21 -05:00
Bryan Housel
492bb5b37e
Eliminate magic scale numbers from tests, add loadNotes test xml
2019-02-07 11:31:32 -05:00
Quincy Morgan
4595a822dc
Add code tests for more missing_tag cases
2019-02-06 10:08:28 -05:00
Quincy Morgan
d3946894e8
Standardize deprecated_tag and missing_tag rule type ids
...
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan
bfb5285dc9
Fix tests and lint warnings
2019-02-04 13:34:27 -05:00
Quincy Morgan
8c51411ad6
Merge branch 'master' into validation
2019-02-04 08:58:10 -05:00
Bryan Housel
6be72709d5
Adjust tag_classes perimeter overrides to style barriers as lines
...
(closes #5761 )
2019-02-02 11:52:23 -05:00
SilentSpike
5030346257
Update data layers test
2019-02-01 22:51:00 +00:00
Quincy Morgan
9785021f44
Rename simpleMultipolygon functions to oldMultipolygon
...
Return old_multipolygon validation issues for the relations as well as the outer ways
Remove console logging
Don't run missing_tag validation for relations with old_multipolygon issues
2019-02-01 15:19:28 -05:00
Quincy Morgan
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
09bc2a6e6c
Merge branch 'master' into validation
2019-01-30 16:44:14 -05:00
Bryan Housel
09f7f9189f
Fix field tests to run with minimal set of presets
2019-01-30 16:29:27 -05:00
Bryan Housel
71b2d2c6b7
Upgrade legacy symbols in tests
...
- iD.Context -> iD.coreContext
- iD.Graph -> iD.coreGraph
- iD.Node -> iD.osmNode
- iD.Way -> iD.osmWay
- iD.Relation -> iD.osmRelation
2019-01-30 15:43:02 -05:00
Bryan Housel
7138acc652
Properly export areaKeys, fix preset and maprules tests
2019-01-30 15:29:37 -05:00
Bryan Housel
15c0b82eb2
First attempt to run tests with minimal preset config
2019-01-30 10:25:40 -05:00
Quincy Morgan
0b19d5f93a
Merge branch master into validation
2019-01-29 14:51:59 -05:00
Bryan Housel
7aea67fcfe
Merge pull request #5745 from jguthrie100/stop_merge_overlapping_self
...
Add check to stop joining ways if resulting way intersects itself
2019-01-29 14:07:34 -05:00
Quincy Morgan
f25a80c48c
Merge branch 'master' into validation
2019-01-28 12:14:04 -05:00
Bryan Housel
b9444ab991
Restore hand cursor on dropdown carat
...
(closes #5769 )
This change allows pointer events to flow to the caret, and forwards
them back to the combo input. Also renames several event handlers
for clarity, and increases the double-click detection threshold.
2019-01-26 13:22:31 -05:00
Bryan Housel
55715a4827
Try to dispatch an accept event on blur
...
(re: #5752 - but does not close it)
2019-01-25 14:47:17 -05:00
Quincy Morgan
4389bd8741
Merge pull request #5723 from gaoxm/almostJunctAutoFix
...
add auto-fix for almost junction by creating connection nodes
2019-01-23 13:24:48 -05:00
Quincy Morgan
0aff34d980
Merge pull request #5736 from gaoxm/fixCrossWayTest
...
fix tests for crossing way validation check
2019-01-23 13:24:27 -05:00
Quincy Morgan
e69f2a0389
Merge branch 'master' into validation
2019-01-23 13:15:33 -05:00
Bryan Housel
0c7b9a631e
Improve combobox event handling and avoid overwriting typed data
...
(closes #5722 , re: #5637 , re: #5618 )
dispatched with a value() string instead of a datum, which
causes issues for code expecting a datum always.
(such as localized.js brand picker or "Add Field" combo)
Fix for this coming in next commit.
2019-01-22 22:26:27 -05:00
J Guthrie
631ace27d5
Add check to stop joining ways if resulting way intersects itself
...
- Includes new test case
2019-01-22 03:07:38 +00:00
Minh Nguyễn
9e3d49efb7
Replace wkid/w/s/n/e in WMS URL templates
2019-01-19 15:42:22 -08:00
Bryan Housel
19a8f5c47c
Remove test that only works if we can reliably simulate clicks
...
Previously the combo showed immediately on mousedown, now it
shows on mouseup after some slight delay.
2019-01-18 23:34:59 -05:00
Bryan Housel
1ec5b708fc
Restore default click behaviors on mousedown of a combobox
...
(closes #5732 )
2019-01-18 23:23:35 -05:00
Xiaoming Gao
08bc219e6f
fix tests for crossing way validation check
...
There're still test failures for "Almost Junction"; those are fixed
in a separate PR.
2019-01-18 22:26:27 -05:00
Xiaoming Gao
aa5f1aec5b
add auto-fix for almost junction by creating connection nodes
2019-01-16 20:02:25 -05:00
Yuri Astrakhan
d724677c9f
Support extracting wiki info from tag and key
2019-01-15 21:50:57 -05:00
Quincy Morgan
11b2102761
Merge branch 'master' into validation
...
# Conflicts:
# data/core.yaml
# dist/locales/en.json
# modules/ui/commit_warnings.js
# modules/ui/entity_editor.js
# modules/util/index.js
# modules/util/util.js
# modules/validations/index.js
# modules/validations/many_deletions.js
# modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00