Commit Graph

753 Commits

Author SHA1 Message Date
Quincy Morgan 99eddb35c3 Make unavailable location error punctuation consistent with other flashed errors 2020-03-09 13:21:50 -07:00
Quincy Morgan 10f7ef2704 Add error feedback text when attempting to draw self-intersecting ways 2020-03-06 15:36:48 -08:00
Quincy Morgan 135fd95305 Add geolocation error feedback (re: #7376) 2020-02-27 14:10:31 -08:00
Quincy Morgan f42ad53379 Add L as the keyboard shortcut for geolocation (close #7395) 2020-02-27 10:23:09 -08:00
Quincy Morgan 5aab09845d Move the "zoom to this" button from the inspector to the map next to the zoom in/out buttons (re: #6601)
Use title case for the Zoom In and Zoom Out button labels
2020-02-26 19:59:09 -08:00
Quincy Morgan abf536aa9b Make commit changes its own collapsible section 2020-02-24 14:03:06 -08:00
SilentSpike 18287284c6 Remove translations link from Osmose UI
- Not useful to majority of users and clutters the UI
- Anyone interested in translation will already be looking at the iD
project and we can direct them from there
2020-02-16 12:47:38 +00:00
SilentSpike af0e37f7c5 Add "view on osmose" link to UI footer 2020-02-15 11:48:01 +00:00
Quincy Morgan 4ff634b90f Enable the circularize operation for multiple selected features (close #7326) 2020-02-05 09:57:33 -05:00
Quincy Morgan f2638c0c1e Merge pull request #7290 from openstreetmap/error-button-strings
Update QA button strings
2020-02-04 17:01:42 -05:00
SilentSpike 02f088e5a9 Update some QA translation strings 2020-02-04 21:03:34 +00:00
SilentSpike 377e99240f Add Osmose translations link to details footer
Improves structure of the details UI and introduces the use of flexboxes
for this. Does not break UI for other error services with shared classes.
2020-02-03 23:20:45 +00:00
SilentSpike 06ac02f89f Use Osmose dynamic subtitile string
Providing a `langs` param that's currently not implemented so these will
all be English until that is done.
2020-02-03 23:20:45 +00:00
SilentSpike 010ca30999 Show more Osmose strings in the UI
Also only add sections where appropriate
2020-02-03 23:20:44 +00:00
SilentSpike 5d93d3cace Prepare to use Osmose issue detail strings
- Remove translation description strings, will be using supplied
translations once the API is updated
- Change the way elements and details are presented since they can't be
easily integrated into the 3rd party description strings
2020-02-03 23:20:44 +00:00
SilentSpike 7d76950d55 Use Osmose translation strings for issue titles
This is just step one in the process while we wait for the API to supply
further strings and filtering to reduce the amount of string data
requested (since we don't need it all).

Strings are requested when the layer is first enabled and cached for the
current language (plus English as a backup).
2020-02-03 23:20:43 +00:00
SilentSpike 9fca611ec1 Add support for even more Osmose error types
- Conflicting tags
- Orthographic errors (excess whitespace and all capital names)
- Deprecated tagging
- Bad use of the "area" tag
2020-02-03 23:20:43 +00:00
SilentSpike a53f1c0f67 Add support for Osmose unnecessary tag error type 2020-02-03 23:20:42 +00:00
SilentSpike c13eb15691 Add support for more Osmose error types
- Unconnected level crossings
- Unconnected highway features/barries
- Unexpected punctuation/symbols in tag values
- Unbalanced parentheses/quotes in name values
- Invalid date formats
- Access tagging that permits all transport modes
- Elements with a "name" tag and no main tagging
- Relations missing a "type" value
2020-02-03 23:20:42 +00:00
SilentSpike cc3039033f Support more subtypes of osmose error type 8300 2020-02-03 23:20:41 +00:00
SilentSpike 896ed762e0 Fix silent failure for some Osmose error types
When I added special handling for mapillary errors the code was trying
to access translation strings nested under the error category (which
doesn't exist for all error types). This code is now moved into it's own
function so that variable hoisting doesn't run it for non-applicable
error types and prevent them from working.

- Also adds support for error type 3040 (bad tag value)
- Updated the Osmose sidebar UI title
2020-02-03 23:20:41 +00:00
SilentSpike d4723ec9e2 Read icons from qa_errors.json when building data
Also adds support for the following error types:
- Objects mapped as both node/area or way/area
- Power lines that lead to nowhere
- Extra nodes in power lines (which should only go from support to
support to endpoint)
- Power line supports with no power lines
2020-02-03 23:20:30 +00:00
SilentSpike 5afdfc527b Add support for more Osmose error types
- Missing parking access
- Malformed opening hours tagging
- Objects detected by Mapillary that aren't mapped
- Traffic sign information detected by Mapillary that isn't mapped

Mapillary errors add example code for special error type handling as
they don't need to request further details and can use piecewise
translation strings
2020-02-03 23:01:03 +00:00
SilentSpike b24b041335 Add Osmose issue detail fetching for UI
Must fetch details per-issue to get the associated OSM elements for
highlighting and use in the error description.

Also fixes URL for error closure.
2020-02-03 23:01:03 +00:00
SilentSpike 680fdb6b54 Allow Osmose errors to use category for UI strings
Some error types don't require unique strings and can share common
strings among the category. This makes that possible as well as adding
support for some other types of error for demonstrative purposes.
2020-02-03 23:01:02 +00:00
SilentSpike 09e7b23665 Add Osmose issues UI and filtering
Filters out errors not present in the data .json file to enable
selective support since Osmose has a wide variety of errors which may be
too advanced for iD.

Also added processing for the elements associated with an error for
forced visibility and highlighting.
2020-02-03 23:01:01 +00:00
SilentSpike e11d97b38c Add Osmose QA layer and service
Initial implementation - need to add UI for the errors and correctly set
up support for the desired error types provided by osmose.
2020-02-03 23:01:01 +00:00
Quincy Morgan 2783408fc3 Add tooltips to mixed values in semicombo, multicombo, and radio fields 2020-01-31 14:07:16 -05:00
SilentSpike ee520b756c Update QA button strings
See https://github.com/openstreetmap/iD/pull/7095#issuecomment-570066602
for motivation
2020-01-25 22:22:48 +00:00
Quincy Morgan fd2b97331c Add label to "change feature type" button in inspector and make it a collapsible section (close #6811) 2020-01-22 09:19:54 -05:00
Quincy Morgan 6bb2997306 Enable changing the preset of multiple selected features (re: #7276)
Fix issue where preset tag reference wouldn't load
Change "Change feature" tooltip to more accurate "Change feature type"
2020-01-21 15:19:51 -05:00
Quincy Morgan 11035127a3 Rename "Adjust imagery offset" section to "Imagery Offset" 2020-01-20 13:12:46 -05:00
Quincy Morgan 019e9a956c Remove unused strings 2020-01-20 12:15:13 -05:00
Quincy Morgan 667406c6e0 Remove "all" from the inspector section names 2020-01-20 11:51:00 -05:00
Quincy Morgan 48bda8ba67 Move selected feature list to a collapsible inspector section (close #7273) 2020-01-20 11:34:51 -05:00
Quincy Morgan bb593c5ccc Add "deselect" tooltip to X buttons in selected features list 2020-01-20 10:22:49 -05:00
Quincy Morgan 08cfdc3987 Remove unused string 2020-01-18 15:01:56 -05:00
Quincy Morgan 6f2938b35e Add "key=value" placeholder to text tag editor textarea 2020-01-18 13:36:36 -05:00
Quincy Morgan 874acf8ccc Make raw tag editor display option tooltips translatable 2020-01-18 13:35:31 -05:00
Quincy Morgan eda51f6835 Add initial multiselection raw tag editing in 2.x 2020-01-17 17:49:26 -05:00
Bryan Housel 96b2b42ba7 Make link to privacy notice in splash screen translatable
(closes #7171)
2019-12-25 16:54:14 -05:00
Quincy Morgan f6769238ed Revert references to the v3 UI in the Keyboard Shortcuts menu
Remove unused preset favoriting functionality
2019-12-20 12:05:04 -05:00
Bryan Housel ada4fb5814 Add privacy policy version check to context and splash screen
(closes #7040)

A few other minor things in this commit
- migrated several ui modal files to ES6 syntax
- switched the splash link from ideditor.org -> ideditor.blog
2019-12-19 00:11:40 -05:00
Bryan Housel 27f538b0cf Add Preferences Pane, Third Party Icon toggle, link to policy
(re: #7040)
2019-12-16 22:27:06 -05:00
Mikkel Kirkgaard Nielsen 9e912dfe96 Fix typo in orthogonalize.too_large.multiple 2019-12-16 10:09:49 -05:00
Quincy Morgan 9ce053520f Update shortcut documentation for possibility of zooming multiple selected features 2019-12-13 10:39:42 -05:00
Quincy Morgan 960d0d58a9 Allow squaring multiple features at once (close #6565) 2019-12-12 13:56:46 -05:00
Quincy Morgan a319bf75d6 Search all downloaded features instead of just visible ones on 2.x (re: #6516, re: 480140442677644ba3d758565b7d08672d037976) 2019-12-12 13:05:55 -05:00
Quincy Morgan 0b7d5b29c7 Add icon and tooltip for mapillary detected billboards 2019-12-11 15:58:09 -05:00
Quincy Morgan c1f7721197 Reload API status automatically when a response indicates a probable change in status (close #6650)
Make API status messages more informative (close #7021)
Add manual Retry button to "unable to connect" API status message (close #5864)
2019-12-05 17:17:57 -05:00