Commit Graph

52 Commits

Author SHA1 Message Date
Quincy Morgan d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Quincy Morgan eafd2cec3e Add a tooltip to the plus button in the "All relations" section (re: #3812) 2019-04-07 14:05:31 -07:00
Quincy Morgan a054db6472 Fix issue where hover-highlighting wouldn't disappear upon removing a relation from a member or a member from a relation (close #5612) 2019-04-04 17:56:01 -07:00
Bryan Housel 3d80e6505f Remove lodash chunk, groupBy
(re: #6087)
2019-03-27 16:18:41 -04:00
Quincy Morgan 56cf7542be Fix error when trying to add a feature to a relation (close #6095) 2019-03-27 15:03:33 -04:00
Bryan Housel 76e0d13729 Remove lodash every and filter
(re: #6087)
2019-03-23 01:22:56 -04:00
Bryan Housel 7a6c63fcc5 Remove lodash extend (re: #6087) 2019-03-23 00:38:39 -04:00
Bryan Housel a5ffec5665 utilHighlightEntities accept an array instead of calling it in a loop 2019-02-11 12:40:23 -05:00
Bryan Housel 49442afe0c In raw member editor, cancel combobox on blur if it hasn't been accepted 2019-01-28 15:41:50 -05:00
Bryan Housel 4583e2d4d7 Make sure all combo event listeners can handle accept/cancel w/o datum
(re: #5637, re: #5618)

This can happen if the user enters a value that is not matched to
one of the combo suggestions.

Also make sure to set `this` to the input field.  It might not be
already if the event was triggered from a keypress instead of a click.
2019-01-22 23:14:34 -05:00
Bryan Housel 087c38e8fd Avoid calling changeRole recursively
(closes #5731)
2019-01-18 18:20:47 -05:00
Bryan Housel 4e3def9ce8 Fix the width of the add-tag and add-relation buttons
(closes #5729)
2019-01-18 13:48:17 -05:00
Quincy Morgan 92e514f891 Make the preset browser appear upon adding a new relation.
Closes #5656
2019-01-14 16:25:43 -05:00
Bryan Housel 17615da0ea Listen to both change and blur for role switcher, compare old v new
(closes #5449)
2018-12-12 15:27:14 -05:00
Bryan Housel fc1f7e4d46 Trigger a change event when accepting combo option with return, tab
(closes #4900, closes #5449)

Some browsers need an explicit `change` event triggered on the input field
when a value has been changed by the combo and accepted by pressing return
or tab.  This was only an issue on combos that aren't part of uiFields,
since the uiFields are all setup to respond to `change`,`input`,`blur` etc.
2018-12-11 23:25:47 -05:00
Bryan Housel ec51ebb026 Fix flexbox of raw membership editor new row
(closes #5589)
2018-12-11 21:54:25 -05:00
Bryan Housel 39b3f1df68 Avoid creating comboboxes
(closes #5568)

Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
2018-12-11 16:07:00 -05:00
Bryan Housel 15a54cab17 Use context.container instead of passing it in 2018-12-10 14:14:27 -05:00
Bryan Housel e5dedeff8b Move lib/d3.combobox.js -> ui/combobox.js
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
2018-12-10 12:38:21 -05:00
Bryan Housel 50d204866b Flexbox the raw member, membership controls, finish tag editor 2018-11-29 22:31:58 -05:00
Bryan Housel 958d7fac4f wip changing all fields to use flexbox everywhere 2018-11-28 18:15:38 -05:00
Bryan Housel 986b663c9e Get rid of extra form-label-button-wrap div
Buttons can now be directly appended to the form-field-label flex container
2018-11-27 09:14:11 -05:00
Quincy Morgan b3e71c7522 Manual removal of the hover-highlight styling when clicking on a relation or member in the sidebar.
Closes #5521
2018-11-25 18:15:33 -05:00
Quincy Morgan 7bad67ff76 Flexbox preset field, member, and membership UI 2018-11-18 11:28:48 -05:00
Quincy Morgan 1161767932 Moves the entity highlighting function to util/util.js
Breaks out the code for getting a selector for entities and all their descendants into a generic function
Accounts for circular relations when recursively getting all relation member IDs
2018-10-26 18:39:01 -07:00
Quincy Morgan ddb6e1b119 Fixes comments related to hover-highlighting 2018-10-24 22:27:37 -07:00
Quincy Morgan 81feb1cd99 Adds hover-highlighting for relations in the raw membership list
Moves hover-highlighting behavior to its own function
Hover-highlighting now correctly highlights all members of the target relation
2018-10-24 22:17:28 -07:00
Bryan Housel 470835b38f Extract all graphics from iD sprite, reassemble with svg-sprite
All iD sprite graphics are now prefixed with `iD-`
Also includes support for sending the preset logos to taginfo
2018-06-08 16:06:46 -04:00
Minh Nguyễn 33817af2b7 Describe relation in tooltip in add membership list 2018-01-14 13:19:35 -08:00
Bryan Housel 34cdab9197 uiDisclosure now handles expanded state in localStorage
Now all the places that use a uiDisclosure won't have to do that
2017-11-27 17:13:57 -05:00
Bryan Housel 3d13620705 Convert lodah-es and d3 to named imports for ui 2017-09-26 11:22:43 -04:00
Bryan Housel ba97dde0f2 Limit members editor and memberships editor to 1000 entrires
(closes #3737)
2017-04-26 01:15:16 -04:00
Bryan Housel 5f44c9a00a Add combobox menus to id-container instead of document.body
(re: https://github.com/openstreetmap/iD/issues/3925#issuecomment-290718356)
2017-03-31 13:44:55 -04:00
Bryan Housel 2c11b693b8 Merge branch 'edit_menu' 2017-02-25 15:29:01 -05:00
Bryan Housel e756520bd8 suppressMenu(true) is now the default 2017-02-21 15:47:22 -05:00
Bryan Housel 2314acfec7 Add utilNoAuto to remove autocorrect/spellcheck features from inputs
(closes #3839)
2017-02-14 17:19:24 -05:00
Bryan Housel b9b7ef9748 Suppress menu when selecting entity from member/membership editor 2017-01-29 21:27:39 -05:00
Bryan Housel 9b7d79a3fe Use live bound object for presets object, change context.presets() getter 2016-11-14 15:44:02 -05:00
Bryan Housel b93e9f1a1a Merge enter selection into update selection for raw member list
(closes #3524)
2016-10-26 11:31:19 -04:00
Bryan Housel 053074d076 Export live binding for services in iD.services, fix init/reset
(closes #3324)

Previously we allowed devs to swap out services that they didn't need.
This became difficult now that ES6 exports are immutable bindings.
But we can wrap the immutable bindings themselves in a live object,
to get back the flexibility that we used to have.

This change also drops the `taginfo` accessor on Context, since devs who want
to swap out taginfo service with something else can now do so through the live
binding.  `iD.services.taginfo = myTaginfo()`
2016-10-14 10:38:09 -04:00
Bryan Housel 07fa5fcc34 Refactor Entity, Node, Relation, Tags, Way from core to osm 2016-10-11 22:41:24 -04:00
Bryan Housel 84ba112ff4 Rebind clickhandler in update selection (bc it uses wrap selection) 2016-10-07 15:28:16 -04:00
Bryan Housel 3102a4ae6a Rename all the things to include pseudonamespaces 2016-10-04 19:06:20 -04:00
Bryan Housel 6346a11880 Continuing to audit enter/update selections that need merge() 2016-09-18 00:51:43 -04:00
Tom MacWright ed135ce9ef Enable lib tests 2016-09-05 10:22:45 -04:00
Bryan Housel a86f34b4ef Pacify eslint, get build and tests running again 2016-08-26 01:15:07 -04:00
Tom MacWright cdb533fa84 Begin d3 v4 update 2016-08-21 15:19:27 -04:00
Minh Nguyễn 4ba0f43ee0 taginfo for relation roles
Enabled taginfo suggestions for roles on relation members and memberships.
2016-08-03 02:59:47 -07:00
Tom MacWright af776501d3 Require locale, second pass (#3259)
* Require locale, second pass

* Remove t global, remove t where it isn't needed
2016-07-21 16:20:13 -04:00
Tom MacWright 604d1e2719 import lodash (#3257) 2016-07-19 12:04:16 -04:00