Commit Graph

3430 Commits

Author SHA1 Message Date
Quincy Morgan b5856e2415 Rewrite behaviorDrawWay to only always use one and only one temporary edit
Fix issues involving undoing while drawing ways
Prevent self-intersection when adding nodes to ways on touch devices (close #7423)
2020-03-11 17:48:09 -07:00
Quincy Morgan b86486c69f Flash error when cannot finish drawing self-intersecting area 2020-03-10 15:36:13 -07:00
Quincy Morgan d82936ff24 Fix issue where labels could not be clicked to change or focus inputs 2020-03-10 13:39:22 -07:00
Quincy Morgan 70380880db Properly end the gesture if unexpectedly moving a non-down pointer 2020-03-10 12:17:25 -07:00
Quincy Morgan 284ff28961 Fix issue where map could pan when moving the mouse without a down pointer 2020-03-10 11:52:48 -07:00
Quincy Morgan 73d68b7a65 Fix issue where browsers could page back or forward when swiping horizontally over the map with a trackpad (close #5552) 2020-03-10 11:15:15 -07:00
Quincy Morgan 8dcb50579f Replace D3 import of trivial function 2020-03-10 10:48:27 -07:00
Quincy Morgan 5d8600ff36 Remove unused zoom/pan functionality 2020-03-10 10:34:25 -07:00
Quincy Morgan 207badb1a0 Read object visible state when parsing JSON API response (re: #7188) 2020-03-10 09:35:33 -07:00
Quincy Morgan 41e58dc32e Fix issue where vertices wouldn't always disappear on deselection (close #7419) 2020-03-09 15:58:24 -07:00
Quincy Morgan ece7eb0850 Add self-intersection error message when dragging vertices 2020-03-09 14:52:17 -07:00
Quincy Morgan a4e8c95009 Prevent double-tap-to-zoom browser on mobile Safari (close #6049)
Limit scope of gesture event cancelation to iD's container
2020-03-09 13:16:13 -07:00
Quincy Morgan d6b723b869 Remove unused zoom/pan handler property 2020-03-09 13:12:55 -07:00
Quincy Morgan 10f7ef2704 Add error feedback text when attempting to draw self-intersecting ways 2020-03-06 15:36:48 -08:00
Quincy Morgan 6ed66fb3ce Make drawing modes usable on touch devices 2020-03-06 15:17:11 -08:00
Quincy Morgan f8f69a777a Replace inconsistently-supported dblclick events with custom handler on platforms supporting pointer events
Fix issue where double-tap-to-zoom would not be properly disabled when drawing on touch devices (close #2128)
Support adding nodes to ways with double-tap with on touch devices (close #2677)
Support double-tap-to-zoom with styluses on touch devices
Don't accept double click/tap events if the taps are far apart
Don't re-enter modeSelect when clicking the selected feature again
2020-03-06 12:46:26 -08:00
Quincy Morgan 83a51a4192 Use pointer events for node dragging and drawing (re: #5505)
Enable dragging nodes with touches and styluses (close #7415)
2020-03-05 15:18:39 -08:00
Quincy Morgan 1147438d12 Use pointer events for map zooming and panning where supported (close #6598, re: #5505) 2020-03-05 10:38:30 -08:00
Quincy Morgan 83d2656bbc Fix responsiveness issue when selecting features on iPad
Implement an alternative solution for #6028 that doesn't rely on timeouts
2020-03-04 13:10:15 -08:00
Quincy Morgan c41e0b9937 Use pointer events for hovering and selecting data on supported platforms (re: #5505)
Fix issue where Apple Pencil stylus could not select map data (close #7396)
Fix issue where features could not be selected in a single tap on iPad (close #7380)
2020-03-04 12:18:43 -08:00
Quincy Morgan dcbb5ee03b Always show the unresolved issue count in the footer if any exist 2020-03-03 10:13:35 -08:00
Quincy Morgan 5e8d84ec33 Fix eslint warning 2020-03-02 15:58:30 -08:00
Quincy Morgan 52222df75f Switch to JSON endpoints of OSM API for fetching entities (re: #3765) 2020-03-02 15:54:46 -08:00
Quincy Morgan f4c39cc434 Don't require translations or uiFlash in rendererMap 2020-03-02 14:59:11 -08:00
Quincy Morgan c2d82eb9ce Don't require translations in coreValidator 2020-03-02 13:49:51 -08:00
Quincy Morgan 3ae009ea49 Rename d3_zoom object to disambiguate from zoom level variables (re: #5505) 2020-02-27 19:51:07 -08:00
Quincy Morgan 10fe7b6e92 Fix relation member drag-and-drop 2020-02-27 19:02:15 -08:00
Quincy Morgan c8e9bf3de7 Account for empty string tag values in utilTagDiff (re: #7363) 2020-02-27 15:18:31 -08:00
Quincy Morgan bed450f08b Don't enter modeBrowse if geolocation was unsuccessful
Only set geolocation timeout when fetching the location
Always fetch a new location when geolocating instead of only using the first one
2020-02-27 15:10:38 -08:00
Quincy Morgan 135fd95305 Add geolocation error feedback (re: #7376) 2020-02-27 14:10:31 -08:00
Quincy Morgan 4a6baccad3 Merge branch '2.x' into endpoints-fix 2020-02-27 12:59:00 -08:00
Quincy Morgan b40d47fda4 Show active state on geolocate button (close #7390) 2020-02-27 10:55:22 -08:00
Quincy Morgan a97b44f002 Remove unused uiQuickLinks 2020-02-27 10:33:36 -08:00
Quincy Morgan f42ad53379 Add L as the keyboard shortcut for geolocation (close #7395) 2020-02-27 10:23:09 -08:00
Quincy Morgan 5aab09845d Move the "zoom to this" button from the inspector to the map next to the zoom in/out buttons (re: #6601)
Use title case for the Zoom In and Zoom Out button labels
2020-02-26 19:59:09 -08:00
Quincy Morgan f0fe025c55 Ensure unshared issues aren't displayed during multiselection even if just one of the features has issues 2020-02-26 18:49:03 -08:00
Quincy Morgan bf42bce3be Update martinez-polygon-clipping to v0.6.2 (close #7370) 2020-02-26 15:18:16 -08:00
Quincy Morgan 2e238b8218 Fix JS error on clicking review request
Give different instances of the raw tag editor distinct classes and disclosure states
Correctly expand raw tags section by default when selecting a feature with a fallback preset
Fix raw tag editor tests
2020-02-26 14:51:32 -08:00
Quincy Morgan 31de74479e Fix JS error on clicking feature search result (close #7359) 2020-02-25 11:24:16 -08:00
Quincy Morgan 0b1ce05f35 Fix JS error when loading post-save community resources 2020-02-25 11:15:05 -08:00
Quincy Morgan c98c0d418d Ease relationship member zooming 2020-02-24 14:24:20 -08:00
Quincy Morgan c4ac1813fd Remove unused classes 2020-02-24 14:12:04 -08:00
Quincy Morgan abf536aa9b Make commit changes its own collapsible section 2020-02-24 14:03:06 -08:00
Quincy Morgan 5d6a9c278c Update validation rules section upon revalidation 2020-02-24 12:14:05 -08:00
Quincy Morgan 3e7ac18701 Use the lowest closeness threshold when flagging shared very close points (close #7379) 2020-02-24 11:53:16 -08:00
Bryan Housel d1dcff841a Add comment clarifying debug 2020-02-24 10:52:48 -05:00
Bryan Housel 4d0ef1bafc Export only the d3 functions we use in tests
(re: #4379)

This trims a bit more off the iD bundle size
2020-02-22 15:07:09 -05:00
Bryan Housel 919687d2cf Replace legacy names still used in tests, remove the legacy exports 2020-02-21 23:12:25 -05:00
Quincy Morgan 6782947f5b Make inspector sections inherit from uiSection (re: #7368) 2020-02-21 15:22:54 -08:00
Bryan Housel a43a7f8b50 Remove old _tkeys_ code
This was used for debugging translations, it would replace each string with
the translation key, so people could see what key was used where in the UI.
As far as I know, nobody was using this.
2020-02-21 17:05:55 -05:00