Commit Graph

15 Commits

Author SHA1 Message Date
John Firebaugh 20a75ac983 Performance improvement for iD.Difference
Avoid creating lots of unnecessary temporaries by short circuiting in a
common case.
2015-05-09 14:57:42 -07:00
John Firebaugh ffdeef398d Rewrite tree logic
The main problem with the existing logic was that it
did not update the extents of relations when previously incomplete members were loaded.

It was also overly stateful; the various queues and flags
are no longer required.

Fixes #1928.
Fixes #1540.
2013-10-28 16:57:18 -07:00
John Firebaugh fbf2118c76 Fix change summary calculation after restoring
We can't rely on identity equality here due to how
restoring works, and don't want to anyway -- the summary
should ignore net-no-op tag changes.

Fixes #1915.
2013-10-23 17:35:35 -07:00
John Firebaugh 2de500a90a Add a few more vertex cases to summary 2013-10-23 13:36:58 -07:00
John Firebaugh b8e88a7aaf Convert relevantChanges to a method on Difference 2013-10-23 13:36:58 -07:00
John Firebaugh 6060e886cb Reduce calls to iD.svg.TagClasses
For fills and shadows, style changes can happen only when
a new version of the feature is produced. If we include a
version number in the key, we need only call TagClasses on
the enter selection.

We cannot apply the same optimization for strokes, since
stroke style can depend on the tags of parent relations
as well.
2013-05-13 09:37:48 -07:00
John Firebaugh c50c3121d8 Make Graph#entity strict
Use Graph#hasEntity for the previous behavior.
2013-04-24 09:27:37 -07:00
Ansis Brammanis 9983c0be43 make difference calculation stricter
Changed entities with the exact same properties no longer get counted as
modified.

issue #1287
2013-04-18 13:58:22 -04:00
John Firebaugh f4b19133e7 Lint 2013-02-27 20:41:37 -08:00
Ansis Brammanis 529b570c89 Merge remote-tracking branch 'systemed/master' into tree-intersects 2013-02-13 13:31:11 -05:00
Ansis Brammanis 9bd46af6ad Tree intersect now works with changes 2013-02-12 17:22:25 -05:00
Tom MacWright 915edc4569 Merge branch 'master' of github.com:systemed/iD 2013-02-12 16:35:53 -05:00
Tom MacWright 61d7ec45b5 Banish function ( style 2013-02-12 16:35:47 -05:00
John Firebaugh 072f85e2b1 Redraw nodes that move off the screen (fixes #735) 2013-02-12 13:34:16 -08:00
John Firebaugh 843baa11c0 graph -> core
This matches how it's described in ARCHITECTURE.md.
2013-02-09 15:18:54 -08:00