Commit Graph

3511 Commits

Author SHA1 Message Date
Bryan Housel e3139e250e improvements to iD.actions.MergeRemoteChanges
* if remote entity is deleted, log to conflicts() array
* if remote tag was deleted, delete from tags (not set undefined)
* update tests..
2015-03-02 13:07:24 -05:00
Bryan Housel 78ca4b11f4 Better support for delete/restore 2015-02-28 23:03:44 -05:00
Bryan Housel 98665fef91 Don't allow zoomTo on an entity with degenrate extent
(because sending the map to NaN/NaN/NaN is not cool)
2015-02-28 23:00:00 -05:00
Bryan Housel 2aae57d361 Save originals of parent entities to localstorage
This prevents strange things from happening when a way is moved,
(affecting only the childnodes but not the way).
2015-02-28 22:52:21 -05:00
Bryan Housel 2b3dfef5e7 Fix versions of childnodes when merging force_local 2015-02-27 16:56:00 -05:00
Bryan Housel 1cfc6ad69a Check childNode versions too 2015-02-27 16:35:58 -05:00
Bryan Housel 80f5f65f63 More bugfixes and style updates:
* working Previous/Next buttons
* remove behaviors from save mode
  (users should not be moving nodes around or selecting at this point)
* clear hover before hovering next object
* enable save button and finished message after reviewing last conflict
* store users choice in __data__.chosen..
* default choices to `keep remote version`
* better message for delete conflicts
* fix undelete action to check localGraph (which will have the entity)
  instead of context.graph() (which may not)
2015-02-27 15:45:43 -05:00
Bryan Housel 0ed12da6fa WIP: style, replace expand/contract list with prev/next buttons 2015-02-26 22:39:22 -05:00
Bryan Housel 29e1554d5f accessor to expose _features internals 2015-02-26 16:08:39 -05:00
Bryan Housel e79ff79092 Cleaner code for indeterminate feature checkboxes
(fixes #2532)
2015-02-26 14:33:03 -05:00
Bryan Housel a3617b02cc WIP: fix style, fix choice selection 2015-02-26 00:43:14 -05:00
Bryan Housel 15bc08795d Don't save history to localstorage in save mode
(to avoid saving remote merges / conflict resolutions)
2015-02-25 23:35:06 -05:00
Bryan Housel 57e5113b1e Use radio buttons for mine/theirs choice 2015-02-24 23:32:02 -05:00
Bryan Housel 6ecca72eac Unsuppress menu when reselecting
(fixes #2533)
2015-02-24 14:16:51 -05:00
Bryan Housel 2c860785f6 Fix areaKeys whitelist/blacklist and blacklist junction=roundabout
(closes #2484)
2015-02-24 12:25:51 -05:00
Bryan Housel 72e5c3dce1 remove/restore of child vertices when switching mine/theirs 2015-02-21 00:02:46 -05:00
Bryan Housel 0730e0432b keep localGraph - UI can now flip between mine/theirs 2015-02-20 17:01:19 -05:00
Bryan Housel 861bd14903 map#trimmedExtentZoom
Like map#extentZoom, but uses trimmed viewport instead of full viewport
to avoid putting the extent under UI buttons and border elements.

This is because in conflict resolution the user will be extentZooming to see
their changes and it was annoying to have the change appear under the UI.

Also using this in zoomToGPXLayer.
2015-02-20 14:59:40 -05:00
Bryan Housel ad8c381301 WIP: handle conflicting local tag deletion
re: https://github.com/openstreetmap/iD/pull/2489#discussion-diff-22490581
2015-02-20 12:43:47 -05:00
Bryan Housel 0a1dd4b338 WIP: simplify 2015-02-20 11:21:47 -05:00
Bryan Housel 38b50a347e WIP: Fix tests, simplify mergeChildNodes 2015-02-17 22:10:47 -05:00
Bryan Housel ebe5484e22 WIP: MergeRemoteChanges merges way childnodes 2015-02-17 00:51:49 -05:00
Bryan Housel cdd0ca1acf WIP: Use history.perform/replace/pop instead of context.perform
This means
* no more weird saves to localStoage of partially merged graphs
* pop cleanly cancels back to history state before merges happen
  (removed the annotated undo states)
2015-02-17 00:47:12 -05:00
Bryan Housel 6638f6806e WIP: changes to "download changeset"
* use original changeset before conflict resolutions
* don't cancel the conflict resolution ui
2015-02-16 15:12:42 -05:00
Bryan Housel 663ed92508 WIP: code cleanup, use difference.summary()
filling the toCheck list from summary() means that moved vertices are
treated as a change to the parent way, instead of changes to each node

TODO: need to conflict check each node, but at least now they are
fetched with a single API call to fetch the way, and can be reported
as a single conflict in the ui..
2015-02-16 14:53:51 -05:00
Bryan Housel d755145ae6 WIP: usernames in messages, show # of total 2015-02-14 11:20:19 -05:00
John Firebaugh 9aab74c187 Test; simplify 2015-02-12 10:24:40 -08:00
Richard Fairhurst c9162ea65e Extend protection to multipolygon outer ways 2015-02-12 10:21:24 -08:00
Richard Fairhurst 0953475f04 Don't delete ways from route/boundary relations 2015-02-12 10:21:23 -08:00
Bryan Housel 5561ebdb14 version 2015-02-12 06:30:23 -05:00
samanpwbb 34642526ff jshint 2015-02-10 14:41:06 -05:00
samanpwbb a4a5812816 style cleanup 2015-02-10 13:24:10 -05:00
samanpwbb 744346398a style cleanup 2015-02-10 11:08:01 -05:00
Bryan Housel 5bff37f11b 1.6.3 2015-02-09 22:24:20 -05:00
samanpwbb e94d089526 fix modals 2015-02-09 18:11:38 -05:00
samanpwbb 094c46dcfb fix order issues 2015-02-09 17:49:58 -05:00
samanpwbb 7f9d1437d2 zoom to conflict on active 2015-02-09 17:28:22 -05:00
samanpwbb cef46853ea rework list interactions 2015-02-09 15:20:29 -05:00
samanpwbb e49ebe2784 rework save UI 2015-02-09 14:28:55 -05:00
samanpwbb c1d393302a fix close button 2015-02-06 19:35:53 -05:00
samanpwbb d141827c3e Merge branch 'master' into conflict-resolution-ui 2015-02-06 19:08:50 -05:00
samanpwbb 78e4271071 finish basic layout/style pass 2015-02-06 19:07:57 -05:00
Bryan Housel 6d82ae4146 add iD.geo.Extent#contains 2015-02-06 13:56:51 -05:00
Bryan Housel 54594cd296 unzorro vertices that have moved past an endpoint
(while this works, it causes jerky confusing movement when moving the way,
so probably taking a different approach involving point scaling)
2015-02-06 10:31:35 -05:00
peterneubauer 2c732d5ed7 removing log 2015-02-06 10:39:42 +02:00
peterneubauer f3e9b0f434 upgrading to Mapillary API v2 cals 2015-02-06 10:37:30 +02:00
Bryan Housel 66ab2fe0db Better caching, code cleanups.. 2015-02-02 23:22:27 -05:00
Bryan Housel fb90cd90b0 Use graph#overwrite for move mode
also move cache stuff from here down into iD.actions.Move
2015-02-02 22:02:33 -05:00
Bryan Housel 147e369c3b Add graph#overwrite (same as pop followed by perform)
to remove some of the overhead in creating difference and dispatching
change event multiple times..
2015-02-02 22:01:49 -05:00
Bryan Housel f1f6656269 Perform moves idempotently
* instead of passing small deltas to the move action and accumulating
errors, always pass the absolute delta since entering move mode
* also fix cache to handle circular/self-referencing relations
2015-02-02 16:29:08 -05:00