Commit Graph

78 Commits

Author SHA1 Message Date
John Firebaugh
da9602795c Don't allow deleting incomplete relations
This will fail with an "entity not found" error.
2013-05-16 16:43:41 -07:00
John Firebaugh
0ae54abdcc Extract iD.actions.DiscardTags 2013-05-13 09:26:41 -07:00
John Firebaugh
4ffaba1def Prefer to keep existing ways when joining (fixes #1424) 2013-05-07 12:34:04 -07:00
John Firebaugh
c50c3121d8 Make Graph#entity strict
Use Graph#hasEntity for the previous behavior.
2013-04-24 09:27:37 -07:00
John Firebaugh
fb16dc8af6 Custom d3 3.1 build (fixes #1232) 2013-04-02 15:00:32 -07:00
John Firebaugh
af7d003b88 Don't overload constructor parameters 2013-04-01 15:58:10 -07:00
John Firebaugh
79404c47d9 Multiselect control over disconnection (#1220) 2013-04-01 15:46:13 -07:00
John Firebaugh
93dd4a2658 Multiselect vertex/way to control splitting 2013-03-29 15:32:19 -07:00
John Firebaugh
2bd6178f07 Split on self-intersections 2013-03-29 15:32:19 -07:00
John Firebaugh
bbd4cb80b6 Split ways at intersections (fixes #750) 2013-03-29 15:32:19 -07:00
John Firebaugh
b1daf85cfd Tooltips for disabled operations (fixes #573) 2013-03-29 12:29:07 -07:00
Ansis Brammanis
3384598c60 Add ability to disconnect self-intersecting ways
Fixes #1155
2013-03-26 17:46:32 -04:00
Ian B
04060f0abb Add orthogonalize test spec 2013-03-23 22:10:23 +01:00
John Firebaugh
80b6e4325f Circularize preserves direction (fixes #1082) 2013-03-19 16:42:30 -07:00
John Firebaugh
e40090b758 Fix circularize with > 12 vertices (fixes #1054) 2013-03-18 17:48:15 -07:00
John Firebaugh
4fa88acc85 Fix connecting adjacent vertices
Can't unconditionally delete the node; it may be a member
of other ways.

I didn't preserve the behavior of dragging a midpoint to
an adjacent node being a no-op. In general we don't try to
eliminate compound operations whose net result is a no-op;
I don't think it's important to do so for this special case.

The degenerate case of connecting the endpoints of a two-vertex
line now results in a point. This is what naturally resulted
from the code, and seems ok.

Fixes #983.
2013-03-12 16:26:40 -07:00
John Firebaugh
68cc99c412 Disable Move operation on incomplete relations (fixes #972) 2013-03-11 16:43:06 -07:00
Tom MacWright
5838f05116 Merge tags without a space, fixes #941 2013-03-08 10:51:44 -05:00
John Firebaugh
cb0e02d56f Support merging point + line 2013-03-06 17:37:17 -08:00
John Firebaugh
b7894ceaf0 Calculate participating ways in AddMidpoint
Due to differenced redraw, midpoint.ways was getting stale,
so sometimes dragging a midpoint didn't add the new node to
all ways. Better to calculate participating ways when needed.
This also simplifies the code for adding a midpoint via double
click. It does make filtering midpoints on redraw a bit more
expensive, but a cursory profile didn't show it being a problem.

Fixes #763.
2013-02-27 20:41:38 -08:00
John Firebaugh
78f6a00029 Fix moving multiple entities which share nodes
While here, implement moving multipolygons too.
2013-02-27 17:12:39 -08:00
John Firebaugh
7a1800fd68 Delete orphaned relation members 2013-02-27 16:32:52 -08:00
John Firebaugh
b751c1ece9 Simplify, fix spec 2013-02-27 16:32:26 -08:00
Tom MacWright
61d7ec45b5 Banish function ( style 2013-02-12 16:35:47 -05:00
John Firebaugh
f1079a644a Fix relation role in Split (#694) 2013-02-08 20:44:14 -08:00
John Firebaugh
e05531ad6c Fix circularize boundary cases (fixes #494)
There are still more boundary cases even farther out. But this is
probably sufficient for the real world.
2013-02-08 12:08:48 -08:00
Tom MacWright
3626534a70 Remove deprecate tags test 2013-02-07 17:10:31 -05:00
John Firebaugh
e1bc78871b Handle entities that are already deleted (fixes #672) 2013-02-07 13:46:25 -08:00
John Firebaugh
0af51a0ef6 Improvements to Split
* Split a closed way at selected and antipode point (fixes #651)
* Split an area into a multipolygon (fixes #572)
2013-02-06 16:00:19 -08:00
John Firebaugh
f6e726bcd6 Join should run Reverse where necessary (fixes #652) 2013-02-06 14:31:11 -08:00
John Firebaugh
bd8c9d6a00 Support merging points into an area (#435) 2013-02-06 13:42:34 -08:00
John Firebaugh
d7639acb22 Set up iD.actions.Join to be more flexible 2013-02-06 13:42:34 -08:00
John Firebaugh
b62f106be8 Extract Relation#replaceMember 2013-02-06 13:42:34 -08:00
John Firebaugh
c9fb1444db Connect via drag and drop
Fixes #598.
2013-02-04 16:48:54 -08:00
John Firebaugh
73098d259e Specify type for relation member 2013-02-04 16:48:40 -08:00
Tom MacWright
3e71dd56cd Wipe out some tags entirely, refs #585 2013-02-04 17:20:06 -05:00
Tom MacWright
3449a680a7 Add tag deprecation action and data, not yet integrated. 2013-02-04 16:02:34 -05:00
John Firebaugh
a8410be6eb iD.actions.Join 2013-02-01 17:31:32 -05:00
John Firebaugh
9120f33aa7 ReverseWay -> Reverse 2013-02-01 17:31:32 -05:00
John Firebaugh
c86792a77b SplitWay -> Split 2013-02-01 17:31:32 -05:00
John Firebaugh
e1d5a0cb03 Unjoin -> Disconnect 2013-02-01 17:31:32 -05:00
John Firebaugh
58fcf746a2 Delete multiple 2013-02-01 15:08:41 -05:00
John Firebaugh
7ba31f05d2 Support deleting relations 2013-02-01 14:48:11 -05:00
John Firebaugh
3605895dfa ChangeEntityTags -> ChangeTags 2013-01-31 12:41:29 -05:00
John Firebaugh
df72ef254f ChangeEntityTags -> ChangeTags 2013-01-31 12:07:54 -05:00
John Firebaugh
6f7079d11c AddWay/AddNode -> AddEntity 2013-01-31 12:06:21 -05:00
John Firebaugh
6ae360a533 These tests now pass 2013-01-31 08:28:10 -05:00
John Firebaugh
e381b6ab26 Extract AddMidpoint action 2013-01-30 15:47:33 -05:00
John Firebaugh
98073b0d26 Add pending tests for #508
Update DeleteWay tests to use Graph#update. Eventually we
should do this for all action tests.
2013-01-25 16:35:50 -05:00
John Firebaugh
b6d8ddc2f8 Remove unused branch and obsolete test 2013-01-24 11:21:12 -05:00