Quincy Morgan
b302d853ac
Fix issue where the favorite preset button could be stale
...
Use first in, first out favoriting order
2019-02-27 13:13:15 -05:00
Quincy Morgan
a3424aa4b1
Merge branch 'master' into squash-favorite-preset
2019-02-26 14:25:34 -05:00
Quincy Morgan
0fa7e757b1
v2.14.3
2019-02-26 13:45:53 -05:00
Quincy Morgan
87e48bc543
Run missing role validation before missing tag
2019-02-25 18:01:34 -05:00
Quincy Morgan
b8ac9a7de3
Add toggle-able list of rules to the Issues pane ( close #5979 )
...
Toggling a rule off prevents the validation from running
2019-02-25 15:31:05 -05:00
Quincy Morgan
70e88ee9af
v2.14.2
2019-02-21 17:01:00 -05:00
Quincy Morgan
7936266a7a
Improve validation performance by avoiding uniqueWith lodash function
...
Replace map lodash function with JavaScript array map in validator.js
2019-02-21 12:13:27 -05:00
Quincy Morgan
51972ea78f
Cache issues in crossing ways validation to avoid checking the same pairs twice
2019-02-21 11:49:31 -05:00
Quincy Morgan
aa992ed981
Improve validation performance by cacheing the issue id
2019-02-21 10:47:57 -05:00
Quincy Morgan
1bde3ba63f
v2.14.1
2019-02-20 18:23:47 -05:00
Quincy Morgan
1f1e88314d
v2.14.0
2019-02-20 16:19:36 -05:00
Brian Hatchl
d8531c88bb
fix lint complaints
2019-02-20 15:44:16 -05:00
Brian Hatchl
1faa6ad839
Favorite preset
2019-02-20 15:23:58 -05:00
Quincy Morgan
1821c3e955
Update fixes UI for icons, link styling, and non-actionable fixes
...
Fix several bugs
2019-02-14 15:56:04 -05:00
Bryan Housel
c4fe42653a
s/coordinates/loc and replace legacy names in tests
...
In iD codebase `loc` is usually a single coordinate pair
and `coordinates` is usually an array of pairs
2019-02-12 21:18:25 -05:00
Bryan Housel
448fe498bd
Only recenter view if necessary, select after delay, fix maprules type
2019-02-12 17:25:54 -05:00
Bryan Housel
14896b0ce5
Documentation, and move validation type up to top of each file
2019-02-12 16:07:08 -05:00
Bryan Housel
9ebc9a22e9
perf: use Object instead of Array for lookup, cache on osmEntity.key
2019-02-12 14:23:50 -05:00
Bryan Housel
4e6ade08b1
Comment out cache in getIssuesForEntityWithID
...
It seems like entity editor draws before the validator runs so the
rendered list is often one history change behind.
2019-02-12 00:22:24 -05:00
Bryan Housel
c083d1d0af
More nitpicky code formatting issues
...
- no multiline var declarations
- avoid lodash unless necessary
- linefeeds for readability
2019-02-11 14:51:21 -05:00
Quincy Morgan
47ec58e5fc
Don't zoom to the end vertex when continuing a disconnected highway if it is already visible
...
Add separate fixes for continuing a disconnected highway from the start and end vertices
Highlight the vertex that will be continued
2019-02-11 11:29:34 -05:00
Quincy Morgan
d70c02ee6d
Replace use of Set object in validator
2019-02-08 09:33:17 -05:00
Quincy Morgan
1564f73de6
Merge branch 'master' into validation
2019-02-07 20:51:21 -05:00
Bryan Housel
d2735ab40c
Fix misspelling
2019-02-07 13:41:06 -05:00
Quincy Morgan
d3946894e8
Standardize deprecated_tag and missing_tag rule type ids
...
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan
bfb5285dc9
Fix tests and lint warnings
2019-02-04 13:34:27 -05:00
Quincy Morgan
2677a88df4
Zoom to ways and relations upon clicking on their issues in the issues pane
2019-02-04 10:27:35 -05:00
Quincy Morgan
9785021f44
Rename simpleMultipolygon functions to oldMultipolygon
...
Return old_multipolygon validation issues for the relations as well as the outer ways
Remove console logging
Don't run missing_tag validation for relations with old_multipolygon issues
2019-02-01 15:19:28 -05:00
Quincy Morgan
973697b8ba
Run all validators in the validations folder if not manually run
...
Remove ValidationIssueType and ValidationIssueSeverity objects
2019-02-01 13:38:17 -05:00
Quincy Morgan
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
09bc2a6e6c
Merge branch 'master' into validation
2019-01-30 16:44:14 -05:00
Quincy Morgan
77c4d41855
Restore many deletions warning with tooltip and nicer message
...
Add tooltips back to issues pane list
Fix crash when restoring without having loaded the edited area
2019-01-30 15:48:06 -05:00
Bryan Housel
7138acc652
Properly export areaKeys, fix preset and maprules tests
2019-01-30 15:29:37 -05:00
Quincy Morgan
5b93ee0f7a
Run validation upon data restore after page reload
2019-01-30 13:40:02 -05:00
Quincy Morgan
226c4f88e1
Re-run validation automatically upon merging fetched remote data into the history
2019-01-29 11:10:12 -05:00
Quincy Morgan
0866110d77
Merge branch 'master' into validation
2019-01-29 09:16:06 -05:00
Quincy Morgan
02ccd7cfd6
v2.13.1
2019-01-28 17:38:05 -05:00
Quincy Morgan
ffe4aa09f4
Pass entity array into validators instead of changes object
2019-01-24 15:26:19 -05:00
Quincy Morgan
e69f2a0389
Merge branch 'master' into validation
2019-01-23 13:15:33 -05:00
Quincy Morgan
24b6e9aeec
v2.13.0
2019-01-23 11:33:23 -05:00
Bryan Housel
a873c0f2ca
Remove unused, add maprules documentation
2019-01-23 11:08:19 -05:00
Quincy Morgan
0499a76443
Fixed an entity not found error when restoring new ways that reference unloaded nodes ( closed #4108 , closed #5194 )
2019-01-22 12:56:37 -05:00
Quincy Morgan
536ee2e786
Validations now update instantly upon an annotated graph change
2019-01-14 15:19:00 -05:00
Quincy Morgan
11b2102761
Merge branch 'master' into validation
...
# Conflicts:
# data/core.yaml
# dist/locales/en.json
# modules/ui/commit_warnings.js
# modules/ui/entity_editor.js
# modules/util/index.js
# modules/util/util.js
# modules/validations/index.js
# modules/validations/many_deletions.js
# modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Bryan Housel
9c190e83e9
Add quickLinks to preset editor, zoom to selected feature
2019-01-09 21:56:08 -05:00
Bryan Housel
528cbb29e1
Store the transform and selectedIDs with the rest of the history
...
(closes #5664 )
2019-01-08 00:36:41 -05:00
Andrew Wong
5971bbebb7
Added more validation tests
2018-12-20 15:39:26 -05:00
Xiaoming Gao
a4e1012c91
add crossing_way validation
...
Tests are also added and passed.
One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
2018-12-19 19:23:35 -05:00
Andrew Wong
6e749c70ef
listening to user generated history changes for validation
2018-12-19 17:28:34 -05:00
Thomas Hervey
31f35b0389
added basics to sidebar
2018-12-19 13:35:26 -05:00
