Commit Graph

370 Commits

Author SHA1 Message Date
Bryan Housel 9d6ade23b5 v2.17.2 changelog 2020-02-14 11:07:12 -05:00
Bryan Housel 1155498766 Restore the addablePresetID feature 2020-02-07 12:06:59 -05:00
Bryan Housel a9a1f945f8 Move the qa_data external
- this means that QAItem now asks the service for the icon rather than knowing it directly
2020-02-07 10:06:47 -05:00
Bryan Housel 4c5e7db2dd Move the iD.data export from data/index.js to coreData
coreData now owns all the data, and data/index.js should eventually go away
(re: #4994)
2020-02-07 09:27:23 -05:00
Bryan Housel fe00a40e9a Move the keepRight data extrnal 2020-02-07 09:16:34 -05:00
SilentSpike 51efd5b714 Update and standardise QA implementations
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
Bryan Housel de0ac9d451 Upgrade to name-suggestion-index v4.0.0
(closes #7336)

- json data files are distributed both regular and minified
- json data is no longer exported by index.mjs
2020-02-06 11:28:02 -05:00
Bryan Housel 13ead25654 Merge branch 'external_presets' into 2.x
(re: #4994)
2020-02-05 21:32:51 -05:00
Quincy Morgan 1720f7cb93 Organize some code in coreUploader (re: #7333)
Fix lint error
2020-02-05 17:53:28 -05:00
Quincy Morgan 0e14241fcf Move some upload code from modeSave to new coreUploader object (re: #7247) 2020-02-05 15:28:23 -05:00
Bryan Housel c4f0700309 Fix data urls 2020-02-05 13:27:25 -05:00
Bryan Housel 0fe766d9a4 WIP on external presets
- preset data is no longer bundled into iD.js
- some code pathways commented out re: external presets
- many changes so that tests can run without presets at start, or async
- still need to make sure fallbacks are always there (point, line, area, etc)
2020-02-05 09:38:26 -05:00
Quincy Morgan 9d31d444d0 Show only issues shared by all features on multiselection 2020-02-04 12:09:54 -05:00
Bryan Housel eb0c297bbd Rewrite the issue gathering code to not use for..of 2020-02-03 17:25:34 -05:00
Quincy Morgan b4bc5305a1 Enable the issues section for multiple selected features (close #7324) 2020-02-03 12:17:14 -05:00
Bryan Housel 06eac7c9d0 Don't bundle the nsi brands anymore, fetch from CDN at runtime
(re: #4994)
2020-02-01 17:40:56 -05:00
Bryan Housel 743dc0a83a Don't bundle the nsi brands anymore, fetch from CDN at runtime
(re: #4994)
2020-01-31 22:07:21 -05:00
Bryan Housel 33a2dafc10 Fetch wmf-sitematrix from CDN.. No need to depend on it anymore. 2020-01-30 09:48:37 -05:00
Bryan Housel e19bcb77d5 Require init() call before coreContext starts doing things
(closes #7304)
2020-01-29 19:27:12 -05:00
Bryan Housel fb4d658860 Don't bundle the community index anymore, fetch from CDN instead
Start fetching and preparing it just before the changeset gets sent
2020-01-29 15:24:26 -05:00
Bryan Housel 9154a6a554 context.asset should pass-through absolute URLs 2020-01-29 15:22:06 -05:00
Bryan Housel 89724cfb1b Remove support for debug rendering of the community index
We have http://openstreetmap.community now for this, and it eliminates
another place in the code where that data would have been needed.
This commit also ES6ifies svgDebug.
2020-01-29 13:35:25 -05:00
Bryan Housel c481f90e7d Stop bundling wmf-sitematrix, move it extern
This also includes a bunch of tweaks to make the tests work
in both PhantomJS and modern browsers like Chrome.

Basically - introduce some more async into the test code so that
the coreData.get promise is guaranteed to settle.  Because in
PhantomJS the promise is polyfilled, and Chrome it's native, they
work slightly differently.
2020-01-29 12:30:11 -05:00
Bryan Housel 567eeac587 Make several data external instead of bundled:
Also dist/data/* contains minified files now

These are now external and will fetch as needed:
-export { dataAddressFormats } from './address-formats.json';
-export { dataDeprecated } from './deprecated.json';
-export { dataDiscarded } from './discarded.json';
-export { dataLanguages } from './languages.json';
-export { dataPhoneFormats } from './phone-formats.json';
-export { dataShortcuts } from './shortcuts.json';
-export { dataTerritoryLanguages } from './territory-languages.json';
2020-01-28 22:21:31 -05:00
Bryan Housel 6d81a00daf Let caller modify the coreData fileMap, and add tests 2020-01-28 10:27:45 -05:00
Quincy Morgan 89ce98f510 Don't require services/osm in order to get max OSM character lengths 2020-01-28 09:28:23 -05:00
Bryan Housel b949cc6bb6 Sometimes the issue cache has junk in it.
I got this to happen after some issues had been detected on the live map,
then starting the intro walkthrough (which replaces the graph).

No time now to dig into the root cause, but this might make the problem go
away so the tutorial doesn't get too weird.
2020-01-27 17:38:29 -05:00
Bryan Housel 31e007fc83 Create a data loader and move the intro graph into dist/data
(re: #3403)
2020-01-27 17:15:00 -05:00
Bryan Housel 883f35a99b indent 2020-01-27 12:28:55 -05:00
Bryan Housel 6b7bb75315 Prefix the stateful/internal variables with _ 2020-01-27 12:09:53 -05:00
Bryan Housel 08c850a98f ES6ify context 2020-01-24 17:16:32 -05:00
Quincy Morgan ba40154a06 v2.17.1 2020-01-16 18:38:21 -05:00
Quincy Morgan f270c475ea Add timestamp to saved histories (re: b4ef0862978ae79a5cb741ac49370ed678857b1f) 2020-01-15 13:11:08 -05:00
Quincy Morgan ab278a84df Add method to get stored JSON history from outside coreHistory object (re: b4ef0862978ae79a5cb741ac49370ed678857b1f) 2020-01-15 13:08:32 -05:00
Quincy Morgan 186aec68ac Improve endpoint for checking if restorable changes exist (re: b4ef0862978ae79a5cb741ac49370ed678857b1f) 2020-01-15 12:57:53 -05:00
Quincy Morgan 9345ec7a82 Update reload unsquare issues function name 2020-01-07 11:41:04 -05:00
Quincy Morgan 7b7a42cf76 v2.17.0 2019-12-23 14:04:11 -05:00
Quincy Morgan 6f7f2ab77f Revert "vA.B.C"
This reverts commit 1e9021265c.
2019-12-23 14:03:43 -05:00
Quincy Morgan 1e9021265c vA.B.C 2019-12-23 14:02:55 -05:00
Bryan Housel ada4fb5814 Add privacy policy version check to context and splash screen
(closes #7040)

A few other minor things in this commit
- migrated several ui modal files to ES6 syntax
- switched the splash link from ideditor.org -> ideditor.blog
2019-12-19 00:11:40 -05:00
Quincy Morgan 9d936b4aea Rename rendererMap.editable function to more precise rendererMap.editableDataEnabled
Make coreContext.editable function also account for whether user is in modeSave
2019-12-12 16:06:28 -05:00
Quincy Morgan 96c8bcb152 Add tooltip to delete feature fix explaining if it's disabled (close #6588) 2019-11-13 14:52:57 -05:00
Quincy Morgan 24c72b64d1 Load issue fixes dynamically instead of cacheing them (close #7037) 2019-11-13 14:35:01 -05:00
Quincy Morgan 271a4cbac7 Update rbush to 3.0.1 (close #6359) 2019-11-08 18:17:17 +01:00
Bryan Housel dbe016a399 v2.16.0 2019-10-23 23:34:00 -04:00
Quincy Morgan 56f31adcf1 Always sort the entity issues list deterministically
Don't skip validations just because a different validation produced issues
2019-10-12 17:01:03 +02:00
Quincy Morgan 7251a2ab90 Make "edited issues" mean "issues the user created" instead of "issues for features edited by the user"
Only include issues created by the user in the "warnings" changeset tags
Include counts of issues resolved by the user in the changeset tags (close #6459)
Don't include "fixme" issue counts in "warnings" changeset tags since they're not created by the user (close #6658)
Don't cache crossing ways issues at the rule level
2019-10-04 16:50:44 +02:00
Quincy Morgan 6a515576f1 Add an "Extract this point" quick fix for points-as-vertices validation warnings (re: #6319) 2019-10-01 18:21:03 +02:00
Quincy Morgan 525916da74 Recategorize tags_suggests_area validation rule into mismatched_geometry rule
Warn about points tagged as vertices and vertices tagged as points (close #6319)
2019-09-26 10:56:30 +02:00
Bryan Housel 590d557325 v2.15.5 2019-08-26 13:59:15 -04:00