Commit Graph

14 Commits

Author SHA1 Message Date
Quincy Morgan 3a933de876 Don't add tags to connection node when connecting crossing line/area 2020-04-13 18:57:26 -07:00
Quincy Morgan 85c88a8846 Add additional tests for crossing_ways validation 2020-04-13 18:37:13 -07:00
Quincy Morgan 513b344012 Fix code tests 2020-04-03 13:33:54 -07:00
Bryan Housel e19bcb77d5 Require init() call before coreContext starts doing things
(closes #7304)
2020-01-29 19:27:12 -05:00
Quincy Morgan d3d2cbb4a2 Update code tests for building layer crossings 2019-10-03 20:10:20 +02:00
Quincy Morgan 1ed73b6531 Convert validation rules to validate against a specific graph, not always the current graph (re: #6459) 2019-06-06 16:27:31 -04:00
Quincy Morgan 375779882d Add ability to ignore warnings
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
2019-04-29 17:52:32 -07:00
Quincy Morgan 12a44421c3 Account for indoor features in crossing ways validation
Recommend using an appropriate structure/layer/level for crossing ways validation
Flag crossing highways on different levels but without bridges or tunnels
2019-02-19 11:43:05 -05:00
Bryan Housel c4fe42653a s/coordinates/loc and replace legacy names in tests
In iD codebase `loc` is usually a single coordinate pair
and `coordinates` is usually an array of pairs
2019-02-12 21:18:25 -05:00
Quincy Morgan bfb5285dc9 Fix tests and lint warnings 2019-02-04 13:34:27 -05:00
Xiaoming Gao 08bc219e6f fix tests for crossing way validation check
There're still test failures for "Almost Junction"; those are fixed
in a separate PR.
2019-01-18 22:26:27 -05:00
Quincy Morgan d9c6bd1f39 Added specialized issue messages for the common types of way crossing issues
Fixed several linting issues involving crossing way validations
2018-12-21 14:45:20 -05:00
Xiaoming Gao dee005e9aa Improve cross way check
1. Add more way types and relation types to check
2. Add more legit crossing cases
3. Add tests for 1 and 2
2018-12-21 14:00:31 -05:00
Xiaoming Gao a4e1012c91 add crossing_way validation
Tests are also added and passed.

One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
2018-12-19 19:23:35 -05:00