Commit Graph

461 Commits

Author SHA1 Message Date
Quincy Morgan
2ed4acaf2e Apply "statused" styling to planned features 2020-02-12 16:34:40 -08:00
Quincy Morgan
5674f75a11 Make the icons larger and centered on ImproveOSM and Osmose issue markers 2020-02-12 14:52:49 -08:00
SilentSpike
8bb2dc7fa6 Return Promise for Osmose string requests 2020-02-07 11:21:33 +00:00
SilentSpike
51efd5b714 Update and standardise QA implementations
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
SilentSpike
ecadafb3e4 Use Osmose supplied hex colors 2020-02-03 23:20:45 +00:00
SilentSpike
7a00c0a974 Use Osmose locale filter and detail strings 2020-02-03 23:20:44 +00:00
SilentSpike
5d93d3cace Prepare to use Osmose issue detail strings
- Remove translation description strings, will be using supplied
translations once the API is updated
- Change the way elements and details are presented since they can't be
easily integrated into the 3rd party description strings
2020-02-03 23:20:44 +00:00
SilentSpike
7d76950d55 Use Osmose translation strings for issue titles
This is just step one in the process while we wait for the API to supply
further strings and filtering to reduce the amount of string data
requested (since we don't need it all).

Strings are requested when the layer is first enabled and cached for the
current language (plus English as a backup).
2020-02-03 23:20:43 +00:00
SilentSpike
406264c37e Simplify structure of QA error data 2020-02-03 23:20:42 +00:00
SilentSpike
680fdb6b54 Allow Osmose errors to use category for UI strings
Some error types don't require unique strings and can share common
strings among the category. This makes that possible as well as adding
support for some other types of error for demonstrative purposes.
2020-02-03 23:01:02 +00:00
SilentSpike
e11d97b38c Add Osmose QA layer and service
Initial implementation - need to add UI for the errors and correctly set
up support for the desired error types provided by osmose.
2020-02-03 23:01:01 +00:00
Bryan Housel
6e5cb45c17 Don't bundle the imagery anymore, fetch from dist/data at runtime
(re: #4994)
2020-01-30 17:10:41 -05:00
Bryan Housel
89724cfb1b Remove support for debug rendering of the community index
We have http://openstreetmap.community now for this, and it eliminates
another place in the code where that data would have been needed.
This commit also ES6ifies svgDebug.
2020-01-29 13:35:25 -05:00
Quincy Morgan
51a3fce4eb Account for instances where icon has multiple classes 2020-01-16 10:33:59 -05:00
Quincy Morgan
544dd1a742 Use the icon class when selecting icons 2020-01-16 10:31:25 -05:00
Quincy Morgan
912151ff38 Allow viewing and editing the tags/relations of selected features at any zoom level in 2.x (re: #5001) 2019-12-12 16:54:16 -05:00
Quincy Morgan
4d8d27f3c4 Rely more on mapillary selected photo key than photoviewer datum
Remove mapillary map feature selection outline when closing photoviewer
2019-12-11 17:53:03 -05:00
Quincy Morgan
5e756bb90d Fix lint warning 2019-12-11 17:32:57 -05:00
Quincy Morgan
0d5bd8b277 Store selected mapillary image by its key rather than its object
Properly sort selected mapillary signs and features above unselected ones
2019-12-11 17:15:36 -05:00
Quincy Morgan
e335f0a086 Don't style untagged multipolygon member lines as area boundaries if they also have belong to non-multipolygon relations (close #6787) 2019-12-11 16:32:00 -05:00
Quincy Morgan
0b7d5b29c7 Add icon and tooltip for mapillary detected billboards 2019-12-11 15:58:09 -05:00
Quincy Morgan
df3b281d39 Fix mapillary detection selection rendering in Firefox and Safari (close #6804)
Fix mapillary feature detection tooltips (re: #7079)
2019-12-11 15:03:54 -05:00
Quincy Morgan
5cab4b1386 Revert circular markers (open #6163) 2019-12-10 11:23:12 -05:00
Quincy Morgan
dffe80fb5f Taper the point marker shape somewhat (re: #6163) 2019-12-10 10:53:53 -05:00
Quincy Morgan
00e8a125e2 Make point markers more circular with larger icons (close #6163)
Tweak the grey style of points linked to wikidata
2019-12-09 17:21:33 -05:00
Quincy Morgan
231e2c71a1 Add unsearchable preset for demolished:building=yes (close #7098)
Render features with a status prefix in the provisional styles (e.g. dashed outline)
2019-12-09 11:13:42 -05:00
Bryan Housel
baca525117 User lighter green fill for golf=green
(closes #7101)

This also adds fill styles for the other light-green things like cemetaries
vineyards, etc.. For some reason they didn't have fill styles before so only
the strokes were being styled light green.
2019-12-09 10:10:03 -05:00
Quincy Morgan
db300d1071 Add tooltips to mapillary map features layer icons (close #7079) 2019-12-05 11:52:12 -05:00
Quincy Morgan
bc0d83b5cd Apply label baseline hack to Firefox 70+ (close #7044) 2019-11-13 15:36:22 -05:00
Bryan Housel
d986d1b68d Use native Promises and drop "q" dependency, update streetside.js to es6 2019-11-08 16:24:41 -05:00
Quincy Morgan
3f35a35dd1 Remove unused imperial.json and drive-left.json data files 2019-11-08 19:28:02 +01:00
Quincy Morgan
271a4cbac7 Update rbush to 3.0.1 (close #6359) 2019-11-08 18:17:17 +01:00
Quincy Morgan
c5e1c0d596 Fix lint warning 2019-10-11 14:02:19 +02:00
Quincy Morgan
92116f198a Only show edited vertices as needed (close #6934) 2019-10-11 14:01:07 +02:00
Quincy Morgan
82acd82a29 Don't make edited vertex targets larger
Render vertex and point change highlight with some opacity
2019-10-10 18:58:39 +02:00
Quincy Morgan
18a2c6c320 Fix issue where false edited segment indicators could appear 2019-10-10 18:28:43 +02:00
Quincy Morgan
c7186e2ee6 Replace usage of lodash isEqual (re: #6843) 2019-10-08 20:42:58 +02:00
Quincy Morgan
7d31c76546 Unify visual diff styles for lines and areas (re: #6843)
Render tag-only diffs in yellow instead of translucent orange
Don't use target colors for vertex diff styling
2019-10-08 20:25:09 +02:00
Quincy Morgan
2924d4619a Show visual diff for standalone points (re: #6843) 2019-10-07 16:33:35 +02:00
Quincy Morgan
f3e7bd9034 Render line and vertex visual diff on shadow instead of above everything (re: #6843)
Differentiate added lines and vertices from merely changed ones
2019-10-07 16:13:35 +02:00
Quincy Morgan
909079e454 Replace uses of lodash omit (re: #6843)
Fix lint warnings
2019-10-07 11:43:40 +02:00
Quincy Morgan
c031f2dd33 Merge branch '2.15' into 215_highlight_edits
# Conflicts:
#	modules/svg/areas.js
2019-10-07 10:49:52 +02:00
Huon Wilson
de2f052eb9 Change cliff direction marker to dark grey to match the line
Cliffs had their colour changed in 5f9bea67d, but the directional
arrow remained green.

Fixes #6918
2019-10-07 13:11:40 +11:00
Quincy Morgan
2ccdc438f4 Render area fill patterns in preset icons (close #6900) 2019-09-30 12:27:33 +02:00
Benjamin Clark
ad5025de3e Add support for area diffs. 2019-09-11 14:14:06 -04:00
Benjamin Clark
a0f85967b0 highlight edits now differentiates between tag edits and geometry edits for vertices/lines. 2019-09-11 13:02:12 -04:00
Benjamin Clark
a4dc7518c4 Add a hotkey to highlight edited ways. 2019-09-11 13:02:12 -04:00
Matias Volpe
8e616d7384 feat: add Mapillary Map Features layer 2019-08-22 15:16:31 -03:00
Quincy Morgan
1bce70e3f5 Update directional arrow styling when switching between directional presets (close #6032) 2019-07-17 13:55:56 -04:00
Quincy Morgan
3d9bcc8234 Add directional arrows to waterway=weir rendered as lines (close #6615) 2019-07-03 15:46:23 -04:00