Commit Graph

4895 Commits

Author SHA1 Message Date
Martin Raifer
460a9efce1 fix brief flickering during tile switching when zooming, fixes #10660 2025-01-08 12:17:52 +01:00
Martin Raifer
28183c71bb Merge remote-tracking branch 'michaelabon/stop-password-managers-address-fields' into develop 2024-12-18 15:40:22 +01:00
Martin Raifer
1a7cf41ed0 Merge branch 'fix-grid' into develop 2024-12-18 15:31:45 +01:00
Martin Raifer
4dc8f981bd Link to PR in inline comments 2024-12-18 15:21:50 +01:00
Louis Demange
28e7faa13b Apply plus-lighter only at specific zoom levels 2024-12-17 07:01:21 +01:00
Nekzuris
dcfcf222e2 Dynamic epsilon for specific pixel ratios on Chrome 2024-12-13 19:47:40 +01:00
Devin Fahnestock
313022728c prevent map panels from covering up edit menu, fixes #10495 (#10586) 2024-12-13 15:08:50 +01:00
Martin Raifer
0d8a367c35 Merge pull request #10523 from openstreetmap/kh/10522-mismatched-geom 2024-12-11 15:12:28 +01:00
Deeptanshu Sankhwar
9e2f9e0324 add a short reminder for data being objective during the walkthrough, fixes #10566 (#10568) 2024-12-11 15:06:28 +01:00
Martin Raifer
3be7eb6fca restrict direction cones to matching parent ways, fixes #9013
for certain vertex features, only look at matching parent ways when determining where to draw direction cones:

* highway related points (e.g. highway=stop/yield/etc., traffic calming, cycleway=asl, traffic signs, barriers): only look at parent ways with highway=*
* railway related points (e.g. railway=milestone): only look at parent ways with railway=*
* waterway related points (e.g. waterway=milestone): only look at parent ways with waterway=*

see also #5634
2024-12-11 12:04:41 +01:00
Nekzuris
b2c51929c6 Fix visible grid around tiles 2024-12-11 02:30:38 +01:00
Martin Raifer
404e08518e use correct margins when limiting photoviewer size, fixes #10558
replaces hardcoded values with dynamically calculated heights/margins.

closes #10563
2024-12-04 13:03:34 +01:00
Martin Raifer
f38bc5fc78 harmonize how Kartaview layer is highlighting marker on hover, fixes #10531
also closes #10565
2024-12-04 10:31:04 +01:00
Deeptanshu Sankhwar
e48aa3c2c4 Ensure correct this context for addMembership function to call the blur method correctly. Fixes #10555 (#10560)
* Pass the  reference explicitly to the  function to ensure the correct context is available.

* refactor: handle blur() in a closure to separate UI logic from addMembership

* spacing

* Fixed typo

---------

Co-authored-by: Deeptanshu Sankhwar <deeptanshu@walletsocket.com>
Co-authored-by: Minh Nguyễn <mxn@1ec5.org>
2024-11-30 22:43:54 -08:00
Dimitar
b3579d6c7c Preserve 'opening_hours' when matching with NSI
re: https://github.com/osmlab/name-suggestion-index/issues/10170#issuecomment-2508129832
re: b1f2c3f4d0

These are tags that we want to leave alone (i.e. not offer an "upgrade")
if they already have a value. We assume the mapper knows best.
2024-11-29 20:28:31 +02:00
Kyle Hensel
50309005a1 fix erroneous mismatched_geometry warning for preset-less tags 2024-11-23 04:48:28 +14:00
Martin Raifer
93c8e3dd7d Merge remote-tracking branch 'k-yle/kh/mismatched-geom-error' into develop 2024-11-13 15:27:30 +01:00
Minh Nguyễn
6cfd1cf6fc Include route number in label of named route relations (#10478)
* iD#8707 Show ref in the name of route relations

* Avoid combining PTv2-formatted name with ref

* Pair name with other tags when labeling routes

---------

Co-authored-by: Kyle Hensel <k.y.l.e@outlook.co.nz>
2024-11-03 16:38:00 -08:00
Martin Raifer
5024feafe8 Fix flickering when switching between background imagery layers
and make switching backgrounds snappier
2024-10-21 18:31:07 +02:00
Michael Abon
6ffba9f7ff Stop password managers from autofilling address fields
I am a 1Password user (and employee).
Whenever I am editing a local business's details in iD,
I am frustrated that the 1Password browser extension offers
to fill out my personal address
instead of the business's address.

I don't work on our browser extension,
I could not tell you why every password manager
has their own custom data attribute
when autocomplete=off exists.
But, for fairness,
I am including other major password managers'
custom data attributes to stop them as well
from autofilling address fields.

I was very pleased to find out that
there was already
a well-used utility function
to disable autocomplete/autocorrect/autocapitalize.

Fixes #10507
2024-10-18 12:38:01 -05:00
Martin Raifer
b4e55c2027 backport fixes from PR#10452 missing in merge e839b6307 2024-10-16 13:49:03 +02:00
Kyle Hensel
108893c624 enable --no-isolate to speed up unit tests
This required fixing deferred code that was running after the unit test had unmounted
2024-10-16 13:42:51 +02:00
Martin Raifer
e839b63079 Merge branch 'kh/vitest' into develop 2024-10-16 13:37:20 +02:00
Minh Nguyễn
37939c869a wmf-sitematrix v0.2.0 (#10489) 2024-10-11 12:53:08 +02:00
Kyle Hensel
c3c0e23ba8 fix unsolvable validator error for presets with locationSet 2024-09-09 20:57:26 +10:00
Kyle Hensel
7bc94d6f4b migrate unit tests to vitest 2024-09-03 19:23:21 +10:00
Kyle Hensel
7afecd39ec minor tweaks to make some tests pass 2024-09-03 19:23:21 +10:00
Kyle Hensel
90c4241723 fix dependency cycle caused by utilDisplayLabel importing presetManager 2024-08-24 11:34:46 +10:00
Martin Raifer
34bb143561 fix undefined translation string, see #10417 2024-08-22 13:54:23 +02:00
Martin Raifer
31bef9f064 fix calculation of non-node feature extents, fixes #10417 2024-08-22 13:52:24 +02:00
Martin Raifer
942f0a0648 fix note not loading when both id and map hash parameters are set 2024-08-21 11:15:43 +02:00
Martin Raifer
b0e47ca93c make sure viewer is visible before selecting photo
otherwise the newly selected photo is not displayed correctly when switching between regular and 360 photos

see #10362
2024-08-08 14:55:46 +02:00
Martin Raifer
9e239df569 fix intermittent issues with Bing Streetside API
sometimes the API returns data in a format not matching the documented format (see https://learn.microsoft.com/en-us/bingmaps/articles/getting-streetside-tiles-from-imagery-metadata).

see https://github.com/openstreetmap/iD/issues/10341#issuecomment-2275724738

closes #10341
2024-08-08 14:44:50 +02:00
Martin Raifer
43dab66b3a only rotate selected image's cone to viewer yaw, fixes #10390 2024-08-08 13:58:58 +02:00
Martin Raifer
f570d9bfa3 increase max zoom for panellum viewer, closes #10391 2024-08-08 13:07:35 +02:00
Martin Raifer
a8e438c58d sort markers by date (newest on top) 2024-08-07 10:00:59 +02:00
Martin Raifer
136308821a make sure the active image is rendered above other photo markers 2024-08-07 09:54:54 +02:00
Martin Raifer
7e111944db try to equally space to be rendered markers in mid zoom levels
closes #10378
2024-08-07 09:30:46 +02:00
Mattia Pezzotti
9f643aaae1 hide panoramax markers in low zoom overview (#10386)
fixes #10377
2024-08-07 09:08:54 +02:00
Mattia Pezzotti
309735c25e Fix panoramax blur when switching imagery (#10385)
fixes #10362
2024-08-07 09:03:20 +02:00
Mattia Pezzotti
ebb68d610e Fix panoramax non existing inaccurate sequence (#10375)
fixes #10365
2024-08-03 21:08:57 +02:00
Mattia Pezzotti
dd7de08a35 Fix panoramax highlight selected sequence (#10374)
closes #10366
2024-08-03 21:03:58 +02:00
Mattia Pezzotti
e9095eb1bf Fix panoramax errors when image not in cache (#10376) 2024-08-03 20:45:38 +02:00
Martin Raifer
945fea1dc0 allow to enter strings with quote marks in raw tag editor's text mode (#10371)
and use fully quoted strings for cases which have characters that need to be encoded

old: tag=foo\"bar\" -> new: tag=foo"bar" or tag="foo\"bar\""
old: tag=foo\nbar   -> new: tag="foo\nbar"

falls back to raw tag values if a quoted string cannot be parsed
2024-08-01 15:19:33 +02:00
Martin Raifer
0ea3afa9f7 make sure map is not panned on arrow key input on 360° photo viewer
if the pannellum viewer is active, the arrow keys should rotate the view, and not also pan the map.

fixes #10360
2024-07-31 18:09:06 +02:00
Martin Raifer
e89121b550 fix vegbilder overlay from being overwritten by panoramax layer 2024-07-31 17:53:33 +02:00
Martin Raifer
b4eaeb3088 lint: remove unused code, code style and early update cached username 2024-07-29 16:29:39 +02:00
Martin Raifer
4646b67bac drop (for now) unused ui code 2024-07-29 16:22:46 +02:00
Martin Raifer
f25e94c71b update username filter on input change; fix multiple names/ids
in panoramax a username can resolve to multiple ids (when the same name is used on multiple servers).
further, the username filter input field can contain more than one username
2024-07-29 16:15:34 +02:00
Martin Raifer
608251a6ab update photos immediately when filters change 2024-07-29 15:47:24 +02:00