Commit Graph

55 Commits

Author SHA1 Message Date
Quincy Morgan
38db23fab5 Extend behaviorHover to support multiple pointers 2020-05-27 15:07:23 -04:00
Quincy Morgan
caec202a08 Fix potential JS error and some formatting 2020-05-26 13:47:15 -04:00
Quincy Morgan
bd376a3a7d Fix lint error 2020-05-26 10:52:04 -04:00
Jacob Scherber
e11070d3a3 cleanup coding style 2020-05-23 15:50:27 -07:00
Jacob Scherber
e8233247d3 add highlight to multi-select hover 2020-05-23 15:06:58 -07:00
Quincy Morgan
67bd93b14c Fix sidebar drag-resizing when iD is embedded at x!=0 2020-05-21 13:54:28 -04:00
Quincy Morgan
5cb23acc00 Enable sidebar resizing with touch input using pointer events (re: #5505) 2020-05-21 12:32:08 -04:00
Quincy Morgan
a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406)
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
eed7944a1a Replace various uses of d3_select and d3_selectAll with selection on the container 2020-03-22 12:34:06 -07:00
Quincy Morgan
152d89fa22 Convert some element ids to classes to avoid collisions when embedding iD 2020-03-20 13:10:39 -07:00
SilentSpike
51efd5b714 Update and standardise QA implementations
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
SilentSpike
09e7b23665 Add Osmose issues UI and filtering
Filters out errors not present in the data .json file to enable
selective support since Osmose has a wide variety of errors which may be
too advanced for iD.

Also added processing for the elements associated with an error for
forced visibility and highlighting.
2020-02-03 23:01:01 +00:00
Quincy Morgan
721ee0e95f Prevent unnecessary reloading of raw tag editor (close #7248) 2020-01-18 12:30:35 -05:00
Quincy Morgan
eda51f6835 Add initial multiselection raw tag editing in 2.x 2020-01-17 17:49:26 -05:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Quincy Morgan
2da011c3ca Remove unused string
Don't show preset browser when adding a favorite point
Don't automatically open the sidebar when selecting a non-new feature
2019-02-27 12:20:23 -05:00
Quincy Morgan
db319e8ff5 Merge branch 'master' into validation 2019-02-11 07:59:29 -05:00
Bryan Housel
d64a4c5654 Don't pan map when resizing sidebar on right-to-left layout
(closes #5881)
2019-02-09 15:48:55 -05:00
Quincy Morgan
8771a33716 Merge branch 'master' into validation 2019-02-05 11:30:24 -05:00
SilentSpike
781558e56b Remove redundant source property 2019-02-04 18:40:06 +00:00
SilentSpike
40af841d53 Fix sidebar preview for new generic errors 2019-02-04 16:54:07 +00:00
Quincy Morgan
8c51411ad6 Merge branch 'master' into validation 2019-02-04 08:58:10 -05:00
SilentSpike
ee5f9f3bf2 Use consistent short service name 2019-02-01 22:51:02 +00:00
SilentSpike
ac4cec1429 Add sidebar preview for ImproveOSM errors 2019-02-01 22:50:57 +00:00
Quincy Morgan
11b2102761 Merge branch 'master' into validation
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
#	modules/ui/commit_warnings.js
#	modules/ui/entity_editor.js
#	modules/util/index.js
#	modules/util/util.js
#	modules/validations/index.js
#	modules/validations/many_deletions.js
#	modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Bryan Housel
7986fcbfbf Merge branch 'keep-right_QA' 2019-01-04 21:37:19 -05:00
Bryan Housel
46ebce2d6f Fix error reporting urls and make sure sidebar not showing stale data 2019-01-03 11:37:14 -05:00
Quincy Morgan
c9350c632e Add issue fixes UI
Add two issue fixes for untagged feature
2018-12-21 12:31:33 -05:00
Quincy Morgan
cfbb86f88c Change the initial view of the sidebar on selection 2018-12-19 17:44:41 -05:00
Bryan Housel
2deadd5d6c Fix merge issues 2018-12-19 17:12:06 -05:00
Thomas Hervey
31f35b0389 added basics to sidebar 2018-12-19 13:35:26 -05:00
Bryan Housel
43cea82d6f Make sure when selecting to restore the sidebar to select mode
(closes #5603)
2018-12-14 17:31:10 -05:00
J Guthrie
6137941efd Redraw restrictions panel when dragging sidebar 2018-11-19 15:23:30 +00:00
Bryan Housel
509464c932 Don't allow user to toggle sidebar in the walkthrough
(this would mess up all the tooltips)
2018-11-08 14:07:06 -05:00
Bryan Housel
42aa834fab Avoid obscuring selected entity when expanding the sidebar 2018-11-06 17:03:58 -05:00
Bryan Housel
cc227ed4e2 Make map panning optional on sidebar expand/collapse 2018-11-06 16:06:45 -05:00
Bryan Housel
e31e84b109 Simplify some things I found confusing
- class the #sidebar itself as collapsed not the #id-container
- the #sidebar is the selection, so just use `selection` instead of
  `var sidebar = d3_select('#sidebar');`
  (which conflicts with the closure `sidebar()` function)
- have separate functions `expand` `collapse` `toggle` rather than a
  `toggle(shouldCollapse)`
2018-11-06 15:08:05 -05:00
Bryan Housel
3d65dd8903 preventDefault on sourceEvent, if present
This prevents a crash when d3_event is not the actual event, but is a
transition event or similar
2018-11-06 14:16:23 -05:00
Bryan Housel
d4e31a82e3 Adjust sidebar resizer to keep map still by anti-panning 2018-11-02 23:21:59 -04:00
Quincy Morgan
a0b0337ab4 - The sidebar can be now be resized by dragging the divider (closes #3447)
- Dragging the sidebar below a minimum size collapses it
- A button in the top toolbar lets you uncollapse the sidebar, complete with icon and tooltip
- Double-clicking the divider toggles the sidebar collapse
- Collapse-toggling is animated
- Selecting a feature or ending an add-feature mode auto-opens the sidebar
- Photoviewer UI has been moved from init.js to photoviewer.js
- The photoviewer now has a slight margin to set it away from the sidebar
- The undo/redo, save, and progress indicator controls are now floated to the right
- The save count has been redesigned to visually integrate with the save button
- When the sidebar is collapsed, the mode buttons are centered
- Full right-to-left layout support for all of the above
2018-10-27 17:05:50 -07:00
Bryan Housel
0a82ab125e Add uiDataEditor for inspecting custom map data 2018-08-25 10:10:04 -04:00
Bryan Housel
a9aca707b6 Support hovering on data features 2018-08-25 00:04:52 -04:00
Thomas Hervey
e23ef4ba4a redraw on note drag. TODO: change dispatch call 2018-07-23 15:09:25 -04:00
Thomas Hervey
373353f40d added breathe behavior & cleaned hover/select styling on notes 2018-07-21 15:54:47 -04:00
Bryan Housel
fe7086f753 Add header close 'X' button, add grey hover styling 2018-07-12 02:51:49 -04:00
Thomas Hervey
bd8705bf85 updated: reintroduced hovering on notes 2018-07-02 16:32:17 -04:00
Bryan Housel
94eae89fc3 Merge, continue to tweak note_editor 2018-07-02 12:50:53 -04:00
Thomas Hervey
2c22fe00a2 updated: hacky note hovering; todo: complete note click handling 2018-07-02 10:44:47 -04:00
Thomas Hervey
737ccfcfba updated: siebar displays note details on hover (via svg) 2018-06-29 14:43:01 -04:00
Bryan Housel
3d13620705 Convert lodah-es and d3 to named imports for ui 2017-09-26 11:22:43 -04:00