SilentSpike
ee5f9f3bf2
Use consistent short service name
2019-02-01 22:51:02 +00:00
SilentSpike
54e02ec28d
Introduce new container icon for errors
...
As per my last commit, this icon differentiates errors from points and
still allows us to specifiy icons for errors to differentiate them amongst
eachother.
I learned quite a bit about SVGs and using them in HTML while
implementing this 😝 Had some issues getting the icon to center in the
header so resorted to using a flexbox instead of absolute positioning
being used elsewhere.
2019-02-01 22:51:02 +00:00
SilentSpike
5d907c1e16
Render errors like points with icons
...
This allows more diverse representation of the error subject at a glance
than relying on colour alone.
However, it would be good to have a generic error icon that can contain
icons which is differentiated from the point icon for clarity.
Sidebar header currently still uses the bolt icon until I figure out
how to deal with that. Also the font awesome icons don't seem to work,
perhaps there's additional code needed for those that I've missed.
2019-02-01 22:51:01 +00:00
SilentSpike
4a166d7a5b
Use more descriptive key names
2019-02-01 22:51:01 +00:00
SilentSpike
88a59cb15f
Stop hijacking the inflight cache
...
This could result in error updates getting aborted when new errors are
loaded as their individual ids are never going to match tile IDs (see
`abortUnwantedRequests` function).
2019-02-01 22:51:01 +00:00
SilentSpike
f6746a28ff
Match error red to road sign red
2019-02-01 22:51:00 +00:00
SilentSpike
6483c54ca4
Update ImproveOSM error colouring
...
Fix similar orange colours by using the same zoomed in colours as
ImproveOSM for missing geometry (i.e. pink for roads).
This frees up red for turn restrictions (as they are typically signed in
red) and therefore blue for one-ways (as they tend to be signed blue or
black).
2019-02-01 22:51:00 +00:00
SilentSpike
fe73b3df5a
Improve error icon position and appearance
2019-02-01 22:51:00 +00:00
SilentSpike
5030346257
Update data layers test
2019-02-01 22:51:00 +00:00
SilentSpike
3334abf776
Remove some unnecessary code
2019-02-01 22:51:00 +00:00
SilentSpike
31091f1159
Add direction of travel to oneway errors
2019-02-01 22:50:59 +00:00
SilentSpike
6bdd0cfa89
Fix missing semicolons
2019-02-01 22:50:58 +00:00
SilentSpike
3174db76b7
Fix north direction in some error descriptions
2019-02-01 22:50:58 +00:00
SilentSpike
9d2792836f
Add ImproveOSM error resolution
2019-02-01 22:50:58 +00:00
SilentSpike
ac4cec1429
Add sidebar preview for ImproveOSM errors
2019-02-01 22:50:57 +00:00
SilentSpike
214cf41019
Use more generic classes for errors
2019-02-01 22:50:57 +00:00
SilentSpike
39880e559b
Add direction of travel to turn restriction errors
2019-02-01 22:50:56 +00:00
SilentSpike
9600d67fc6
Differentiate missing geometry errors by colour
2019-02-01 22:50:56 +00:00
SilentSpike
bea6f4dcfd
Use point averages for locations
2019-02-01 22:50:56 +00:00
SilentSpike
ca290b5101
Add details to error messages
2019-02-01 22:50:55 +00:00
SilentSpike
23a4d71410
Handle turn restriction errors
2019-02-01 22:50:55 +00:00
SilentSpike
4f2646d567
Add basic title + description UI
2019-02-01 22:50:54 +00:00
SilentSpike
4d89810721
Add ImproveOSM service
...
Only processing one-way errors for now
2019-02-01 22:50:54 +00:00
Max Grossman
58e31bc45a
initial update to draw modes and hover behavior
...
ref #5811
2019-02-01 17:34:40 -05:00
Quincy Morgan
5a309fd57a
Merge branch 'master' into validation
2019-02-01 16:47:10 -05:00
Bryan Housel
9d8a0b7843
Merge pull request #5836 from openstreetmap/5829
...
do not close image viewer if street level imagery layers are still rendered
2019-02-01 16:42:31 -05:00
Bryan Housel
491ec40435
Ditch the separate linear platform presets for public transport
...
(closes #5837 )
2019-02-01 16:42:52 -05:00
Quincy Morgan
251d83f86c
Show warnings and errors in different lists in the issues pane
2019-02-01 16:38:48 -05:00
Bryan Housel
e50b82d2ad
Ditch the separate linear platform presets for public transport
...
(closes #5837 )
2019-02-01 16:38:33 -05:00
Quincy Morgan
19cc6399fe
Merge branch 'master' into validation
2019-02-01 15:20:38 -05:00
Quincy Morgan
9785021f44
Rename simpleMultipolygon functions to oldMultipolygon
...
Return old_multipolygon validation issues for the relations as well as the outer ways
Remove console logging
Don't run missing_tag validation for relations with old_multipolygon issues
2019-02-01 15:19:28 -05:00
Bryan Housel
f79d3d1d9f
Change color of groyne, breakwater, dam, weir
...
(closes #5759 )
Now rendered in grey instead of blue waterway color
2019-02-01 14:28:31 -05:00
Bryan Housel
df093b25fe
Only add the documentation bottom padding when expanded
2019-02-01 14:02:36 -05:00
Max Grossman
7f837c7e0c
no need to generate service variable
...
ref #5929
2019-02-01 14:01:17 -05:00
Max Grossman
ec1a42ad39
clean up & remove hideViewer for openstreetcam
...
ref #5829
2019-02-01 13:59:04 -05:00
Max Grossman
d894521143
just don't close viewer...
...
ref #5829
2019-02-01 13:55:10 -05:00
Quincy Morgan
973697b8ba
Run all validators in the validations folder if not manually run
...
Remove ValidationIssueType and ValidationIssueSeverity objects
2019-02-01 13:38:17 -05:00
Bryan Housel
b75b7c567d
Increase padding slightly between tag refrence and following element
2019-02-01 13:35:37 -05:00
Max Grossman
ce8d16a220
initial commit...hide parts, not entire viewer
...
ref #5829
2019-02-01 11:49:30 -05:00
Bryan Housel
d1fca87d79
Replace Edit Documentation link with pencil icon
...
(closes #5753 )
2019-02-01 11:49:03 -05:00
Quincy Morgan
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Bryan Housel
bde55bd7ee
Update presets for new community index
2019-02-01 11:02:42 -05:00
Bryan Housel
e60dafa540
Fix crossing ways validation - geoChooseEdge takes projected loc
2019-01-30 23:40:17 -05:00
SilentSpike
7893b30e40
Add .json to .editorconfig
2019-01-30 23:40:17 -05:00
SilentSpike
1ae45b94f5
Add .editorconfig file
2019-01-30 23:40:17 -05:00
Quincy Morgan
957eb28242
Don't run other validators if feature is missing tags
...
Don't run disconnected highway check if there is an almost junction issue already
Only run way validators on ways
2019-01-30 17:59:23 -05:00
Bryan Housel
fc7fcd1e29
Merge pull request #5834 from SilentSpike/editorconfig
...
Add .editorconfig file
2019-01-30 17:25:45 -05:00
SilentSpike
9efcb60960
Add .json to .editorconfig
2019-01-30 22:22:17 +00:00
SilentSpike
1a66435b35
Add .editorconfig file
2019-01-30 21:47:17 +00:00
Quincy Morgan
09bc2a6e6c
Merge branch 'master' into validation
2019-01-30 16:44:14 -05:00