4c1d51348d
Don't repurpose a node with interesting tags in crossing_ways fix
...
(closes #8326 )
2021-01-27 14:38:11 -05:00
c940d827e6
Enable the Split operation for multiple selected nodes ( close #7990 )
2020-09-24 15:13:05 -04:00
7b5df1bc40
Add lang attribute to issue fix labels (re: #7963 )
2020-09-22 17:48:35 -04:00
aa9b44a0bf
Add the lang attribute to issue messages (re: #7963 )
2020-09-22 17:25:18 -04:00
5435082d9c
Revert t function to returning the plain string by default
...
Add `t.html` function for getting the string with the `lang` attribute
2020-09-22 12:03:29 -04:00
32f8274929
Make t function return a span element with a lang attribute unless html: false is specified in the options (re: #7963 )
...
Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
2020-09-15 21:56:22 -04:00
e5d4fcfa44
Properly handle disambiguating tags on crossing multipolygons ( close #7935 )
2020-09-01 17:31:16 -04:00
59aa79548e
Use tram crossing tags when connecting crossing tram tracks with roads/paths ( close #7902 )
2020-08-15 13:25:26 -04:00
4205ca1d07
Fix the seemingly safe spellings found by codespell
...
Untested, only checked by inspection.
(cherry picked from commit 2c47a11008
2020-08-10 17:32:37 +01:00
d179f791a9
Significantly improve the performance of the crossing_ways validation in areas with long ways ( close #7656 )
2020-06-22 16:49:32 -04:00
ef48fb0c50
Fix potential error in crossing ways validation
2020-04-14 15:52:05 -07:00
3a933de876
Don't add tags to connection node when connecting crossing line/area
2020-04-13 18:57:26 -07:00
513b344012
Fix code tests
2020-04-03 13:33:54 -07:00
ca1e2031e7
Flag issues with crossing highway areas ( close #7455 )
...
Don't show add bridge/tunnel fixes for highway areas (close #7472 )
2020-04-03 12:30:07 -07:00
0120b009fa
Take a graph parameter in utilDisplayLabel instead of the context
2020-04-01 13:29:17 -07:00
a1af118f0e
Ensure locales and presets are loaded before the UI loads ( close #7406 )
...
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
a7cba6a694
Don't show the tunnel fix for features crossing waterways (re: #7447 )
2020-03-23 10:13:21 -07:00
fe5ca6867c
Fix error in generating outdated_tags messgae
2020-02-04 13:00:14 -05:00
45d22261fc
Don't leave an extra junction segment when the end node of the crossing edge is only the endpoint of two lines (re: #7202 )
...
Make the length of added crossing structures much closer to the intended spherical length
2020-01-16 17:55:13 -05:00
6c30ae2664
Where possible, leave a segment between structures and intersections when applying the "add a bridge/tunnel" fix ( close #7202 )
2020-01-09 11:36:19 -05:00
4adecbb6ac
Account for the angle of the crossing in the length of structures when applying "add a bridge/tunnel" fixes
2020-01-08 14:11:27 -05:00
09ad21a26f
Improve "add a bridge/tunnel" fixes by basing the structure length on the crossed feature type, not a fixed constant (re: #7202 )
2020-01-08 12:03:30 -05:00
a7dd6db8a7
Use tunnel=culvert on waterways when using the "add a tunnel" crossing ways fix (re: #6617 )
2019-12-11 10:31:33 -05:00
394396326c
Update to temaki 3.4.0 ( close #7102 )
2019-12-09 12:44:17 -05:00
62865db740
Fix issue where crossing ways layer fix would set layer tag as a number instead of a string (re: #6911 )
2019-11-22 15:50:40 -05:00
7cd57789fe
Improve "add a bridge/tunnel" fix variable names somewhat (re: #7055 )
...
Add a minimum structure length as derived from the crossing feature's width
2019-11-20 16:58:42 -05:00
ff6eb88957
Update add a bridge/tunnel fix icons
2019-11-20 16:04:10 -05:00
e791b7514c
Use existing vertices for "add a bridge/tunnel" endpoints if the edge is too short to add a new vertex (re: #7055 )
...
Avoid creating very short edges from splitting too close to another node when adding a bridge or tunnel via fix
Fix possible "entity not found" error
2019-11-20 15:44:14 -05:00
5640d7867a
Simplify some "add bridge or tunnel" fix code (re: #7055 )
...
Add endpoint to actionSplit to get the created ways after running the action
Change "Use bridge" or "tunnel" fix labels to "Add a bridge" or "tunnel"
Add layer tags on structure feature when adding a bridge or tunnel via a fix
Select all components of the split way when adding a bridge or tunnel via a fix
Don't recommend adding a bridge to a waterway
Don't show "change layers" fixes along with "add structure" fixes
Don't split or change the tags of coincident ways when adding a bridge or tunnel
2019-11-20 13:09:27 -05:00
5ed22cce21
create bridge or tunnel when crossed ways
2019-11-20 12:54:43 -05:00
24c72b64d1
Load issue fixes dynamically instead of cacheing them ( close #7037 )
2019-11-13 14:35:01 -05:00
3886f2dad8
Merge branch '2.15-building-crossing-layers' into 2.x
2019-10-24 15:15:06 -04:00
bd1e1b34ff
Add subtypes to crossing_ways validation warnings
...
Allow the `indoor` tag to indicate a crossing feature is indoors
2019-10-09 15:24:42 +02:00
7251a2ab90
Make "edited issues" mean "issues the user created" instead of "issues for features edited by the user"
...
Only include issues created by the user in the "warnings" changeset tags
Include counts of issues resolved by the user in the changeset tags (close #6459 )
Don't include "fixme" issue counts in "warnings" changeset tags since they're not created by the user (close #6658 )
Don't cache crossing ways issues at the rule level
2019-10-04 16:50:44 +02:00
f5995dffb0
Cherry pick crossing buildings fix
2019-10-03 20:09:49 +02:00
070cfec7c7
Specify that connecting waterways and highways with the fix will add a ford ( close #6734 )
2019-08-09 09:34:35 -05:00
1ed73b6531
Convert validation rules to validate against a specific graph, not always the current graph (re: #6459 )
2019-06-06 16:27:31 -04:00
e599488121
Lower the very close nodes warning threshold for buildings, building parts, and paths (re: #6374 )
...
Flag very close nodes in indoor features but with an extremely small threshold
2019-05-20 11:21:50 -04:00
99565e8457
Don't flag crossing waterways and pier highways
2019-05-14 15:39:04 -04:00
3a78cf512c
Move connect ways fix to its own function
...
Make the edges and connection tags part of the crossing ways issue ID
2019-05-08 10:32:25 -04:00
97cb90b562
Make issue messages dynamic ( close #6331 )
2019-05-07 14:48:30 -04:00
a4ebbaf7f5
Don't use the issue loc as a differentiator for all issues
2019-04-30 13:16:03 -07:00
26f1e29072
Merge branch 'master' into ignoring-issues
...
# Conflicts:
# data/core.yaml
# dist/locales/en.json
2019-04-30 13:05:07 -07:00
9d6b461d0e
Apply the crossing tag of the path to the node even if it's not a footpath when connecting crossing ways
2019-04-30 11:53:03 -07:00
07573091ad
Don't add a "crossing" tag to ambiguous crossings when connecting crossing ways via the quick fix (re: #6244 )
2019-04-30 11:46:15 -07:00
375779882d
Add ability to ignore warnings
...
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
2019-04-29 17:52:32 -07:00
ecc217f5d8
Add validation rule to flag impossible oneway highways and waterways ( close #6216 )
2019-04-26 12:04:43 -07:00
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
2ebbb68604
Restore tooltips on rule checkboxes, separate 'tip' and 'reference'
...
Reference will show on clicking info button, and can contain more
useful information than a tooltip can.
2019-04-19 13:24:55 -04:00
01d2e3eaf3
Replace validator tooltip with reference function, add tag diff
2019-04-16 17:07:53 -04:00
Bryan Housel