Commit Graph

1709 Commits

Author SHA1 Message Date
Bryan Housel
cc227ed4e2 Make map panning optional on sidebar expand/collapse 2018-11-06 16:06:45 -05:00
Bryan Housel
e31e84b109 Simplify some things I found confusing
- class the #sidebar itself as collapsed not the #id-container
- the #sidebar is the selection, so just use `selection` instead of
  `var sidebar = d3_select('#sidebar');`
  (which conflicts with the closure `sidebar()` function)
- have separate functions `expand` `collapse` `toggle` rather than a
  `toggle(shouldCollapse)`
2018-11-06 15:08:05 -05:00
Bryan Housel
3d65dd8903 preventDefault on sourceEvent, if present
This prevents a crash when d3_event is not the actual event, but is a
transition event or similar
2018-11-06 14:16:23 -05:00
Bryan Housel
08e9476f3e Fix photoviewer resize event 2018-11-06 13:09:04 -05:00
Bryan Housel
b4119ae1ad Class toolbars with narrow if we detect overflow happening
Also add css rules to drop labels from toolbar buttons if needed
2018-11-05 17:16:50 -05:00
Bryan Housel
136e4556a7 Move spinner to flex-end, and some css cleanups 2018-11-05 12:22:20 -05:00
Bryan Housel
c1d28d9333 Wrap sidebar button in div, so the .tool-group > div rule pads it 2018-11-03 00:11:10 -04:00
Bryan Housel
d4e31a82e3 Adjust sidebar resizer to keep map still by anti-panning 2018-11-02 23:21:59 -04:00
Bryan Housel
aecbaec896 Add key to toggle the sidebar 2018-11-02 11:15:52 -04:00
Bryan Housel
c2971f667d Remove setCenter() from map.dimensions()
This was triggering a weird redraw which made the map slow and look wrong
The map will redraw again in a few milleseconds anyway.

This means that the the map will not stay on the center, but rather the
top-left corner, which kind of feels better anyway, as it doesn't move things
around as much.
2018-11-02 10:52:16 -04:00
Bryan Housel
26e63d64e3 Flexbox buttons in top bar
- Makes the "Sidebar" toggle button permanent but removes the label
- Did some things to the "Save" button to make it the same width whether there
  is a count or not (prevents the buttons from jumping when pressing undo/redo)
- Removes a lot of the floated col rules that aren't used much anymore
2018-11-01 23:42:26 -04:00
Bryan Housel
3e03102731 Simplify unpaved tag class logic, add tests
(re: #5422)
2018-10-31 16:13:03 -04:00
Bryan Housel
b79f87f511 Merge pull request #5422 from thefifthisa/style-unpaved-taxiway
Style unpaved Taxiway
2018-10-31 15:43:57 -04:00
Bryan Housel
0baf3c2ead Merge pull request #5443 from quincylvania/resizable-sidebar
Resizable Sidebar
2018-10-31 15:42:37 -04:00
hikemaniac
fa17e7fda7 Merge branch 'master' into summer_toboggan 2018-10-28 19:51:51 +01:00
hikemaniac
a36ebf3357 Added preset and rendering for attraction=summer_toboggan 2018-10-28 18:17:30 +01:00
Quincy Morgan
a0b0337ab4 - The sidebar can be now be resized by dragging the divider (closes #3447)
- Dragging the sidebar below a minimum size collapses it
- A button in the top toolbar lets you uncollapse the sidebar, complete with icon and tooltip
- Double-clicking the divider toggles the sidebar collapse
- Collapse-toggling is animated
- Selecting a feature or ending an add-feature mode auto-opens the sidebar
- Photoviewer UI has been moved from init.js to photoviewer.js
- The photoviewer now has a slight margin to set it away from the sidebar
- The undo/redo, save, and progress indicator controls are now floated to the right
- The save count has been redesigned to visually integrate with the save button
- When the sidebar is collapsed, the mode buttons are centered
- Full right-to-left layout support for all of the above
2018-10-27 17:05:50 -07:00
Bryan Housel
05709565f0 Merge pull request #5429 from quincylvania/relation-membership-highlighting
Adds hover-highlighting for relations in the raw membership list
2018-10-27 14:24:50 -04:00
n42k
bc0ec1f380 Fixed using help's navigation buttons not resetting the help pane to the top. 2018-10-27 16:21:59 +01:00
Quincy Morgan
1161767932 Moves the entity highlighting function to util/util.js
Breaks out the code for getting a selector for entities and all their descendants into a generic function
Accounts for circular relations when recursively getting all relation member IDs
2018-10-26 18:39:01 -07:00
Quincy Morgan
51386e03ae Restores the hover-highlight comment in selection_list.js 2018-10-24 22:30:29 -07:00
Quincy Morgan
ddb6e1b119 Fixes comments related to hover-highlighting 2018-10-24 22:27:37 -07:00
Quincy Morgan
81feb1cd99 Adds hover-highlighting for relations in the raw membership list
Moves hover-highlighting behavior to its own function
Hover-highlighting now correctly highlights all members of the target relation
2018-10-24 22:17:28 -07:00
thefifthisa
1c7079ee35 style unpaved taxiway 2018-10-21 00:20:02 -04:00
Bryan Housel
0cd118e4c4 Merge pull request #5416 from quincylvania/ferry-route-css
Adds custom CSS styling for ferry routes
2018-10-19 10:08:04 -04:00
Quincy Morgan
510d7e93e5 Fixes two lint warnings for unused vars 2018-10-18 18:47:04 -07:00
Quincy Morgan
38bfeb852d Adds custom CSS styling for ferry routes
Closes #5414
2018-10-18 18:31:43 -07:00
Quincy Morgan
70c3d9cf24 Adding a new point on a way now adds a vertex, not a standalone point 2018-10-18 17:36:30 -07:00
Quincy Morgan
169a92df7c Fixes label button wrap on right-to-left layouts 2018-10-15 21:20:44 -07:00
Quincy Morgan
ffe38c7975 Adds a button to the relation member list item for zooming to the feature without selecting it
Adds "remove" tooltip to the delete relation member button
2018-10-15 20:41:45 -07:00
Quincy Morgan
aeed2cc29f Adds the same hover highlighting to the selected features list as the relation members list 2018-10-14 18:31:30 -07:00
Quincy Morgan
b24256973f Makes relation members highlighted via hovering on list items more prominent 2018-10-13 23:04:35 -07:00
Quincy Morgan
cf1b391cf0 Adds highlighting of relation members in the map when hovering on their list item 2018-10-13 18:53:04 -07:00
Bryan Housel
ac341cdf5a Usability changes for parking lots
- Rename "Car Parking" to "Parking Lot"
- Rename "Multilevel Car Parking" to "Multilevel Parking Garage"
- Add red styling for Multilevel Parking Garage preset icon
2018-10-12 16:50:50 -04:00
Quincy Morgan
494ea13aac Adds the member type (node, way, or relation) to the label of non-downloaded relation members 2018-10-11 19:32:24 -07:00
Quincy Morgan
51b2335b96 Corrects CSS for focused preset list item button
Fixes arrow key navigation for right-to-left layouts
2018-10-11 19:04:01 -07:00
Quincy Morgan
b199b85829 Merge branch 'master' into preset-list-arrow-key-navigation 2018-10-11 18:22:07 -07:00
Bryan Housel
f5fcfcbdd8 Merge pull request #5396 from quincylvania/manual-relation-member-download
Adds a button that lets users manually download individual relation members
2018-10-11 16:28:11 -04:00
Bryan Housel
4cd442e09d Restore mapillary.js line endings back from CRLF -> CR, fix tests 2018-10-11 13:58:57 -04:00
Christopher Beddow
7ad55b5074 fix: traffic signs to new endpoint 2018-10-11 13:58:57 -04:00
Quincy Morgan
27158d77f3 Adds a button that lets users manually download individual relation members
Makes the map zoom to the chosen relation member if it is not currently visible
2018-10-10 20:36:53 -07:00
Quincy Morgan
3586451392 Adds custom CSS to man_made=pipeline features
Adds `location` as a secondary tag class
Adds the `tunnel` styling to lines tagged `location=underground`
2018-10-09 18:44:49 -07:00
Bryan Housel
159622f572 Don't lookup postal_code values from taginfo 2018-10-07 16:05:58 -04:00
Quincy Morgan
031b1d02fa Right arrow keydown on focused preset list item now chooses the preset
Left arrow keydown on focused preset list item now moves the focus to the category, if there is one
2018-09-29 11:01:16 -07:00
Quincy Morgan
cd8be8b5b4 Adds presets for Traffic Sign, Speed Limit Sign, and City Limit Sign, each with point/vertex variants to account for different direction fields
Makes the maxspeed field compatible with node entities
2018-09-26 19:35:44 -07:00
Quincy Morgan
92ca6a5a59 Adds navigation of the preset list using the arrow keys:
Up and down arrows move focus up and down
Right and left arrows open and close category items
2018-09-09 18:34:45 -07:00
Bryan Housel
a6b3265189 Don't chapter.reset() on change while drawing
(closes #5295)

The cause of this crash was:
- when cancelling a line, `drawWay.cancel()` needs to clean up old edits.
- it does this by looping `context.pop()` them off history until they are gone
- each `context.pop()` dispatches a 'change' event
- if we reset the chapter on one of these change events, it throws away the
   graph, and `drawWay.cancel()` can't finish what it's doing
2018-09-06 14:32:26 -04:00
Bryan Housel
f347346e70 Variable cleanups in intro 2018-09-06 14:32:09 -04:00
Bryan Housel
eba115803a Variable cleanups in behavior and modes 2018-09-06 09:50:26 -04:00
Bryan Housel
71592f3c72 Treat multicombo values other than 'no' and '' as if they are set
And don't set a multicombo value to 'yes' if it already has a non-'no' value
(closes #5291)
2018-09-04 17:31:46 -04:00