Commit Graph

48 Commits

Author SHA1 Message Date
Bryan Housel f6d144c151 Improvements, and simplify code
* don't worry about deep copying, because immutability
* don't need `attrs` parameter which is usually empty
* don't worry about resetting `v` entity version
2015-01-01 22:49:44 -05:00
Bryan Housel dae0d2d55e Add entity copy methods 2014-12-28 22:00:55 -05:00
John Firebaugh 241400faf9 Fix build 2014-10-13 16:55:15 -07:00
John Firebaugh a7fb35663c Optimize Way#area 2014-10-13 16:46:32 -07:00
John Firebaugh 69af20e44d Add mutating extent extend, for performance 2014-10-13 16:34:38 -07:00
Bryan Housel 0c5f563a26 add test for iD.Entity.layer(), fix spelling of man_made. 2014-06-09 23:39:16 -04:00
Bryan Housel 97b189b397 Precreate fixed number of layergroups between -10, 10 2014-06-09 21:20:50 -04:00
Bryan Housel 849363ff8c Group by layer to correctly depth sort lines.. 2014-06-06 16:10:37 -04:00
Bryan Housel 5ee391dd52 Better layer sorting to fix z-depth issues.. 2014-05-30 15:20:36 -04:00
Bryan Housel 10bd86cb45 Check single source for implied onewayness #2220 2014-05-23 17:07:11 -04:00
Bryan Housel b8501bcf89 iD.Way.isOneWay should return false if oneway=no #2220
i.e. overrides implied oneway tag like `highway=motorway` or `junction=roundabout`
2014-05-20 00:14:23 -04:00
Bryan Housel d245121b19 Fix isConvex() to correctly test the angle that closes the way. 2014-04-23 14:12:20 -04:00
Bryan Housel 210e7889a1 Factor makeConvex into new method, fix missing comma and style issues.. 2014-04-14 23:54:03 -04:00
Bryan Housel a928d4894d Add isConvex() to iD.Way.. 2014-04-10 11:00:13 -04:00
John Firebaugh 15590525d3 Fix build 2013-11-21 14:51:52 -08:00
John Firebaugh 8ec53185df Build iD.Way.areaKeys from presets
This eliminates the possibility that a feature will
flip from area to line when you apply a preset.

Fixes #1996
2013-11-21 13:53:06 -08:00
John Firebaugh b383bfec1f Fix unclosed area rendering (fixes #1958) 2013-11-13 17:41:57 -08:00
John Firebaugh ffdeef398d Rewrite tree logic
The main problem with the existing logic was that it
did not update the extents of relations when previously incomplete members were loaded.

It was also overly stateful; the various queues and flags
are no longer required.

Fixes #1928.
Fixes #1540.
2013-10-28 16:57:18 -07:00
John Firebaugh 1e78ee5c87 Stricter jshint 2013-10-24 16:08:48 -07:00
John Firebaugh 26e38d7f8f Return geometries rather than features in asGeoJSON
No code needs the tags, and it eliminates one level
of function calls in the d3 stream pipeline.
2013-10-16 09:40:01 -04:00
Paul Norman e6aeba1f60 Add more tags to areas list
Keys added from osm2pgsql, excluded values from overpass turbo
2013-09-26 13:44:01 -07:00
John Firebaugh bfef7962fe Add office to area list (fixes #1784) 2013-09-26 13:18:32 -07:00
John Firebaugh a32ce33238 Add Way#affix 2013-08-30 13:59:29 -07:00
John Firebaugh 0a23c395ed Cache GeoJSON transient 2013-08-26 15:20:32 -07:00
John Firebaugh 7215e91ff2 Ensure asGeoJSON returns winding orders expected by D3 2013-08-26 14:39:08 -07:00
John Firebaugh c14e2e600e Fix strokes sometimes being clipped as polygons
Fixes #1527.
2013-05-28 20:30:41 -07:00
John Firebaugh 2e4207f99b Cache geometry 2013-05-17 15:31:27 -07:00
John Firebaugh 6431fca8a3 Fix area caching (fixes #1485) 2013-05-14 16:52:02 -07:00
Ansis Brammanis 5ded5fca4e added support for oneway=1 and oneway=-1
fixes #1400
2013-05-01 11:10:02 -04:00
John Firebaugh f709a36333 Add power to area keys (#1338) 2013-04-20 12:25:17 -07:00
John Firebaugh 94e2c8d8d6 Prevent duplicate consecutive nodes (#1296) 2013-04-12 10:55:53 -04:00
John Firebaugh 05c659bdd7 Render oneway arrows for junction=roundabout (fixes #1255) 2013-04-05 12:27:36 -07:00
Ansis Brammanis 63edc30922 Revert "Use a temporary area tag for drawing. Fixes #1014"
This reverts commit 4184b503f9.
2013-03-18 14:02:21 -04:00
Tom MacWright 4184b503f9 Use a temporary area tag for drawing. Fixes #1014 2013-03-15 18:27:06 -04:00
John Firebaugh 3b3ee84a84 Specs for Way#areAdjacent 2013-03-12 16:22:30 -07:00
Ansis Brammanis 6129fbf4f5 prevent creation of ways with duplicate segments or repeated nodes 2013-03-11 16:00:24 -04:00
John Firebaugh 711b867b61 Render waterway=riverbank as area 2013-03-10 18:25:25 -07:00
John Firebaugh da37237955 Add man_made presets 2013-03-09 09:22:56 -08:00
Tom MacWright 0fafa340fe Start using d3 3.1.0
Update d3, use streams, d3.set, clip
Use clipping, fix side effects
2013-03-07 17:45:16 -05:00
John Firebaugh bf90c1ae93 Render circular place=* as an unfilled area
Basically, give it area label placement, but line
behavior otherwise.

Test case: #id=w169604918&map=19.46/41.41402/-70.94773
2013-03-06 17:37:18 -08:00
Ansis Brammanis 928cade41b oneway markers on rivers and streams 2013-03-06 17:51:31 -05:00
John Firebaugh dbe3020877 Remove outdated comment 2013-03-05 19:52:17 -08:00
John Firebaugh e9b2563ad8 Force natural=coastline not to be an area (fixes #900) 2013-03-05 17:39:14 -08:00
Ansis Brammanis eea85681be Fix tests 2013-02-28 14:24:51 -05:00
Ansis Brammanis baa9dc6e5e Render unclosed areas correctly 2013-02-28 14:08:03 -05:00
John Firebaugh e3d9d3a4c4 Refine Way#isArea
Closed ways that are multipolygon inners shouldn't be
rendered as areas just because they have a source=* tag,
for example.
2013-02-13 16:44:36 -08:00
Tom MacWright 61d7ec45b5 Banish function ( style 2013-02-12 16:35:47 -05:00
John Firebaugh 843baa11c0 graph -> core
This matches how it's described in ARCHITECTURE.md.
2013-02-09 15:18:54 -08:00