Commit Graph

521 Commits

Author SHA1 Message Date
Quincy Morgan
742147c62b Don't validate water areas or specific highway, waterway, or railway features 2019-01-29 13:31:02 -05:00
Quincy Morgan
b1e5b4f3ec Check to see if ways can be connected before offering that quick fix 2019-01-29 13:05:11 -05:00
Quincy Morgan
2051dc4ca8 Update id of remove generic name fix 2019-01-29 10:45:48 -05:00
Quincy Morgan
f89c18e65d Added quick fix for tag_suggest_area validation to remove the suggesting tags 2019-01-29 10:40:08 -05:00
Quincy Morgan
62ac471808 Improve message and add tooltip to tag_suggeset_area validation 2019-01-25 14:24:53 -05:00
Quincy Morgan
3886ce2ba8 Update issue tooltips and messages 2019-01-25 12:49:02 -05:00
Quincy Morgan
314e822a84 Merge master into validation 2019-01-25 10:03:40 -05:00
Quincy Morgan
b21dd1d5d6 Add tooltip and updated message to deprecated_tags validation issue
Add a quick fix to upgrade deprecated tags
Add more deprecated tag data
2019-01-24 14:09:12 -05:00
Quincy Morgan
33ae009936 Clarify wording of old_multipolygon issue and tooltip
Add quick fix for old_multipolygon issue
2019-01-24 11:01:41 -05:00
Quincy Morgan
981ed9ef8c Integrate the generic_name validation into the new validations framework 2019-01-24 09:28:59 -05:00
Bryan Housel
df87374042 Add {leftclick} icon to help section about adjusting imagery offset 2019-01-23 23:55:07 -05:00
Bryan Housel
d5e5d6b524 Fix typo: "OpenStreetmap" -> "OpenStreetMap" 2019-01-23 23:30:27 -05:00
Quincy Morgan
4389bd8741 Merge pull request #5723 from gaoxm/almostJunctAutoFix
add auto-fix for almost junction by creating connection nodes
2019-01-23 13:24:48 -05:00
Quincy Morgan
e69f2a0389 Merge branch 'master' into validation 2019-01-23 13:15:33 -05:00
Bryan Housel
7e69ab508f Add quotes around "to" way to match other error messages 2019-01-18 18:23:08 -05:00
Xiaoming Gao
aa5f1aec5b add auto-fix for almost junction by creating connection nodes 2019-01-16 20:02:25 -05:00
Yuri Astrakhan
3caf6eabed remove non local non en wiki links 2019-01-16 15:00:20 -05:00
Yuri Astrakhan
54b4a798b1 Localize language name 2019-01-16 14:35:47 -05:00
Yuri Astrakhan
2df519567d updated wiki link text 2019-01-16 14:09:22 -05:00
Quincy Morgan
1bfb9ac0c0 Updated almost junction issue message and tooltip to be better aligned with other issues
Added a quick fix for setting the almost junction node as noexit
2019-01-16 10:02:05 -05:00
Yuri Astrakhan
1127a34f94 Add wiki links from tag description
This feature requires P31 property to be present
in the data item. For an example, see
https://wiki.openstreetmap.org/wiki/Item:Q104#P31

Once the bot populates them in the data items,
it will automatically work for all existing keys/tags.
2019-01-15 20:07:45 -05:00
Quincy Morgan
21286467fa Merge branch 'master' into validation 2019-01-14 12:04:00 -05:00
Bryan Housel
67ef2bce1c Simplify and fix a few typos 2019-01-14 11:15:56 -05:00
Bryan Housel
fd23d13563 Distinguish between "This highway" and "highway" forms of error parts.
(closes #5703)
2019-01-14 10:59:45 -05:00
Quincy Morgan
11b2102761 Merge branch 'master' into validation
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
#	modules/ui/commit_warnings.js
#	modules/ui/entity_editor.js
#	modules/util/index.js
#	modules/util/util.js
#	modules/validations/index.js
#	modules/validations/many_deletions.js
#	modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Bryan Housel
ae8dffa43c Improve URL error messages 411, 412, 413 2019-01-10 21:35:13 -05:00
Bryan Housel
7f321abbaf Add links to the main error object in KeepRight error messages
re: https://github.com/openstreetmap/iD/issues/5679#issuecomment-452281850
2019-01-10 17:38:09 -05:00
Bryan Housel
9c190e83e9 Add quickLinks to preset editor, zoom to selected feature 2019-01-09 21:56:08 -05:00
Xiaoming Gao
ecacab3ffe add validation for almost junction
but avoid connect when the edge goes in parallel to the other road.
also added tests for the validation.
2019-01-08 15:44:55 -05:00
Bryan Housel
5f20218f1f Add validation warning for generic names
(closes #5590)
2019-01-08 02:15:28 -05:00
Bryan Housel
da4cb156a0 Fix missing parenthesis in error string 380 2019-01-05 01:15:01 -05:00
Bryan Housel
7986fcbfbf Merge branch 'keep-right_QA' 2019-01-04 21:37:19 -05:00
Bryan Housel
0582faff1d Convert KeepRight error 73 to regex
(re: https://github.com/openstreetmap/iD/pull/5201#discussion_r245349395 )
2019-01-04 20:27:22 -05:00
Bryan Housel
d0343c9fa7 Reintroduce some error localization, fix some nagging parse issues 2019-01-03 18:16:28 -05:00
Bryan Housel
35f8078f98 Reduce number of marker colors, increase contrast, tweak language 2019-01-03 15:30:36 -05:00
Bryan Housel
69ce5ee964 Remove user details and auth and adjust button texts for commenting
The user details and auth are not needed
because KeepRight accepts only anonymous updating
2019-01-03 00:07:55 -05:00
Bryan Housel
ee92758801 KeepRight only allows one anonymous comment per issue - simplify 2019-01-02 16:15:21 -05:00
Bryan Housel
9557c0204a Relax some more regex for tag parsing, (to support 'key=*')
Also implement parsing error 231 - layer conflict
2019-01-02 13:39:21 -05:00
Bryan Housel
2ec02f369f Simplify regex matching - goal is to have fewer, simpler rules 2019-01-02 11:46:13 -05:00
Bryan Housel
d54d5bfd89 Move title into keepright error header 2018-12-29 17:55:40 -05:00
Bryan Housel
192b4da9e6 Fix the strings I broke in 3785ffb15 2018-12-29 17:30:35 -05:00
Bryan Housel
3785ffb154 Simplify translation strings 2018-12-22 12:12:28 -05:00
Yuri Astrakhan
b2810105a5 Implement support for multilingual descriptions from wiki data items
* Takes data directly from the Wikibase data items (OSM Wiki)
     https://wiki.openstreetmap.org/wiki/OpenStreetMap:Data_Items
* Understands the difference in regions - e.g. will show different
  images depending on the local settings
* Perf: Single request will get both the tag and key description
2018-12-22 00:23:31 -05:00
Quincy Morgan
70d5529a58 Added initial implementation of quick fix for connecting crossing features (still has some bugs) 2018-12-21 17:39:20 -05:00
Quincy Morgan
d9c6bd1f39 Added specialized issue messages for the common types of way crossing issues
Fixed several linting issues involving crossing way validations
2018-12-21 14:45:20 -05:00
Quincy Morgan
c9350c632e Add issue fixes UI
Add two issue fixes for untagged feature
2018-12-21 12:31:33 -05:00
Bryan Housel
f7150004c0 Refactor things out of util with limited use, move more to service 2018-12-21 11:56:55 -05:00
Bryan Housel
4eb0e4b3a4 Remove more duplicate strings 2018-12-20 16:09:18 -05:00
Bryan Housel
6e1d6bcfda Drop legacy translation keys 2018-12-20 15:38:04 -05:00
Quincy Morgan
d58867df7c Add entity display label util function
Condense message and tooltip text for for the untagged feature issue
Use lighter border color for error issues
2018-12-20 14:04:15 -05:00