Commit Graph

1920 Commits

Author SHA1 Message Date
Thomas Hervey
cedf6955b5 added: notes and todos for keepRight 2018-12-19 13:45:34 -05:00
Thomas Hervey
ee00635cc4 updated: some error colors; fixed: error 320, 220 2018-12-19 13:45:15 -05:00
SilentSpike
1f7455fdad Add missing error types 73, 74 and 75 2018-12-19 13:45:15 -05:00
SilentSpike
9bd772748a Convert warnings to regex
These aren't shown in the layer currently, but for future use this
should work
2018-12-19 13:45:15 -05:00
SilentSpike
da23bf79a8 Fix parsing of error type 294 2018-12-19 13:45:15 -05:00
SilentSpike
005927dae3 Fix parsing of error type 211 2018-12-19 13:45:15 -05:00
SilentSpike
2b1e37ab78 Handle simple error descriptions explicitly
This adds a flag to the error schema to explicitly say whether to parse
the description with regex or not. Prevents us from having to escape
special characters in fixed strings and is a minor optimisation.
2018-12-19 13:45:15 -05:00
SilentSpike
e77d779173 Adhere to style guide for variables 2018-12-19 13:45:15 -05:00
SilentSpike
e0e48b7505 Fix parsing of error type 231 2018-12-19 13:45:15 -05:00
SilentSpike
a2fe431637 Add support for arbitrary number of details 2018-12-19 13:45:15 -05:00
SilentSpike
d054e9cf6b Convert all error message schema to regex 2018-12-19 13:45:15 -05:00
SilentSpike
1527bbb043 Fix missing and unnecessary semicolons 2018-12-19 13:45:15 -05:00
SilentSpike
424bebf099 Convert preliminary amount of errors to regex
This focuses on converting error types I found on the map for testing
(can confirm the code is working!) as well as the more problematic cases
from the old code to show that this approach can handle them easily.
2018-12-19 13:45:15 -05:00
SilentSpike
bb89827ee7 Use regex group capture to extract error details 2018-12-19 13:45:15 -05:00
Thomas Hervey
fbe3c94b01 updated: punctuation, some specialized QA error parsing 2018-12-19 13:45:14 -05:00
Thomas Hervey
84895834f7 updated: punctuation and missing descriptions 2018-12-19 13:45:14 -05:00
Thomas Hervey
d125c62c78 updated: variable and function names, html regex 2018-12-19 13:43:48 -05:00
Thomas Hervey
ed34d522ff updated: check entity type from second word as well 2018-12-19 13:43:48 -05:00
Thomas Hervey
e0d5391f1b added: entity links within descriptions 2018-12-19 13:43:48 -05:00
Thomas Hervey
d095de08fe updated comment UI, added stub for POST; TODO: finish links & POST 2018-12-19 13:43:48 -05:00
Thomas Hervey
b5a316df48 fixed: svg icon placement 2018-12-19 13:43:08 -05:00
Thomas Hervey
1335549ad3 cleaned map data UI; commented sub-layer filtering 2018-12-19 13:43:08 -05:00
Thomas Hervey
805dd394c9 added link for object in header 2018-12-19 13:40:56 -05:00
Thomas Hervey
cbcdfc075c small UI change to header 2018-12-19 13:40:56 -05:00
Thomas Hervey
6dbea57721 added back supported 2018-12-19 13:40:56 -05:00
Thomas Hervey
3e7146c63f WIP: menu with sub-layer buttons; TODO: bug fixes, ui updates, wiring buttons 2018-12-19 13:40:56 -05:00
Thomas Hervey
18278371aa WIP: identifying variables in errors 2018-12-19 13:38:40 -05:00
Thomas Hervey
31f35b0389 added basics to sidebar 2018-12-19 13:35:26 -05:00
Thomas Hervey
75cff00a2a displaying keep right (currently as notes) 2018-12-19 13:18:37 -05:00
Thomas Hervey
b96965568f WIP: added schemas for errors and warnings 2018-12-19 13:13:30 -05:00
Thomas Hervey
b3cffd7833 added simple keepRight button under photoItems 2018-12-19 13:12:49 -05:00
Bryan Housel
81b5fc788e Merge pull request #5629 from openstreetmap/5587
5587 - make geolocation show geolocation
2018-12-19 12:14:36 -05:00
Bryan Housel
7db6133666 Merge pull request #5583 from quincylvania/field-prerequisite-tags
Mechanism for displaying fields conditionally based on tags
2018-12-19 12:08:15 -05:00
Max Grossman
399e7781c1 remove dispatched changes and re-order layers
ref #5587
2018-12-19 11:54:39 -05:00
Max Grossman
3755951009 remove unused vars
ref #5587
2018-12-19 11:24:26 -05:00
Max Grossman
83c0843e57 just call accuracy function when setting r attr
ref #5587
2018-12-19 11:23:19 -05:00
Max Grossman
b9ddfca152 implement point/puck geolocation
ref #5587
2018-12-19 11:06:41 -05:00
Quincy Morgan
6e1dd34447 Fixed an issue where a new container would be added in the Map Data pane every time a section was re-expanded 2018-12-18 15:55:50 -05:00
Bryan Housel
5a2049b421 Drop extra whitespace, make sure service exists before using it 2018-12-18 15:38:53 -05:00
Bryan Housel
814c72fe42 Merge branch 'remote-presets' of https://github.com/radiant-maxar/iD into radiant-maxar-remote-presets 2018-12-18 15:15:11 -05:00
Max Grossman
b7f0d86da9 working on geolocate layer
ref #5587
2018-12-18 14:19:36 -05:00
Max Grossman
1471b55122 lint!
ref #5614
2018-12-18 12:02:26 -05:00
Max Grossman
02261c96e0 adding svg layer...
ref #5587
2018-12-18 12:01:22 -05:00
Max Grossman
ae9d43b0ac remove double class
ref #5614
2018-12-18 11:16:37 -05:00
Max Grossman
18c021b5d5 add css
ref #5614
2018-12-18 11:09:26 -05:00
Max Grossman
0328e4f9da add close button w/out css
ref #5614
2018-12-18 11:00:40 -05:00
Max Grossman
6ba8bacb75 use severity in test 2018-12-18 10:27:15 -05:00
Quincy Morgan
7e9082b9ff Merge branch 'master' into field-prerequisite-tags 2018-12-18 09:33:46 -05:00
Max Grossman
64f2d913e8 remove unused entities from test 2018-12-17 17:39:47 -05:00
Max Grossman
8f33a85a12 make collection.index function to handle failing tests 2018-12-17 17:16:10 -05:00