Commit Graph

16 Commits

Author SHA1 Message Date
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
35049ab40a Replace getErrors/getWarnings with getIssues/getIssuesBySeverity
The idea here is that the validator will now hold onto lots of issues,
but the calling code will only want some small subset of them
(edited/everything) (inview/everywhere) and can pass these as options
so that we don't need filtering code spread throughtout the app.
2019-04-11 14:48:23 -04:00
Quincy Morgan
ee6c06d1d5 Fix an issue where the commit sidebar would not show all warning and errors
Remove use of lodash from commit_warnings.js
2019-02-21 15:33:14 -05:00
Quincy Morgan
46f3cea33a Reorganize validation code
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
11b2102761 Merge branch 'master' into validation
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
#	modules/ui/commit_warnings.js
#	modules/ui/entity_editor.js
#	modules/util/index.js
#	modules/util/util.js
#	modules/validations/index.js
#	modules/validations/many_deletions.js
#	modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Bryan Housel
5f20218f1f Add validation warning for generic names
(closes #5590)
2019-01-08 02:15:28 -05:00
Quincy Morgan
59b0252b0e Fixed several linting errors 2018-12-19 13:22:48 -05:00
Quincy Morgan
ff95e6a337 Merge branch 'validationIssueDataModel' into validation 2018-12-19 10:59:45 -05:00
Quincy Morgan
903cb63efe Renamed validations to issues in relevant places
Made the issue pane get the issues from the issue manager rather than validating itself
2018-12-19 10:41:58 -05:00
Xiaoming Gao
07a53fe6ea Extend data model for validation issues
Add the Issues pane

1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
  (1) add a severity level field (useful for identify save-blocking issues later)
  (2) replace single entity with an array of entities (useful for issues involving multiple entities)
  (3) add a coordinates field for highlighting the location of the issue on the map
  (4) add a fixes field for possible automatic fixes

3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
Andrew Wong
30f25c6e8d added IssueManager
- IssueManager performs validation on the current graph and also
   stores the issues and notifies listeners when the issues changed
2018-12-18 17:52:23 -05:00
Max Grossman
6ba8bacb75 use severity in test 2018-12-18 10:27:15 -05:00
Max Grossman
3a0f8ddd09 infer geometries
ref #remote-presets
2018-08-08 13:21:35 -04:00
Max Grossman
b93444de75 working on isArea-ish equivalent for mapcss selector objects
ref #remote-presets
2018-08-02 18:03:13 -04:00
Bryan Housel
470835b38f Extract all graphics from iD sprite, reassemble with svg-sprite
All iD sprite graphics are now prefixed with `iD-`
Also includes support for sending the preset logos to taginfo
2018-06-08 16:06:46 -04:00
Bryan Housel
ba3f823141 Split out commitWarnings and commitChanges sections into smaller modules 2017-08-15 01:50:52 -04:00