Commit Graph

233 Commits

Author SHA1 Message Date
Quincy Morgan
949b57d118 Ensure that relations are called before ways when categorizing fetched features (close #6277) 2019-05-01 11:33:39 -07:00
Quincy Morgan
907df1c10e Include relation members when forcing relations visible in all cases, not just selection (re: 6eeaf94076) 2019-05-01 11:08:52 -07:00
Bryan Housel
fceb1a86f7 Merge pull request #6245 from openstreetmap/d3-v5
d3 v5
2019-04-29 15:46:08 -04:00
Bryan Housel
b99be67169 When calling an errback from a Promise.catch, pass err.message 2019-04-25 21:58:36 -04:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
e6bc9d9e8f Swap out d3-request, swap in d3-fetch 2019-04-24 16:25:25 -04:00
Bryan Housel
7dce4bb161 Avoid asking DOM if layers are classed disabled in map.editable
`map.editable` is hot code because it's called frequently by the `isHiddenX`
tests in `features.js`.  It's much more efficient to just ask the osm layer
whether it is enabled, than to use D3 to find that layer in the DOM and check
whether it's classed `disabled`
2019-04-22 22:12:42 -04:00
Bryan Housel
51c1088c1b Merge branch 'master' into validation_and_change_perf 2019-04-19 15:18:23 -04:00
Bryan Housel
c4209515a5 Only consider hiding features matched to a rule
(Fixes accidental hiding of vertices)
2019-04-18 19:26:17 -04:00
Quincy Morgan
84b7e08bf8 Don't select the previously-edited node when undoing/redoing (re: #5831) 2019-04-16 14:21:15 -07:00
Bryan Housel
f6708fd84c Hide feature if _all_ rules hidden (was: if _any_ rule hidden)
This matters as we start to match more rules for hybrid features like rail
platforms, which now match both path and rail.  We want to show them unless the
user has hidden all the rules that they match.

Also this changes the test code slightly to actually test rule matching.
Before it was really just testing hiding.
2019-04-15 10:20:58 -04:00
Bryan Housel
0ec9cd91dc Warm up the feature matching cache upon merging fetched data
Also rename `_features` to `_rules`, since we use the word features too much
2019-04-12 12:25:37 -04:00
Bryan Housel
0dd262d1dd Don't dispatch 'change' on history.merged, dispatch 'merge' only
Change performs an expensive immediate redraw, and merge can schedule
a redraw for later.
2019-04-12 09:56:18 -04:00
Bryan Housel
dda810683e Adjust matchscore, feature filters to boost physical tags over boundary
(closes #6162)
2019-04-11 21:26:53 -04:00
Bryan Housel
2b050549eb Avoid reflow in minimap by hardcoding its dimensions 2019-04-11 21:05:04 -04:00
Bryan Housel
87e3b928d0 Reduce drawing during history changes
(closes #6086)
2019-04-03 23:26:26 -04:00
Bryan Housel
d5abe468b9 Remove rest of the lodash iterators: map, reduce, forEach
(re: #6087)
2019-03-29 15:14:21 -04:00
Quincy Morgan
6fb8fcb86b Make map pan to the location of the undone edit when undoing instead of the location of the edit before that (close #5831) 2019-03-27 18:02:21 -04:00
Bryan Housel
3d80e6505f Remove lodash chunk, groupBy
(re: #6087)
2019-03-27 16:18:41 -04:00
Bryan Housel
5e1ff74199 Replace lodash difference, intersects, union
(re: 6087)
2019-03-27 01:22:11 -04:00
Bryan Housel
7e6f68a1b2 Remove lodash some
(re: #6087)
2019-03-23 00:07:52 -04:00
Bryan Housel
0e90167513 Remove lodash clone
(re: #6087)
2019-03-22 23:18:25 -04:00
Bryan Housel
ff4f8f005f Remove lodash find and findIndex
(re: #6087)
2019-03-22 17:31:41 -04:00
Bryan Housel
11bfeaabfc Add browser-polyfills, remove lodash assign, compact, values
(re: #6087)
2019-03-22 17:14:41 -04:00
Quincy Morgan
7d0080a642 Persist the photo overlay layers via the URL query string (re: #5813) 2019-03-14 16:48:08 -04:00
Quincy Morgan
c65a4d038e Add photo overlay filter options for hiding flat and pano photos (close #5433) 2019-03-14 14:24:21 -04:00
Bryan Housel
ebddfc896a Don't render background() when adding map to initial #map div
This was triggering an unnecessary render at zoom 2
right before the map was properly centerzoomed
2019-03-06 21:51:02 -05:00
Bryan Housel
0a1e497836 Ignore errors from Bing ImageryProviders 2019-03-06 17:32:05 -05:00
Quincy Morgan
2d974caed1 Fix an issue where preset buttons would always be disabled if Other Features were hidden (close #5934) 2019-02-25 10:27:06 -05:00
Quincy Morgan
82f6bd73ae Account for all tags added upon choosing a preset, not just those in the preset's tags property 2019-02-12 15:16:02 -05:00
Quincy Morgan
2efe2adec9 Restore previous behavior of features hidden and autoHidden but accounting for 0 count features 2019-02-12 15:05:02 -05:00
Quincy Morgan
9007ccb8fd Disable preset buttons for hidden layers 2019-02-12 14:43:04 -05:00
Quincy Morgan
19e262643d Fix issue where "other" ways were not sorted into the "other" category for hiding purposes 2019-02-11 13:38:37 -05:00
Quincy Morgan
e1da28bcd6 Hide lines that are members of boundary relations when boundaries are hidden (close #5601) 2019-02-11 13:22:20 -05:00
Bryan Housel
ba44c80076 Force visible any entities related to a selected error
(closes #5880)
2019-02-10 23:29:49 -05:00
Minh Nguyễn
9e3d49efb7 Replace wkid/w/s/n/e in WMS URL templates 2019-01-19 15:42:22 -08:00
Bryan Housel
2df39c1dc7 Escape all .s in imagery identifiers, not just the first one
(closes #5737)
2019-01-19 10:53:09 -05:00
Bryan Housel
a9ac1bda97 Fix issues causing mode/undo/save buttons to be missing disabled style 2019-01-17 00:06:57 -05:00
Bryan Housel
3fe6c0dbe7 Support more eased transitions, cleanup code
(re: #3967, #5169, #5407)
2019-01-16 13:42:32 -05:00
Bryan Housel
91bfac5861 Add map.centerZoomEase and simplify internal center/zoom code
(closes #3967)
2019-01-16 01:31:26 -05:00
Bryan Housel
68be75af09 Assumption about mozInputSource = 1 was incorrect
Removing this conditional allows 2 finger panning on Firefox
2019-01-15 14:46:23 -05:00
Bryan Housel
9c190e83e9 Add quickLinks to preset editor, zoom to selected feature 2019-01-09 21:56:08 -05:00
Bryan Housel
cd9203975d Use touch targets for notes, fix a few bugs with note dragging
(closes #5213)
2019-01-04 15:48:39 -05:00
Bryan Housel
2deadd5d6c Fix merge issues 2018-12-19 17:12:06 -05:00
Thomas Hervey
31f35b0389 added basics to sidebar 2018-12-19 13:35:26 -05:00
Bryan Housel
d28b269b4c Speed up the scrolling on Firefox Linux too
(re: #5512)

This just changes
`detected.os === 'win'`  to  `detected.os !== 'mac'`
2018-12-12 15:45:55 -05:00
Bryan Housel
13b1a9a629 If imagery becomes invalid, remove it from imagery_used
(closes #4827)
2018-12-11 17:49:15 -05:00
Bryan Housel
577e0c6503 Don't add "None" to imagery_used tag when other imagery was used
(closes #5565)
2018-12-11 16:37:52 -05:00
Bryan Housel
4f8f45ec52 Fix issues with slow scrolling and improper panning on windows
(closes #5512)
2018-11-30 22:57:30 -05:00
Quincy Morgan
d6ea64241b Trackpad scroll-to-zoom while holding Shift or Option/Alt 2018-11-21 20:55:30 -05:00