Quincy Morgan
3fad3513c1
Don't zoom to the feature and remove hover-highlighting upon clicking the issue fix button in the issues pane
2019-04-26 16:05:10 -07:00
Quincy Morgan
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
Bryan Housel
a37ce90af7
Move "Fix All" from bottom of list to top
2019-04-23 17:42:14 -04:00
Quincy Morgan
4948474118
Set the default validation filters to be My Edits / Everywhere (re: #6223 )
2019-04-23 10:34:10 -07:00
Bryan Housel
7e04175559
Add Enable All / Disable All validation rules links
...
(closes #5986 )
2019-04-23 13:01:15 -04:00
Bryan Housel
bbf4495f5c
pacify eslint
2019-04-19 23:44:49 -04:00
Bryan Housel
51c1088c1b
Merge branch 'master' into validation_and_change_perf
2019-04-19 15:18:23 -04:00
Bryan Housel
2ebbb68604
Restore tooltips on rule checkboxes, separate 'tip' and 'reference'
...
Reference will show on clicking info button, and can contain more
useful information than a tooltip can.
2019-04-19 13:24:55 -04:00
Bryan Housel
a55b4387fe
Make sure the notification badge starts out hidden
2019-04-18 19:06:23 -04:00
Bryan Housel
7c8a6eac9d
Reintroduce disabled rules
...
- They still run, but results are excluded from lists
- Also make sure to revalidate/dispatch/update when toggling rules
2019-04-18 17:05:33 -04:00
Bryan Housel
9c4881cade
Change autofix to accept arguments to perform, implement "fix all"
2019-04-17 17:51:29 -04:00
Bryan Housel
01d2e3eaf3
Replace validator tooltip with reference function, add tag diff
2019-04-16 17:07:53 -04:00
Bryan Housel
8afd8887cf
Restyle much of the issues and entity issues - avoid tooltips
2019-04-16 12:33:48 -04:00
Quincy Morgan
6bdf6c5127
Fix minimap position ( close #6167 )
...
Flexbox panes and info panels to prevent overlap (close #4733 )
2019-04-15 11:50:54 -07:00
Bryan Housel
5a0f21fa7a
Add ability for a fix to be auto, and add auto fix buttons
...
This also changes some of the list items that were previously buttons to divs,
since we can't nest buttons.
2019-04-13 10:50:47 -04:00
Bryan Housel
ce89d7359b
Sort issues list by dist from the map center, cutoff at 1000 items
2019-04-12 14:26:05 -04:00
Bryan Housel
96c277f46d
Simplify issue-options css
2019-04-11 14:59:32 -04:00
Bryan Housel
35049ab40a
Replace getErrors/getWarnings with getIssues/getIssuesBySeverity
...
The idea here is that the validator will now hold onto lots of issues,
but the calling code will only want some small subset of them
(edited/everything) (inview/everywhere) and can pass these as options
so that we don't need filtering code spread throughtout the app.
2019-04-11 14:48:23 -04:00
Bryan Housel
4c563f4edf
Add validation options
...
Check: [] My Edits [] Everything
Where: [] In View [] Everywhere
2019-04-11 11:55:17 -04:00
Bryan Housel
e377270372
WIP: introduce validatedGraph, try on mode change not history change
2019-04-06 13:39:19 -04:00
Bryan Housel
1bcc0f613c
WIP: fix caches, replace id() function with plain id property
2019-04-05 17:41:04 -04:00
Bryan Housel
8b1c0551cc
WIP: understand state held by the validator, avoid translations
...
- Make sure all state variables prefixed with `_`
- Add explicit `init`/`reset` methods
(graph/entity refs should never persist through a save to OSM)
- Thinking of how best cache validation results
2019-04-05 09:28:36 -04:00
Quincy Morgan
6aa1f86dfb
Add warning for multipolygon members with no set role ( close #5851 )
2019-02-25 17:46:50 -05:00
Quincy Morgan
b8ac9a7de3
Add toggle-able list of rules to the Issues pane ( close #5979 )
...
Toggling a rule off prevents the validation from running
2019-02-25 15:31:05 -05:00
Quincy Morgan
aff86979a6
Better pane display at narrow window widths ( close #5890 )
2019-02-20 13:47:11 -05:00
Quincy Morgan
31eb837596
Fix issue where fixes would not expand when clicking an issue
...
Rename issue label class to messages
Remove fix list animation
2019-02-15 13:40:45 -05:00
Quincy Morgan
b57e5a75b8
Tweak issue pane icon badge
2019-02-15 12:19:48 -05:00
Bryan Housel
6a560861b2
Add notification badge to Issue pane icon
2019-02-13 16:56:17 -05:00
Bryan Housel
c292a32a66
Better message padding, remove double tooltip
2019-02-13 13:47:00 -05:00
Bryan Housel
448fe498bd
Only recenter view if necessary, select after delay, fix maprules type
2019-02-12 17:25:54 -05:00
Bryan Housel
81bd734849
WIP uiEntityIssues cleanups, simplify
...
fixes are still not being applied properly
2019-02-11 20:44:02 -05:00
Bryan Housel
f4ccd8a3dc
Update issue text/icon on update selection
2019-02-11 16:22:24 -05:00
Bryan Housel
a5ffec5665
utilHighlightEntities accept an array instead of calling it in a loop
2019-02-11 12:40:23 -05:00
Quincy Morgan
149e1b3e4d
Removed unused string
2019-02-11 11:41:18 -05:00
Quincy Morgan
83f8cd97f6
Add feature highlighting when hovering over their corresponding issues
2019-02-11 09:45:33 -05:00
Quincy Morgan
ca8c91563b
Add issue count to section title in entity editor
...
Remove redundant string
2019-02-04 16:48:54 -05:00
Quincy Morgan
bfb5285dc9
Fix tests and lint warnings
2019-02-04 13:34:27 -05:00
Quincy Morgan
190fc4f434
Add message to the issues pane for when there are no issues
2019-02-04 12:06:25 -05:00
Quincy Morgan
977e667453
Remove non-functional issue options from UI
2019-02-04 11:15:05 -05:00
Quincy Morgan
2677a88df4
Zoom to ways and relations upon clicking on their issues in the issues pane
2019-02-04 10:27:35 -05:00
Quincy Morgan
6514f645d1
Add error and warning count to the list titles
...
Hide error and warnings lists when there are no errors or warnings
2019-02-04 09:28:01 -05:00
Quincy Morgan
251d83f86c
Show warnings and errors in different lists in the issues pane
2019-02-01 16:38:48 -05:00
Quincy Morgan
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
77c4d41855
Restore many deletions warning with tooltip and nicer message
...
Add tooltips back to issues pane list
Fix crash when restoring without having loaded the edited area
2019-01-30 15:48:06 -05:00
Quincy Morgan
94c8f9f9f7
Update text for features to edit
2019-01-29 14:48:18 -05:00
Quincy Morgan
80c7aedb39
Fix bug with issues pane
2019-01-29 11:59:01 -05:00
Quincy Morgan
33ae009936
Clarify wording of old_multipolygon issue and tooltip
...
Add quick fix for old_multipolygon issue
2019-01-24 11:01:41 -05:00
Quincy Morgan
01e2370cbd
Add background color to the issue pane list
2019-01-24 08:37:46 -05:00
Quincy Morgan
7b288ef95d
Add basic zoom-to-clicked-issue behavior
2019-01-23 15:25:55 -05:00
Quincy Morgan
4f1cb0dc46
Made the entity issues UI update when the issues reload
2019-01-14 12:33:32 -05:00