Commit Graph

90 Commits

Author SHA1 Message Date
John Firebaugh
6d506ec6d4 Fix mutation of childNodes array 2013-06-18 14:21:07 -07:00
John Firebaugh
ddd9e4e8cc Make iD.actions.Join agnostic to selection order
This is accomplished by reusing iD.geo.joinMemberWays,
which was refactored, generalized, and renamed to joinWays.
2013-06-18 12:19:53 -07:00
John Firebaugh
3861879f62 Remove Connection#user and always use #userDetails
Because the embedded iD does not show the account
UI, Connection#userDetails was not being called, so
the commit UI didn't show the user name and image.

Fixes #1464
2013-06-14 13:06:13 -07:00
John Firebaugh
7ec1222402 Try to insert relation members at a sensible index (#1539) 2013-06-05 16:00:53 -07:00
John Firebaugh
33cf029d43 Extract and refactor iD.geo.joinMemberWays 2013-06-05 16:00:12 -07:00
John Firebaugh
c14e2e600e Fix strokes sometimes being clipped as polygons
Fixes #1527.
2013-05-28 20:30:41 -07:00
John Firebaugh
1e8052182d Merge pull request #1247 from systemed/create-multipolygon
ability to create multipolygons
2013-05-28 16:56:22 -07:00
John Firebaugh
16e5f5e2ce Extract Entity#isUsed 2013-05-24 15:46:05 -07:00
John Firebaugh
1276672783 Add iD.actions.DeleteMember 2013-05-22 17:37:26 -07:00
John Firebaugh
affdc987e4 Rename removeMember -> removeMembersWithID 2013-05-22 17:28:51 -07:00
John Firebaugh
bf21744077 Only draw intersections for {high,water,rail,aero}way lines
Fixes #1471
2013-05-20 17:16:36 -07:00
John Firebaugh
2631accdb3 Fix load event argument 2013-05-20 16:33:45 -07:00
John Firebaugh
1db99586c4 Render only new features when a data tile is loaded 2013-05-20 12:05:31 -07:00
John Firebaugh
d2e775ac65 Use correct changesets URL for dev 2013-05-19 20:11:41 -07:00
John Firebaugh
6c849baad6 Revert "Cache centroid"
Causes misplaced labels, suspect due to rounding artifacts.

This reverts commit 5344bdea26.
2013-05-18 09:20:58 -07:00
John Firebaugh
6045ffcfbe Comment why _childNodes needn't be updated 2013-05-18 09:20:58 -07:00
John Firebaugh
293bb23876 Graph#rebase must invalidate transients 2013-05-18 09:20:57 -07:00
John Firebaugh
5344bdea26 Cache centroid 2013-05-17 15:31:27 -07:00
John Firebaugh
2e4207f99b Cache geometry 2013-05-17 15:31:27 -07:00
John Firebaugh
6075367015 Don't store unused parts of OSM XML 2013-05-14 20:47:58 -07:00
John Firebaugh
6431fca8a3 Fix area caching (fixes #1485) 2013-05-14 16:52:02 -07:00
John Firebaugh
51cb9af907 Cache area 2013-05-13 22:46:29 -07:00
John Firebaugh
544c493eba Cache isIntersection 2013-05-13 22:40:43 -07:00
John Firebaugh
6060e886cb Reduce calls to iD.svg.TagClasses
For fills and shadows, style changes can happen only when
a new version of the feature is produced. If we include a
version number in the key, we need only call TagClasses on
the enter selection.

We cannot apply the same optimization for strokes, since
stroke style can depend on the tags of parent relations
as well.
2013-05-13 09:37:48 -07:00
John Firebaugh
0ae54abdcc Extract iD.actions.DiscardTags 2013-05-13 09:26:41 -07:00
Ansis Brammanis
5ded5fca4e added support for oneway=1 and oneway=-1
fixes #1400
2013-05-01 11:10:02 -04:00
John Firebaugh
f1d32dd65e Fix Uncaught TypeError: Cannot call method 'getAttribute' of undefined
https://app.getsentry.com/id/id/group/5151824/
2013-04-25 12:16:32 -07:00
Ansis Brammanis
a0e8292067 fix tree bug where removes would fail
the width or height of the rtree rectangle created by extentRectangle
would be negative. These rectangles insert ok, and are found by search,
but they cannot be removed.

issue #1370
2013-04-24 19:27:43 -04:00
John Firebaugh
c50c3121d8 Make Graph#entity strict
Use Graph#hasEntity for the previous behavior.
2013-04-24 09:27:37 -07:00
John Firebaugh
781f540b3c Add diagnostic for common sentry errors 2013-04-23 11:29:00 -07:00
John Firebaugh
765fedef15 Omit changeset comment if empty (fixes #1360) 2013-04-22 12:09:22 -07:00
John Firebaugh
20833c139c Avoid _.bind
Seeing some weird object retention behavior with it.
2013-04-21 16:41:59 -07:00
John Firebaugh
f709a36333 Add power to area keys (#1338) 2013-04-20 12:25:17 -07:00
John Firebaugh
c8dcba31ad Auto-zoom to entity specified by id param 2013-04-18 14:24:10 -07:00
Ansis Brammanis
9983c0be43 make difference calculation stricter
Changed entities with the exact same properties no longer get counted as
modified.

issue #1287
2013-04-18 13:58:22 -04:00
John Firebaugh
ab56cc5207 Clean up how OAuth keys are handled
Connection defaults to osm.org URL and keys for the simple
case. Customization is done via connection.switch().

Externalize SourceSwitch's use of iD.data.keys.
2013-04-17 17:43:25 -07:00
John Firebaugh
dca9bec450 Move Connection to core 2013-04-17 17:35:34 -07:00
John Firebaugh
94e2c8d8d6 Prevent duplicate consecutive nodes (#1296) 2013-04-12 10:55:53 -04:00
John Firebaugh
05c659bdd7 Render oneway arrows for junction=roundabout (fixes #1255) 2013-04-05 12:27:36 -07:00
Ansis Brammanis
05e63c2e17 expose relation.joinMemberWays 2013-04-03 15:53:02 -04:00
Ansis Brammanis
0de68c9e4a handle extending multipolygons with multiway rings 2013-04-03 13:18:48 -04:00
John Firebaugh
7100054707 Use preset names in commit dialog 2013-04-01 08:33:07 -07:00
Ansis Brammanis
0435c4793c better positioned walkthrough tooltips 2013-03-28 11:58:56 -04:00
John Firebaugh
f7fb12be76 Fix #1120, inconsistent undo for line/area drawing
Gulp!
2013-03-27 16:25:10 -07:00
Ansis Brammanis
2b4e260953 walkthrough now runnable in the middle of editing
history.toJSON and .fromJSON are now split out of.
history.save and .restore.
2013-03-27 11:52:50 -04:00
Ansis Brammanis
63edc30922 Revert "Use a temporary area tag for drawing. Fixes #1014"
This reverts commit 4184b503f9.
2013-03-18 14:02:21 -04:00
Tom MacWright
4184b503f9 Use a temporary area tag for drawing. Fixes #1014 2013-03-15 18:27:06 -04:00
John Firebaugh
66e1bdb47d Show tag editor for untagged entities that aren't new
Fixes #991.
2013-03-14 15:59:56 -07:00
John Firebaugh
4720a84d38 No-op a null tag merge
Reduces unnecessary node churn in Connect action.
2013-03-12 16:26:40 -07:00
John Firebaugh
3b3ee84a84 Specs for Way#areAdjacent 2013-03-12 16:22:30 -07:00