Commit Graph

2127 Commits

Author SHA1 Message Date
SilentSpike
9fca611ec1 Add support for even more Osmose error types
- Conflicting tags
- Orthographic errors (excess whitespace and all capital names)
- Deprecated tagging
- Bad use of the "area" tag
2020-02-03 23:20:43 +00:00
SilentSpike
a53f1c0f67 Add support for Osmose unnecessary tag error type 2020-02-03 23:20:42 +00:00
SilentSpike
c13eb15691 Add support for more Osmose error types
- Unconnected level crossings
- Unconnected highway features/barries
- Unexpected punctuation/symbols in tag values
- Unbalanced parentheses/quotes in name values
- Invalid date formats
- Access tagging that permits all transport modes
- Elements with a "name" tag and no main tagging
- Relations missing a "type" value
2020-02-03 23:20:42 +00:00
SilentSpike
cc3039033f Support more subtypes of osmose error type 8300 2020-02-03 23:20:41 +00:00
SilentSpike
896ed762e0 Fix silent failure for some Osmose error types
When I added special handling for mapillary errors the code was trying
to access translation strings nested under the error category (which
doesn't exist for all error types). This code is now moved into it's own
function so that variable hoisting doesn't run it for non-applicable
error types and prevent them from working.

- Also adds support for error type 3040 (bad tag value)
- Updated the Osmose sidebar UI title
2020-02-03 23:20:41 +00:00
SilentSpike
d4723ec9e2 Read icons from qa_errors.json when building data
Also adds support for the following error types:
- Objects mapped as both node/area or way/area
- Power lines that lead to nowhere
- Extra nodes in power lines (which should only go from support to
support to endpoint)
- Power line supports with no power lines
2020-02-03 23:20:30 +00:00
SilentSpike
5afdfc527b Add support for more Osmose error types
- Missing parking access
- Malformed opening hours tagging
- Objects detected by Mapillary that aren't mapped
- Traffic sign information detected by Mapillary that isn't mapped

Mapillary errors add example code for special error type handling as
they don't need to request further details and can use piecewise
translation strings
2020-02-03 23:01:03 +00:00
SilentSpike
b24b041335 Add Osmose issue detail fetching for UI
Must fetch details per-issue to get the associated OSM elements for
highlighting and use in the error description.

Also fixes URL for error closure.
2020-02-03 23:01:03 +00:00
SilentSpike
680fdb6b54 Allow Osmose errors to use category for UI strings
Some error types don't require unique strings and can share common
strings among the category. This makes that possible as well as adding
support for some other types of error for demonstrative purposes.
2020-02-03 23:01:02 +00:00
SilentSpike
09e7b23665 Add Osmose issues UI and filtering
Filters out errors not present in the data .json file to enable
selective support since Osmose has a wide variety of errors which may be
too advanced for iD.

Also added processing for the elements associated with an error for
forced visibility and highlighting.
2020-02-03 23:01:01 +00:00
SilentSpike
e11d97b38c Add Osmose QA layer and service
Initial implementation - need to add UI for the errors and correctly set
up support for the desired error types provided by osmose.
2020-02-03 23:01:01 +00:00
Quincy Morgan
3370bea588 Add derived data for #7289 2020-02-03 13:58:12 -05:00
Quincy Morgan
4627a158f8 Merge pull request #7323 from animesh-007/7296
added new preset, fixes #7296
2020-02-03 08:57:02 -05:00
animesh-007
54fa13be7e added new preset 2020-02-03 17:43:52 +05:30
Bryan Housel
ab3b731d66 Merge pull request #7310 from animesh-007/7274-new
Added new preset, fixes #7274
2020-01-31 15:21:01 -05:00
Quincy Morgan
208f3d5d1c Add Incline field to rail presets
Use field inheritance for rail presets
2020-01-31 14:58:12 -05:00
animesh-007
813afc073e added new feature 2020-02-01 01:11:57 +05:30
Quincy Morgan
04bd811fde Merge pull request #7306 from openstreetmap/multiselection-field-editing
Enable field editing in multiselection
2020-01-31 14:36:42 -05:00
animesh-007
fb52e2d5b5 added new feature 2020-02-01 00:58:50 +05:30
Quincy Morgan
2783408fc3 Add tooltips to mixed values in semicombo, multicombo, and radio fields 2020-01-31 14:07:16 -05:00
Quincy Morgan
5cd65efd6e Update generic aerialway and aeroway preset names to include "Feature"
Add icon to generic power preset
2020-01-31 10:07:55 -05:00
Bryan Housel
6e5cb45c17 Don't bundle the imagery anymore, fetch from dist/data at runtime
(re: #4994)
2020-01-30 17:10:41 -05:00
Bryan Housel
e19bcb77d5 Require init() call before coreContext starts doing things
(closes #7304)
2020-01-29 19:27:12 -05:00
Bryan Housel
567eeac587 Make several data external instead of bundled:
Also dist/data/* contains minified files now

These are now external and will fetch as needed:
-export { dataAddressFormats } from './address-formats.json';
-export { dataDeprecated } from './deprecated.json';
-export { dataDiscarded } from './discarded.json';
-export { dataLanguages } from './languages.json';
-export { dataPhoneFormats } from './phone-formats.json';
-export { dataShortcuts } from './shortcuts.json';
-export { dataTerritoryLanguages } from './territory-languages.json';
2020-01-28 22:21:31 -05:00
Bryan Housel
31e007fc83 Create a data loader and move the intro graph into dist/data
(re: #3403)
2020-01-27 17:15:00 -05:00
Quincy Morgan
5640f37bb6 Add terms to car repair shop 2020-01-24 09:22:57 -05:00
Quincy Morgan
69df630f21 Support multiple values in the beauty field (close #7215) 2020-01-24 09:20:23 -05:00
Quincy Morgan
046fb1d0bf Add derived data for prior merge (re: #7284) 2020-01-23 08:59:42 -05:00
Quincy Morgan
fd2b97331c Add label to "change feature type" button in inspector and make it a collapsible section (close #6811) 2020-01-22 09:19:54 -05:00
Bryan Housel
6a4a1d57a7 Make a separate build:legacy target that runs buble
- `iD.js` for most browsers, `iD.legacy.js` for IE11/PhantomJS
- Skip buble plugin during normal development for faster builds
2020-01-21 15:25:10 -05:00
Quincy Morgan
6bb2997306 Enable changing the preset of multiple selected features (re: #7276)
Fix issue where preset tag reference wouldn't load
Change "Change feature" tooltip to more accurate "Change feature type"
2020-01-21 15:19:51 -05:00
Bryan Housel
c548d0e216 Add ability to dynamically load a different bundle in IE11 2020-01-21 13:19:06 -05:00
Quincy Morgan
11035127a3 Rename "Adjust imagery offset" section to "Imagery Offset" 2020-01-20 13:12:46 -05:00
Quincy Morgan
019e9a956c Remove unused strings 2020-01-20 12:15:13 -05:00
Quincy Morgan
667406c6e0 Remove "all" from the inspector section names 2020-01-20 11:51:00 -05:00
Quincy Morgan
48bda8ba67 Move selected feature list to a collapsible inspector section (close #7273) 2020-01-20 11:34:51 -05:00
Quincy Morgan
bb593c5ccc Add "deselect" tooltip to X buttons in selected features list 2020-01-20 10:22:49 -05:00
Quincy Morgan
d40b4295e4 Update imagery 2020-01-18 16:02:20 -05:00
Quincy Morgan
d2ee613bfc Merge pull request #7268 from hikemaniac/exhibition_centre
Add preset for amenity=exhibition_centre
2020-01-18 16:00:13 -05:00
hikemaniac
c8283028c2 Rebuild with updated dependencies 2020-01-18 21:39:58 +01:00
hikemaniac
826a3e954e Added preset for amenity=exhibition_centre 2020-01-18 21:23:48 +01:00
Quincy Morgan
08cfdc3987 Remove unused string 2020-01-18 15:01:56 -05:00
Quincy Morgan
e62e3107cc Add derived data for prior two commits 2020-01-18 13:37:04 -05:00
Quincy Morgan
eda51f6835 Add initial multiselection raw tag editing in 2.x 2020-01-17 17:49:26 -05:00
Quincy Morgan
0aeb096d57 npm run translations 2020-01-16 18:37:36 -05:00
Bryan Housel
be8b3ec0c8 npm run imagery 2020-01-16 11:49:43 -05:00
Bryan Housel
e84dca4926 Update to osm-community-index v2.0.0 2020-01-15 17:48:02 -05:00
Quincy Morgan
983dee68e1 Remove preset for deprecated tag power=sub_station 2020-01-15 11:25:22 -05:00
Quincy Morgan
116f52a78c Add Lavoir preset (close #7243) 2020-01-15 10:49:40 -05:00
Quincy Morgan
df3865c96f Add presets for coal, gas, nuclear, and hydro values of plant:source
Update terms for Wind Farm preset (re: 3340d05502)
Add `plant:source` and `plant:method` fields
2020-01-15 10:29:56 -05:00