Commit Graph

54 Commits

Author SHA1 Message Date
Bryan Housel 35a9f77a63 Preserve selected entity when cancelling save mode
(closes #4407)
2017-11-12 12:34:04 -05:00
Colin Kennedy c81cf703f2 Fix #4443 Imagery only updated on first save 2017-10-15 15:45:53 -04:00
Seth Fitzsimmons 0b770450cd Allow -,_,+,& as hashtag characters 2017-10-09 14:56:49 -04:00
Bryan Housel 8f82caf554 Adjust hashtagRegex: allow '_', change * (0 or more) to + (1 or more) 2017-10-09 14:39:02 -04:00
Seth Fitzsimmons 37cf22e1a2 Treat punctuation as hashtag delimiters
Unicode ranges for punctuation are simpler than creating a Unicode-aware
word class, so delimit on non-words.

Fixes #4398
2017-10-09 10:14:25 -04:00
Bryan Housel 3d13620705 Convert lodah-es and d3 to named imports for ui 2017-09-26 11:22:43 -04:00
Bryan Housel 595053621b Wrap request review UI in div and label
(closes #4354)
2017-09-18 14:10:14 -04:00
Bryan Housel 0f153d7d55 Ignore URLish fragments when detecting hashtags in changeset comment
(closes #4289)
2017-09-11 12:11:22 -04:00
Bryan Housel ba8a1e6bc6 Several changes to avoid storing stale hashtags
(closes #4304)

- remove context.storage hashtags whenever hashtags are detected in comment.
- when changing the comment, override hashtags with any found in comment.
2017-09-11 11:50:59 -04:00
Bryan Housel 9719a31c79 Match less punctuation in hashtags
(closes #4303)
2017-09-11 09:55:29 -04:00
Bryan Housel f034092b44 Write post-save count, not pre-save count to the changesets_count tag
(closes #4283)
2017-08-26 15:46:56 -04:00
Bryan Housel 121a1fa629 Avoid making an empty hashtags tag 2017-08-17 12:06:16 -04:00
Bryan Housel 2bf7a5e08b Write changeset tags for new mappers to indicate walkthrough progress
These tags all start with `ideditor:`
(closes #3968)

```
ideditor:walkthrough_completed=yes
ideditor:walkthrough_progress=welcome;navigation;point;area;line;building;startEditing
ideditor:walkthrough_started=yes
```
2017-08-16 20:10:01 -04:00
Bryan Housel ea298b0b18 Change raw tag editor readOnlyTags to accept array of regex 2017-08-16 19:54:53 -04:00
Bryan Housel 25d8a8aa08 Store changesets_count in a changeset tag
(it will say "0" for someone making their first edit)
2017-08-16 16:31:21 -04:00
Bryan Housel a42aa789e9 Add hashtags API parameter and localStorage
(closes #2834)
2017-08-16 10:47:17 -04:00
Bryan Housel 4cf357f61a Add code to extract hashtags from changeset comment 2017-08-16 00:30:34 -04:00
Bryan Housel ba3f823141 Split out commitWarnings and commitChanges sections into smaller modules 2017-08-15 01:50:52 -04:00
Bryan Housel d7a07208e1 Restore saving comment to localstorage 2017-08-14 23:14:05 -04:00
Bryan Housel 194b56c0f0 Restore the comment google warning 2017-08-14 22:59:15 -04:00
Bryan Housel 9b37ac7b6c Fix errors with changeset fields and warnings, improve styles 2017-08-13 23:25:37 -04:00
Bryan Housel fba6871e5c WIP: persist uiRawTagEditor, uiChangesetEditor between renders 2017-08-13 12:08:49 -04:00
Bryan Housel e0266da083 WIP: add changeset fields and refactor 2017-08-12 14:26:34 -04:00
Bryan Housel 439eed4b39 WIP: refactor uiCommit into sections, introduce uiChangesetEditor
uiCommit is getting kind of big as we add more to the commit pane.

I'm going to split it up and put the field rendering code into a separate
module, similar to how uiEntityEditor embeds uiPresetEditor for the fields.

This allows us to add a few more fields that users can set on their changesets
(like hashtags, source), and even hide them under a "Add field" dropdown.
2017-08-11 17:17:46 -04:00
Bryan Housel 59e6642796 Pacify eslint 2017-08-11 15:07:42 -04:00
Bryan Housel b172b4602b Move review_requested back to the buttons.. Make it work on tag changes 2017-08-11 01:12:42 -04:00
Bryan Housel 1a9614bb9d Adjust styles 2017-08-10 22:59:39 -04:00
Bryan Housel 9bba0ed57e Move request review up next to comment 2017-08-10 22:04:44 -04:00
Bryan Housel 03c8e07cb1 Remove the link to the osm wiki changeset page
(doesn't really add anything and not written for newbies)
2017-08-10 15:13:27 -04:00
Bryan Housel e22c379094 Merge branch 'master' into request_review 2017-08-10 11:40:19 -04:00
Bryan Housel 99a3741b0c Better isolation of services, to avoid hitting network during test runs
1. All services are disabled in testing now to prevent network accesses
2. Only services are enabled when needed to test something
3. Many changes throughout code to allow iD to run with services disabled
   (e.g. check for osm service instead of assuming context.connection() will work)
4. Actually export the services so we can disable and enable them
2017-08-09 22:04:09 -04:00
Kushan Joshi b5ece16432 add requesting review 2017-07-24 16:18:47 +05:30
Bryan Housel a5554cf3b0 Expire saved changeset comment older than 2 days
(closes #3947)
2017-04-21 23:01:32 -04:00
Bryan Housel 5f44c9a00a Add combobox menus to id-container instead of document.body
(re: https://github.com/openstreetmap/iD/issues/3925#issuecomment-290718356)
2017-03-31 13:44:55 -04:00
Bryan Housel 1a8cfcc8b1 Changeset refactor
(closes #2633)

* move osmChangeJXON from osm service to osmChangeset
* cleanup putChangeset for code clarity
* adjust params for callbacks (pass changeset around instead of changeset_id)
* add commit.reset() to reset changeset object after successful save
* improve checks for changeset tags (trim whitespace, etc)
2017-03-15 11:03:43 -04:00
Bryan Housel 4d207471ff Allow raw tag editor to have readonly tags 2017-03-14 12:17:52 -04:00
Bryan Housel 97f699d37d Better updates between comment box and changeset tags 2017-03-13 21:45:44 -04:00
Bryan Housel 16df2f595f Change raw tag editor to embed it on commit pane 2017-03-13 17:32:50 -04:00
Bryan Housel e756520bd8 suppressMenu(true) is now the default 2017-02-21 15:47:22 -05:00
Bryan Housel 132a5b56c3 Made it a bit simpler with lodash _uniqBy 2017-01-16 17:56:59 +05:30
Albin Larsson 70f74c4953 do not suggest duplicate commit messages 2017-01-13 21:22:58 +01:00
Bryan Housel 9b7d79a3fe Use live bound object for presets object, change context.presets() getter 2016-11-14 15:44:02 -05:00
Bryan Housel 3102a4ae6a Rename all the things to include pseudonamespaces 2016-10-04 19:06:20 -04:00
Bryan Housel 57d0bc13cf Fix lint warnings, comment out crashy service reset code (re: #3324) 2016-09-23 10:23:24 -04:00
Bryan Housel 9f956e414c Fix ui.Commit merge updated selections 2016-09-23 10:02:36 -04:00
Bryan Housel a6d683eaf7 Code cleanups in svg, ui for selection merging, fix Mapillary. 2016-09-17 23:26:49 -04:00
Tom MacWright ed135ce9ef Enable lib tests 2016-09-05 10:22:45 -04:00
Bryan Housel a86f34b4ef Pacify eslint, get build and tests running again 2016-08-26 01:15:07 -04:00
Tom MacWright cdb533fa84 Begin d3 v4 update 2016-08-21 15:19:27 -04:00
Tom MacWright 6341d4e4b5 one-shot build (#3266)
* One-shot development

* Move jsonp to module
* Tooltip -> module
* Remove d3.jsonp
* Fix tooltip lint
* Load all libs but d3 itself with require
* Add top-level brfs

* Unformat intro graph
2016-08-10 15:25:19 -07:00