Because notes dont exist in the history or graph, there is no history change
event to trigger a redraw, as there would be when adding points and other things.
Also stringify the note id (because existing notes from OSM are this way)
Also make sure comments is initialized as an Array not an Object
Also clarify some of the tests
- I made the buttons work like GitHub comment-on-issue buttons
before typing: "Close Note" / "Comment" (disabled)
after typing: "Close and Comment" / "Comment" (enabled)
- I removed a bunch of the event dispatches. These are useful for sending
events to listeners/observers outside of the module. In this case I think
we can handle most of the things from within the uiNoteEditor. We can still
dispatch an 'update' event so that modeSelectNote can reselect and redraw
the note after some change happens to it.
TODO - make the buttons work / check the OSM API stuff.
(closes#4841)
Before, first/last keyboard shortcuts only worked if you had a vertex selected.
Now you can navigate to the first/last vertices even if you have the way selected.
Trying to eliminate the minimum 10m distance for replacing the original
junction vertex - this is a small threshold. When _not_ replacing this
vertex, the unzorro code will wreck havok on a traffic circle.
(If there is no suitable vertex to use, it will snap to a point between
the nearest vertices, see #4146)
(closes#4669)
Now instead of creating MultiLineString targets, we just create a bunch of
LineString targets. This makes the code simpler, and anyway the entity is
still there in `properties` for drawing code to decide what to do with the target.
Incidentally, this change allows iD to support an extrusion operation.
(Because each way segment has its own unique GeoJSON target now)
Quincy Morgan