CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 17:23:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
12,912 Commits 2 Branches 0 Tags
d669bbef2afe804318484df6127db5b360d900bd
Commit Graph

192 Commits

Author SHA1 Message Date
Quincy Morgan
eed7944a1a Replace various uses of d3_select and d3_selectAll with selection on the container 2020-03-22 12:34:06 -07:00
Quincy Morgan
6087aae21f Remove map convenience functions of context 2020-03-22 10:57:17 -07:00
Quincy Morgan
3c0b926ec7 Replace coreContext.geometry function with a more explicit coreGraph.geometry function 2020-03-21 14:23:44 -07:00
Quincy Morgan
fac613e1dc Remove context.childNodes function 2020-03-21 13:56:11 -07:00
Quincy Morgan
5fd25601fe Convert map surface and supersurface from ids to classes 2020-03-21 13:41:06 -07:00
Quincy Morgan
dd9c30beb1 Use pointer events instead of mouse events for lasso selection (re: #5505) 2020-03-13 13:23:06 -07:00
Quincy Morgan
b5856e2415 Rewrite behaviorDrawWay to only always use one and only one temporary edit 
Fix issues involving undoing while drawing ways
Prevent self-intersection when adding nodes to ways on touch devices (close #7423)
 2020-03-11 17:48:09 -07:00
Quincy Morgan
b86486c69f Flash error when cannot finish drawing self-intersecting area 2020-03-10 15:36:13 -07:00
Quincy Morgan
10f7ef2704 Add error feedback text when attempting to draw self-intersecting ways 2020-03-06 15:36:48 -08:00
Quincy Morgan
6ed66fb3ce Make drawing modes usable on touch devices 2020-03-06 15:17:11 -08:00
Quincy Morgan
f8f69a777a Replace inconsistently-supported dblclick events with custom handler on platforms supporting pointer events 
Fix issue where double-tap-to-zoom would not be properly disabled when drawing on touch devices (close #2128)
Support adding nodes to ways with double-tap with on touch devices (close #2677)
Support double-tap-to-zoom with styluses on touch devices
Don't accept double click/tap events if the taps are far apart
Don't re-enter modeSelect when clicking the selected feature again
 2020-03-06 12:46:26 -08:00
Quincy Morgan
83a51a4192 Use pointer events for node dragging and drawing (re: #5505) 
Enable dragging nodes with touches and styluses (close #7415)
 2020-03-05 15:18:39 -08:00
Quincy Morgan
83d2656bbc Fix responsiveness issue when selecting features on iPad 
Implement an alternative solution for #6028 that doesn't rely on timeouts
 2020-03-04 13:10:15 -08:00
Quincy Morgan
c41e0b9937 Use pointer events for hovering and selecting data on supported platforms (re: #5505) 
Fix issue where Apple Pencil stylus could not select map data (close #7396)
Fix issue where features could not be selected in a single tap on iPad (close #7380)
 2020-03-04 12:18:43 -08:00
Bryan Housel
dc7fba4bf8 Have utilStringQs advance past any leading '?' or '#' characters 
This lets us remove a bunch of substring(1) and +1 from the code.
 2020-02-20 17:09:54 -05:00
SilentSpike
51efd5b714 Update and standardise QA implementations 
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
 2020-02-06 23:07:50 +00:00
Quincy Morgan
ba59bdf23b Disable operations, copy, and paste during low-zoom selection 2019-12-23 10:33:16 -05:00
Quincy Morgan
523a467836 2.x: Make toolbar horizontally scrollable when it overflows (re: #6755, re: 7545f67063b5e7007ef2d8367e3181e59c04a487) 
Generalize tooltip into popover control
Use the same popover control for tooltip as the preset browser and tools list popovers
Smartly position the preset browser popover and menu bar tooltips to stay fully onscreen
Position most tooltips closer to their controls
Fix small gap that could appear between a tooltip and its arrow
Allow wider toolbar tooltips
 2019-12-16 13:30:07 -05:00
Quincy Morgan
91b6844377 Implement cleaner solution for removing breathe styling from deselected features 2019-12-13 13:16:29 -05:00
Quincy Morgan
ff506fc332 Prevent partial rendering of selection style when showing only selected features at low zooms 2019-12-12 17:50:48 -05:00
Quincy Morgan
4b4ea122ad Fix performance issue where breathe behavior would be called for each selected element instead of just for the surface (close #3571) 2019-12-10 13:42:11 -05:00
Quincy Morgan
eb49a367b4 Don't reuse changeset comment, sources, and hashtags from prior uploads (close #6642, re: #6279) 2019-07-22 16:12:20 -04:00
Bryan Housel
37557a7c98 Defer processing clicks in behaviorSelect 
(closes #6028) (I hope?)

Because this click may trigger a blur event,
and the blur event may trigger a tag change,
and we really want that tag change to go to the already selected entity
and not the one that we are about to select with the click  #6028, #5878

(Be very careful entering modeSelect anywhere that might also blur a field!)
 2019-05-01 14:47:29 -04:00
Bryan Housel
d3f767d6f4 Code cleanups, prefix state variables with _ 2019-05-01 13:48:36 -04:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
af45dbce10 Trying to avoid one-off validations when history changes will trigger it 2019-04-05 11:37:02 -04:00
Bryan Housel
cda8f657ac Swap fast-deep-equal for lodash isEqual 
(re: #6087)
 2019-03-29 22:17:29 -04:00
Bryan Housel
d5abe468b9 Remove rest of the lodash iterators: map, reduce, forEach 
(re: #6087)
 2019-03-29 15:14:21 -04:00
Bryan Housel
3896b2282f Remove lodash isNaN, isNumber, isString, bind, uniqBy 
(re: 6087)
 2019-03-27 23:11:45 -04:00
Bryan Housel
3d80e6505f Remove lodash chunk, groupBy 
(re: #6087)
 2019-03-27 16:18:41 -04:00
Quincy Morgan
67fc051632 Tweak newFeature in select mode 2019-03-26 16:34:23 -04:00
Bryan Housel
4821bf0a68 Remove lodash omit 
(re: #6087)
 2019-03-26 14:12:45 -04:00
Bryan Housel
1ce4f0ad6a Remove lodash without 
(re: #6087)
 2019-03-25 21:56:54 -04:00
Bryan Housel
7a6c63fcc5 Remove lodash extend (re: #6087) 2019-03-23 00:38:39 -04:00
Bryan Housel
0e90167513 Remove lodash clone 
(re: #6087)
 2019-03-22 23:18:25 -04:00
Bryan Housel
11bfeaabfc Add browser-polyfills, remove lodash assign, compact, values 
(re: #6087)
 2019-03-22 17:14:41 -04:00
Quincy Morgan
78590466ba Merge branch 'master' into add-feature-search-bar 2019-03-06 15:50:31 -05:00
Bryan Housel
e216d5be3e Avoid dispatching extra change events, don't mutate childNodes 
(closes #5996, related #5941)
 2019-03-06 15:41:12 -05:00
Quincy Morgan
6e0f5c6823 Allow adding vertex-only features from the serach-to-add field 
Allow favoriting vertex presets
Don't allow adding vertex-only presets as points
Rename Other preset to Vertex
 2019-03-04 17:38:08 -05:00
Quincy Morgan
b828ada0e2 Don't allow adding point-only features as vertices 2019-03-04 17:04:35 -05:00
Quincy Morgan
5ed5a7536b Show preset browser when adding generic point, line, or area 2019-03-01 09:07:41 -05:00
Quincy Morgan
a3424aa4b1 Merge branch 'master' into squash-favorite-preset 2019-02-26 14:25:34 -05:00
Quincy Morgan
5262358d81 Fix an issue where added nodes would highlight momentarily while drawing an area 2019-02-26 09:34:45 -05:00
Quincy Morgan
0e71ae7032 Fix lint warning 2019-02-25 11:40:26 -05:00
Quincy Morgan
ced652806b Fix an issue where some tagged nodes or existing vertices could not be snapped to (close #5942) 2019-02-25 08:54:30 -05:00
J Guthrie
249046614c Add exception to isInvalidGeometry algorithm 
- An area with just 1 placed node (2 nodes including active, to-be-placed node,
    returns as valid and is picked up by later way.isDegenerate() check
 2019-02-24 13:58:16 +00:00
Quincy Morgan
7da37384f1 Fix an issue where stale missing tag errors could persist when canceling drawing a new way (close #5918) 
Don't show missing tags error for a feature that is still being drawn (re: #5898)
 2019-02-21 09:48:46 -05:00
Quincy Morgan
be71554f61 Fix a bug where all data would disappear when switching modes while drawing a way (close #5917) 2019-02-21 09:22:03 -05:00
Brian Hatchl
1faa6ad839 Favorite preset 2019-02-20 15:23:58 -05:00
Quincy Morgan
708c5e8155 Fix crash when undoing an added line past the first node 2019-02-19 12:10:05 -05:00