Xiaoming Gao
a4e1012c91
add crossing_way validation
...
Tests are also added and passed.
One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
2018-12-19 19:23:35 -05:00
Andrew Wong
6e749c70ef
listening to user generated history changes for validation
2018-12-19 17:28:34 -05:00
Xiaoming Gao
c1e3a7396f
filter validations early in history
...
Follow @wonga00's comment in https://github.com/openstreetmap/iD/pull/5627
2018-12-19 12:05:06 -05:00
Xiaoming Gao
07a53fe6ea
Extend data model for validation issues
...
Add the Issues pane
1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
(1) add a severity level field (useful for identify save-blocking issues later)
(2) replace single entity with an array of entities (useful for issues involving multiple entities)
(3) add a coordinates field for highlighting the location of the issue on the map
(4) add a fixes field for possible automatic fixes
3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
Quincy Morgan
161311faa5
Merge pull request #5626 from wonga00/wonga_issue_manager
...
added IssueManager
2018-12-18 18:05:40 -05:00
Quincy Morgan
858a9606d5
Added entity display name or preset name to the disconnected highway message
2018-12-18 18:05:27 -05:00
Andrew Wong
30f25c6e8d
added IssueManager
...
- IssueManager performs validation on the current graph and also
stores the issues and notifies listeners when the issues changed
2018-12-18 17:52:23 -05:00
Bryan Housel
5a2049b421
Drop extra whitespace, make sure service exists before using it
2018-12-18 15:38:53 -05:00
Max Grossman
8f33a85a12
make collection.index function to handle failing tests
2018-12-17 17:16:10 -05:00
Max Grossman
e0e6f5b918
remove non-used util class
2018-12-17 12:52:21 -05:00
Max Grossman
d87b1822f7
add/make visible weakly matched presets
2018-12-14 15:42:25 -05:00
Max Grossman
1b51b8bc57
adding tests and updating/fixing external presets logic
2018-12-14 13:23:58 -05:00
Max Grossman
c897331cd1
presets test w/build
2018-12-13 13:30:38 -05:00
Max Grossman
96e44be69c
merge 2.12.2
2018-12-13 11:22:32 -05:00
Bryan Housel
eb14a9ed53
v2.12.2
2018-12-13 10:28:31 -05:00
Bryan Housel
13b1a9a629
If imagery becomes invalid, remove it from imagery_used
...
(closes #4827 )
2018-12-11 17:49:15 -05:00
Bryan Housel
b494684e4f
v2.12.1
2018-12-05 01:58:18 -05:00
Bryan Housel
5451d0f3fe
v2.12.0
2018-12-03 22:14:05 -05:00
Bryan Housel
152022aec4
Use context.keybinding for keybindings that don't change
...
(closes #5487 )
2018-11-13 20:57:21 -05:00
Max Grossman
622b7b9e0c
move validations to its own class
...
ref #remote-presets
2018-10-01 21:45:21 -04:00
Max Grossman
0a31137c78
move maprules/mapcss to a service class
...
ref #remote-presets
2018-09-23 18:38:01 -04:00
Max Grossman
155983197f
small variable change
2018-09-23 12:26:14 -04:00
Bryan Housel
ad289e0565
v2.11.1
2018-08-29 00:55:36 -04:00
Bryan Housel
2cee31d611
v2.11.0
2018-08-26 02:18:05 -04:00
Max Grossman
8f9a281825
additional test tweaks
...
ref #remote-presets
2018-08-14 12:49:41 -04:00
Bryan Housel
930e865b42
Attempt to prevent users from uploading duplicate changes
...
(closes #5200 )
This removes a users changes stored in localStorage if they try to close
iD while an upload is in progress. It prevents the possiblity that the
changeset is eventually accepted and closed, but the user can be prompted
to restore those changes the next time they start iD.
2018-08-11 19:15:18 -04:00
Max Grossman
f168f85496
passing mapcss test w/out parser, use that on sever
...
ref #remote-presets
2018-08-10 09:16:59 -04:00
Max Grossman
3a0f8ddd09
infer geometries
...
ref #remote-presets
2018-08-08 13:21:35 -04:00
Max Grossman
f5c21ddaaf
some geometry inferring!!!
...
ref #remote-presets
2018-08-08 08:50:45 -04:00
Max Grossman
b93444de75
working on isArea-ish equivalent for mapcss selector objects
...
ref #remote-presets
2018-08-02 18:03:13 -04:00
Max Grossman
5b1dee3779
add tests for mapcss checks
...
ref #remote-presets
2018-08-02 12:47:47 -04:00
Max Grossman
2bf5eaf6e7
initial plumbing for iD validation errors
...
ref #remote-presets
2018-07-31 14:22:34 -04:00
Max Grossman
db78df55c8
get validaiton objects on context
...
ref #remote-presets
2018-07-31 13:41:24 -04:00
Bryan Housel
c1978c0713
v2.10.0
2018-07-26 01:12:48 -04:00
Bryan Housel
119792fd22
Cleanups to Detach Node feature
...
This commit includes a bunch of minor things:
- change keyboard shortcut to 'E' to not conflict with anything
- move `disabled` check from operation into action and simplify
- use `actionMoveNode` to place the detached node at the mouse cursor
- disable the operation if the node is connected to hidden features
- lots of code simplification
- make the icon more centered
2018-07-23 13:36:34 -04:00
Bryan Housel
c0b77d8226
remove unneeded dimensions argument (projection clipExtent has it)
2018-07-21 21:44:14 -04:00
Max Grossman
57ea240177
make uiModes options strict to match only those within defaults
...
ref #remote-presets
2018-07-18 10:50:54 -04:00
Max Grossman
659a291e89
add core overwrite for external preset source
...
ref #remote-presets
2018-07-17 16:43:00 -04:00
Bryan Housel
b14d1b5061
resolve conflicts, fix a few minor bugs prob caused by merging:
...
- don't insert multiple times into the rtree in `services/osm.js`
- use `d.id` instead of `d.key` as the key in `svg/notes.js`
2018-07-03 16:40:07 -04:00
Bryan Housel
98e4fed829
v2.9.2
2018-06-28 19:02:06 -04:00
Bryan Housel
6ac9e4fff5
v2.9.1
2018-06-25 21:15:25 -04:00
Bryan Housel
30c7f7dbb5
v2.9.0
2018-06-14 08:20:47 -04:00
Bryan Housel
dc8e8eb933
v2.8.2
2018-05-14 17:47:23 -04:00
Bryan Housel
e3fcbaaa50
v2.8.1
2018-04-24 10:13:54 -04:00
Bryan Housel
89815d7d8a
v2.8.0
2018-04-16 14:03:25 -04:00
Bryan Housel
242a01a3e1
Import osm-community-index and debug flag so we can look at it
2018-04-03 22:44:52 -04:00
Bryan Housel
d2558b950d
v2.7.1
2018-03-11 11:52:48 -04:00
Bryan Housel
0f7ef99dbc
v2.7.0
2018-03-02 17:54:38 -05:00
Bryan Housel
0c23073d52
Correctly catch loc changes
2018-02-05 14:34:51 -05:00
Bryan Housel
6c3a02cebe
Avoid lodash in hot code in coreDifference
...
(closes #2743 , closes #4611 )
2018-02-05 13:44:01 -05:00