Commit Graph

222 Commits

Author SHA1 Message Date
Quincy Morgan
9d940fffdb Fix issue where untagged multipolygon member lines would render as lines instead of area edges
Show recents in the ribbon again
2019-03-20 15:05:35 -04:00
Quincy Morgan
7d0080a642 Persist the photo overlay layers via the URL query string (re: #5813) 2019-03-14 16:48:08 -04:00
Quincy Morgan
c65a4d038e Add photo overlay filter options for hiding flat and pano photos (close #5433) 2019-03-14 14:24:21 -04:00
Quincy Morgan
213d0ee3e8 Move preset favoriting functions from core/context.js to presets/index.js
Make recent presets persistent and compatible with favorite presets
2019-03-07 16:49:29 -05:00
Quincy Morgan
ba185d2ee6 Make Point, Line, and Area the default favorite presets 2019-03-07 13:32:14 -05:00
Quincy Morgan
efac17810c Check for valid indices when reordering favorites 2019-03-07 11:22:19 -05:00
Quincy Morgan
c3d1dc43d4 Add valid geometry check for saved favorite presets 2019-03-07 11:17:41 -05:00
Quincy Morgan
a38da25dc4 RTL layout support for previous commit
Add check to make sure saved favorite presets are valid
2019-03-07 11:16:01 -05:00
Quincy Morgan
78590466ba Merge branch 'master' into add-feature-search-bar 2019-03-06 15:50:31 -05:00
Bryan Housel
6da2ba7b9d Make sure pause/resumeChangeDispatch can be called multiple times 2019-03-06 15:41:12 -05:00
Bryan Housel
0ea69548ea Add history.pauseChangeDispatch / history.resumeChangeDispatch
To avoid dispatching change events at improper times
2019-03-06 15:41:12 -05:00
Quincy Morgan
2618565826 Make favorites list last in, first out 2019-03-06 08:49:17 -05:00
Quincy Morgan
776c0556e1 Add drag-and-drop reordering of favorite presets 2019-03-05 20:21:54 -05:00
Quincy Morgan
e22f3359f5 Allow up to 10 favorite presets
Show favorite preset keyboard shortcut in tooltip
2019-03-05 12:27:42 -05:00
Bryan Housel
3f8911c149 Merge pull request #5999 from openstreetmap/squarish
Improve orthogonalization action
2019-03-01 23:28:23 -05:00
Bryan Housel
e64693eea5 Upgrade tests from legacy iD.Difference to iD.coreDifference 2019-03-01 16:03:21 -05:00
Quincy Morgan
b302d853ac Fix issue where the favorite preset button could be stale
Use first in, first out favoriting order
2019-02-27 13:13:15 -05:00
Quincy Morgan
a3424aa4b1 Merge branch 'master' into squash-favorite-preset 2019-02-26 14:25:34 -05:00
Quincy Morgan
0fa7e757b1 v2.14.3 2019-02-26 13:45:53 -05:00
Quincy Morgan
87e48bc543 Run missing role validation before missing tag 2019-02-25 18:01:34 -05:00
Quincy Morgan
b8ac9a7de3 Add toggle-able list of rules to the Issues pane (close #5979)
Toggling a rule off prevents the validation from running
2019-02-25 15:31:05 -05:00
Quincy Morgan
70e88ee9af v2.14.2 2019-02-21 17:01:00 -05:00
Quincy Morgan
7936266a7a Improve validation performance by avoiding uniqueWith lodash function
Replace map lodash function with JavaScript array map in validator.js
2019-02-21 12:13:27 -05:00
Quincy Morgan
51972ea78f Cache issues in crossing ways validation to avoid checking the same pairs twice 2019-02-21 11:49:31 -05:00
Quincy Morgan
aa992ed981 Improve validation performance by cacheing the issue id 2019-02-21 10:47:57 -05:00
Quincy Morgan
1bde3ba63f v2.14.1 2019-02-20 18:23:47 -05:00
Quincy Morgan
1f1e88314d v2.14.0 2019-02-20 16:19:36 -05:00
Brian Hatchl
d8531c88bb fix lint complaints 2019-02-20 15:44:16 -05:00
Brian Hatchl
1faa6ad839 Favorite preset 2019-02-20 15:23:58 -05:00
Quincy Morgan
1821c3e955 Update fixes UI for icons, link styling, and non-actionable fixes
Fix several bugs
2019-02-14 15:56:04 -05:00
Bryan Housel
c4fe42653a s/coordinates/loc and replace legacy names in tests
In iD codebase `loc` is usually a single coordinate pair
and `coordinates` is usually an array of pairs
2019-02-12 21:18:25 -05:00
Bryan Housel
448fe498bd Only recenter view if necessary, select after delay, fix maprules type 2019-02-12 17:25:54 -05:00
Bryan Housel
14896b0ce5 Documentation, and move validation type up to top of each file 2019-02-12 16:07:08 -05:00
Bryan Housel
9ebc9a22e9 perf: use Object instead of Array for lookup, cache on osmEntity.key 2019-02-12 14:23:50 -05:00
Bryan Housel
4e6ade08b1 Comment out cache in getIssuesForEntityWithID
It seems like entity editor draws before the validator runs so the
rendered list is often one history change behind.
2019-02-12 00:22:24 -05:00
Bryan Housel
c083d1d0af More nitpicky code formatting issues
- no multiline var declarations
- avoid lodash unless necessary
- linefeeds for readability
2019-02-11 14:51:21 -05:00
Quincy Morgan
47ec58e5fc Don't zoom to the end vertex when continuing a disconnected highway if it is already visible
Add separate fixes for continuing a disconnected highway from the start and end vertices
Highlight the vertex that will be continued
2019-02-11 11:29:34 -05:00
Quincy Morgan
d70c02ee6d Replace use of Set object in validator 2019-02-08 09:33:17 -05:00
Quincy Morgan
1564f73de6 Merge branch 'master' into validation 2019-02-07 20:51:21 -05:00
Bryan Housel
d2735ab40c Fix misspelling 2019-02-07 13:41:06 -05:00
Quincy Morgan
d3946894e8 Standardize deprecated_tag and missing_tag rule type ids
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan
bfb5285dc9 Fix tests and lint warnings 2019-02-04 13:34:27 -05:00
Quincy Morgan
2677a88df4 Zoom to ways and relations upon clicking on their issues in the issues pane 2019-02-04 10:27:35 -05:00
Quincy Morgan
9785021f44 Rename simpleMultipolygon functions to oldMultipolygon
Return old_multipolygon validation issues for the relations as well as the outer ways
Remove console logging
Don't run missing_tag validation for relations with old_multipolygon issues
2019-02-01 15:19:28 -05:00
Quincy Morgan
973697b8ba Run all validators in the validations folder if not manually run
Remove ValidationIssueType and ValidationIssueSeverity objects
2019-02-01 13:38:17 -05:00
Quincy Morgan
46f3cea33a Reorganize validation code
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
09bc2a6e6c Merge branch 'master' into validation 2019-01-30 16:44:14 -05:00
Quincy Morgan
77c4d41855 Restore many deletions warning with tooltip and nicer message
Add tooltips back to issues pane list
Fix crash when restoring without having loaded the edited area
2019-01-30 15:48:06 -05:00
Bryan Housel
7138acc652 Properly export areaKeys, fix preset and maprules tests 2019-01-30 15:29:37 -05:00
Quincy Morgan
5b93ee0f7a Run validation upon data restore after page reload 2019-01-30 13:40:02 -05:00