- class the #sidebar itself as collapsed not the #id-container
- the #sidebar is the selection, so just use `selection` instead of
`var sidebar = d3_select('#sidebar');`
(which conflicts with the closure `sidebar()` function)
- have separate functions `expand` `collapse` `toggle` rather than a
`toggle(shouldCollapse)`
- Makes the "Sidebar" toggle button permanent but removes the label
- Did some things to the "Save" button to make it the same width whether there
is a count or not (prevents the buttons from jumping when pressing undo/redo)
- Removes a lot of the floated col rules that aren't used much anymore
- Dragging the sidebar below a minimum size collapses it
- A button in the top toolbar lets you uncollapse the sidebar, complete with icon and tooltip
- Double-clicking the divider toggles the sidebar collapse
- Collapse-toggling is animated
- Selecting a feature or ending an add-feature mode auto-opens the sidebar
- Photoviewer UI has been moved from init.js to photoviewer.js
- The photoviewer now has a slight margin to set it away from the sidebar
- The undo/redo, save, and progress indicator controls are now floated to the right
- The save count has been redesigned to visually integrate with the save button
- When the sidebar is collapsed, the mode buttons are centered
- Full right-to-left layout support for all of the above
Breaks out the code for getting a selector for entities and all their descendants into a generic function
Accounts for circular relations when recursively getting all relation member IDs
(closes#5295)
The cause of this crash was:
- when cancelling a line, `drawWay.cancel()` needs to clean up old edits.
- it does this by looping `context.pop()` them off history until they are gone
- each `context.pop()` dispatches a 'change' event
- if we reset the chapter on one of these change events, it throws away the
graph, and `drawWay.cancel()` can't finish what it's doing
A few things going on in this commit:
- uiConfirm already has an OK button, so I'm trying to use that instead of uiModal.
- The confirm OK button cancels, which is maybe a problem. I might change it.
- Dispatch a change event instead of trying to call a function back in uiBackground
- Remove some of the custom css, since we already have some shared button css
- add utilNoAuto to textarea (this just prevents autocomplete and other
annoying behaviors especially in Safari)
Bryan Housel