Commit Graph

258 Commits

Author SHA1 Message Date
Quincy Morgan 0b28648e6d Add plural form support for multiselection page title (close #8026) 2020-09-27 18:42:27 -04:00
Quincy Morgan 74f473f5a5 Fix issue where currently drawn feature could be discarded when switching the background while navigating the map (close #7999) 2020-09-25 15:19:18 -04:00
Quincy Morgan 8883c2f36d Fix uiFlash issues
Clean up a few things from prior commit
2020-09-22 12:19:54 -04:00
Quincy Morgan abf75bdd98 Don't use HTML on page title 2020-09-16 08:40:02 -04:00
Quincy Morgan 295c53810f Fix issue where text could not be copied while a feature was selected (close #7908) 2020-09-04 10:49:02 -04:00
Quincy Morgan 7920f269c0 Fix issue where node could not be dragged after long-clicking if something else was already selected (close #7826) 2020-09-03 09:57:55 -04:00
Quincy Morgan 6521184cf3 Properly use the "Continued an area" annotation for the second vertex in an area instead of "Started an area" (re: #7772) 2020-09-02 11:08:06 -04:00
Quincy Morgan a1987e21d9 Fix issue where undoing the second-to-first vertex of a way when drawing would undo to the initial state of the way (close #7772) 2020-09-02 11:07:09 -04:00
Peter Newman 4205ca1d07 Fix the seemingly safe spellings found by codespell
Untested, only checked by inspection.

(cherry picked from commit 2c47a11008)
2020-08-10 17:32:37 +01:00
Quincy Morgan 5491163616 Remove hover upon pointercancel 2020-07-06 16:31:11 -04:00
Quincy Morgan f08a9fdfb4 Close the edit menu if a pointer goes down in the map 2020-06-30 12:07:06 -04:00
Quincy Morgan 24638fe8e4 Disable node lasso selection when zoomed out (re: #7728) 2020-06-25 14:28:02 -04:00
Quincy Morgan d441c5b0c6 Flash operation annotation when tapping buttons with touch or stylus (re: #7699) 2020-06-25 11:21:23 -04:00
Quincy Morgan 13f807043c Disable lasso multiselection for disabled OSM data (close #7728) 2020-06-23 15:18:52 -04:00
Quincy Morgan cc5da9b9c3 Add endpoints to customize or disable iD's changing of the document title (close #7503)
Use the initial title as the default base title
2020-06-10 15:47:41 -04:00
Quincy Morgan 0cd1b40c57 Make sure clicking the first node finishes drawing when drawing any closed way 2020-06-02 16:57:14 -04:00
Quincy Morgan 5eb0fc3e0e Update comments 2020-06-02 15:58:35 -04:00
Quincy Morgan 1d377227d0 Enable dual-pointer multiselection even if neither feature is selected yet
Don't do dual-pointer multiselection if a pointer has moved too much since it went down
Properly switch the selection when right-clicking on an unselected feature during a multiselection
2020-06-02 15:44:58 -04:00
Quincy Morgan 64096cbc67 Handle pointercancel events in behaviorDrag 2020-05-28 14:21:22 -04:00
Quincy Morgan 717f9ae5b7 Fix prior commit and add additional safety checks 2020-05-28 14:12:11 -04:00
Quincy Morgan 1214b2d5dd Preview the draw segment upon pointerdown on touchscreens unless it becomes invalid
Block creation of invalid geometries due to connecting to invalid sibling segments or nodes on the drawn way on touchscreens
2020-05-28 13:50:51 -04:00
Quincy Morgan 2264e4a6d7 Fix code tests 2020-05-28 11:45:49 -04:00
Quincy Morgan 79ceb96758 Fix several regressions to behaviorHover introduced in 38db23fab5 2020-05-28 11:33:47 -04:00
Quincy Morgan d8443d28d5 Detect and ignore erroneous mouse-type pointermove events sent after pointerup events on iOS when drawing 2020-05-28 11:13:09 -04:00
Quincy Morgan e2cd879c81 Account for canceled pointers in behaviorSelect 2020-05-27 16:55:04 -04:00
Quincy Morgan 0c8d237d17 Don't let down pointers trigger selection when raised after a long press 2020-05-27 15:54:39 -04:00
Quincy Morgan 38db23fab5 Extend behaviorHover to support multiple pointers 2020-05-27 15:07:23 -04:00
Quincy Morgan cb5365f743 Persist down pointer multiselection between browse/select mode transitions 2020-05-27 12:33:53 -04:00
Quincy Morgan 4646c11ff1 Continue multiselection while the triggering pointer is down even if the targeted feature is deselected 2020-05-27 11:33:32 -04:00
Quincy Morgan 5b399623e9 Enable multiselection on touch devices when tapping on features with a pointer already down on a selected feature (close #7590)
Reuse modeSelect when changing entity selection if possible
2020-05-26 17:21:48 -04:00
Quincy Morgan 869a0c6b89 Make the draw modes reuse their behaviorDraw when re-entering
Move click-end-node-to-finish functionality from draw modes to behaviorDraw
Fix issue where the head node would get hover-highlighted when continuing from the end of a line
2020-05-22 15:05:35 -04:00
Quincy Morgan 0a7f05b4a5 Fix console error with dragging midpoints 2020-05-21 13:35:50 -04:00
Quincy Morgan d6c0c329df Sort lassoed nodes more sensibly than just random 2020-05-20 16:49:03 -04:00
Quincy Morgan 95f8e36a2a Add a small tolerance to node dragging so selecting them no longer requires zero movement (close #1981) 2020-05-19 17:24:47 -04:00
Quincy Morgan c4f5dbbc4c Don't register spacebar-to-select unless the pointer is over the map 2020-05-19 11:13:03 -04:00
Quincy Morgan e319aebc41 Fix several circumstances where the edit menu could appear unexpectedly 2020-05-15 15:22:36 -04:00
Quincy Morgan e079e120bf Make behaviorDrag ignore non-active pointers (re: #6745) 2020-05-15 11:31:36 -04:00
Quincy Morgan 084d9336c4 Anchor pasted features to the position they were copied if done so with the edit menu (re: #2508) 2020-05-15 10:55:23 -04:00
Quincy Morgan db9eed2434 Move the edit menu logic to uiInit
Make context the first argument of operation objects
Add Paste operation to edit menu when opening the context menu on a blank area of the map (close #2508)
2020-05-14 15:49:35 -04:00
Quincy Morgan c939924f83 Fix issue with pressing spacebar in select modes 2020-05-14 13:09:25 -04:00
Quincy Morgan a0ad92e6e0 Always show the edit menu at the location of the triggering event 2020-05-14 12:32:43 -04:00
Quincy Morgan dff4268256 Allow selection, deselection, and multiselection with the spacebar (re: #3843)
Don't open the edit menu on single spacebar press
Open the edit menu for long spacebar press (re: #7577)
2020-05-14 11:19:20 -04:00
Quincy Morgan 0278e700a0 Convert feature copying functionality from a standalone behavior to an operation and add to edit menu (re: #2508)
Show flash feedback message when copying features with keyboard shortcut
Disallow copying of untagged vertices
2020-05-13 15:42:28 -04:00
Quincy Morgan 23714ba822 Position the edit menu above the anchor point if triggered via touch or stylus (re: #7577)
Add additional code safety to behaivorSelect
2020-05-12 18:42:36 -04:00
Quincy Morgan 4fede5214a Ensure that only one pointer is handled at a time in behaivorSelect 2020-05-12 16:10:07 -04:00
Quincy Morgan 4a3fc57742 Show the edit menu when long-pressing or long-clicking (close #7577) 2020-05-08 19:23:01 -07:00
Quincy Morgan 77061e9c6c Fix lint warnings 2020-05-08 09:42:02 -07:00
Quincy Morgan ff4eb971ac Fix various issues that made the walkthrough non-completable 2020-05-07 13:27:20 -07:00
Quincy Morgan 7a3a84b7b2 Remove broken "tail" functionality (close #7560) 2020-05-07 10:26:50 -07:00
Quincy Morgan d7e5aa6735 Keep track of the initial hash parameters through multiple loads of the UI (close #7504) 2020-04-14 14:03:18 -07:00