Commit Graph

304 Commits

Author SHA1 Message Date
Quincy Morgan 42efdf29f1 More progress on #7965 2020-09-10 15:03:18 -04:00
Quincy Morgan 426af25ae4 Fix code tests re: #7890 2020-09-02 16:32:30 -04:00
Quincy Morgan caf1343b62 Properly default the Wikipedia field language to iD's current language (close #7890) 2020-09-02 14:51:15 -04:00
Peter Newman 4205ca1d07 Fix the seemingly safe spellings found by codespell
Untested, only checked by inspection.

(cherry picked from commit 2c47a11008)
2020-08-10 17:32:37 +01:00
Quincy Morgan 5fbaad1088 Make the waterway destination field separate from the road sign destination field (re: 7c5ec9be70)
Make the destination field for the destination_sign preset a semiCombo (re: #6970)
2020-06-24 16:31:28 -04:00
Quincy Morgan cc52b6cfd4 Prevent empty combo fields from adding a blank tag 2020-06-18 10:51:12 -04:00
Quincy Morgan 5f93da5a59 Add a reusable function for calculating the combined extent of multiple entities (re: #7706) 2020-06-16 13:17:43 -04:00
Quincy Morgan 4467c4a501 Fix issue where spaces couldn't be typed in the changeset comment (re: #6817) 2020-06-11 10:52:58 -04:00
Quincy Morgan 874c412b74 Enforce max unicode charachter length of keys, values, and relation roles through truncation upon input rather than HTML maxlength attribute (close #6817)
Normalize unicode when changing keys, values, and relation roles
2020-06-10 14:11:55 -04:00
Quincy Morgan d01f1598d3 Show the delete button for filled multilingual name fields even if no name tag is present (close #7572)
Focus the language input when clicking a multilingual name field label instead of deleting the value
Be more lenient with `utilUniqueDomId` function input
2020-06-10 10:35:03 -04:00
Quincy Morgan 762307bd7d Restrict key, value, and role character limits based on unicode characters, not UTF-16 code units (re: #6817) 2020-06-09 15:41:15 -04:00
Quincy Morgan 87b4c34d1f Make sure the Wikipedia field reloads after the wiki language data is received 2020-05-29 11:37:22 -04:00
Quincy Morgan b3ece74807 Fix issue where the telephone field placeholders weren't localized 2020-05-29 10:57:17 -04:00
Quincy Morgan 2d02d452a9 Fix issue with the address field not displaying a localized format 2020-05-29 10:33:45 -04:00
Quincy Morgan 63aa47f02f Fix issue with entering language codes directly in multilingual name fields (close #7156) 2020-05-21 14:33:10 -04:00
Quincy Morgan 1c1f40cf80 Fix issue with maxspeed field updating 2020-05-21 10:52:32 -04:00
Quincy Morgan 41418e57a5 Fix issues with wikidata field searching and label updating 2020-05-20 11:23:01 -04:00
Quincy Morgan 8734b67821 Remove the context.intersects passthrough function 2020-04-01 15:36:53 -07:00
Quincy Morgan 60f7dc7c0b Replace presets property of context with singleton
Remove utilPreset
2020-04-01 13:08:45 -07:00
Quincy Morgan a58abe3c6f Move localStorage interface from a property of coreContext to a corePreferences function 2020-04-01 11:00:48 -07:00
Quincy Morgan a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406)
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan d62a62cba8 Make popover and tooltip part of the UI module instead of utils 2020-03-24 17:32:09 -07:00
Quincy Morgan 0931459dba Reduce use of global selection (re: #7445) 2020-03-24 13:02:06 -07:00
Quincy Morgan 8c31b99919 Focus wikidata field input when clicking its label
Remove for/id for readonly fields
2020-03-22 12:57:38 -07:00
Quincy Morgan 3c0b926ec7 Replace coreContext.geometry function with a more explicit coreGraph.geometry function 2020-03-21 14:23:44 -07:00
Quincy Morgan 8439795b58 Fix lint warning 2020-03-21 13:57:17 -07:00
Quincy Morgan fac613e1dc Remove context.childNodes function 2020-03-21 13:56:11 -07:00
Quincy Morgan 4872b06a28 Randomize form field ids to thwart browser memory and help with embedding iD (close #6444) 2020-03-21 13:16:40 -07:00
Quincy Morgan 152d89fa22 Convert some element ids to classes to avoid collisions when embedding iD 2020-03-20 13:10:39 -07:00
Bryan Housel 3608659d21 Restore field inheritance 2020-02-10 16:22:13 -05:00
Bryan Housel 4aa4686e7f Fix test failures in localized and suspicious_names 2020-02-03 12:38:17 -05:00
Quincy Morgan 2783408fc3 Add tooltips to mixed values in semicombo, multicombo, and radio fields 2020-01-31 14:07:16 -05:00
Quincy Morgan af928e3dc1 Support radio fields during multiselections 2020-01-31 13:02:30 -05:00
Quincy Morgan 8d9adbd902 Lock the name field if any of the selected features should be locked (re: #7306) 2020-01-31 11:23:42 -05:00
Quincy Morgan b3262a71dc Use newlines instead of semicolons to separate mutliselection tag values in tooltips (re: #7306) 2020-01-31 10:49:31 -05:00
Quincy Morgan 15e9599ff7 Support editing the Name and Multilingual Name fields during multiselection 2020-01-30 17:09:19 -05:00
Quincy Morgan 1b331bb678 Add mechanism for fields to support editing during multiselection (re: #7276)
Add `utilCombinedTags` method and use it for the raw tag editor as well as fields
Pass `entityIDs` array into fields instead of single `entity` object
Give field revertion its own path separate from `change`
Add multiselection editing to fields in files: access, address, check, combo, cycleway, input, maxspeed, textarea, and wikidata
2020-01-30 13:53:29 -05:00
Bryan Housel 33a2dafc10 Fetch wmf-sitematrix from CDN.. No need to depend on it anymore. 2020-01-30 09:48:37 -05:00
Bryan Housel c481f90e7d Stop bundling wmf-sitematrix, move it extern
This also includes a bunch of tweaks to make the tests work
in both PhantomJS and modern browsers like Chrome.

Basically - introduce some more async into the test code so that
the coreData.get promise is guaranteed to settle.  Because in
PhantomJS the promise is polyfilled, and Chrome it's native, they
work slightly differently.
2020-01-29 12:30:11 -05:00
Bryan Housel 567eeac587 Make several data external instead of bundled:
Also dist/data/* contains minified files now

These are now external and will fetch as needed:
-export { dataAddressFormats } from './address-formats.json';
-export { dataDeprecated } from './deprecated.json';
-export { dataDiscarded } from './discarded.json';
-export { dataLanguages } from './languages.json';
-export { dataPhoneFormats } from './phone-formats.json';
-export { dataShortcuts } from './shortcuts.json';
-export { dataTerritoryLanguages } from './territory-languages.json';
2020-01-28 22:21:31 -05:00
Quincy Morgan 89ce98f510 Don't require services/osm in order to get max OSM character lengths 2020-01-28 09:28:23 -05:00
Quincy Morgan 6dc02d7f22 Properly hide the input field on semicombos when there aren't enough characters remaining to add another value (re: #6817) 2020-01-27 16:35:15 -05:00
Quincy Morgan 17ae12b3d7 Address most common places where tag keys or values could exceed the 255 character API limit (close #6817) 2020-01-27 15:57:55 -05:00
Quincy Morgan 361358392f Don't show yes as a suggestion for typeCombo fields 2020-01-15 10:30:38 -05:00
Quincy Morgan 40b6fe7ff9 Fix semicombo drag-and-drop issues with stale data and target positioning (re: #7024) 2020-01-10 13:59:50 -05:00
Quincy Morgan e624106b7d Add Speed Limit Enforcement relation preset (close #7234)
Remove Name field from Enforcement preset
2020-01-10 12:19:53 -05:00
Quincy Morgan 20fd66630b Update semicombo reordering (re: #7024):
Don't try reordering multiCombo fields
Fix offset behavior for full-width semicombos
Use grab/grabbing cursor style
Keep dragged chip above others
2020-01-09 14:43:18 -05:00
Arjun ba00334f2b drag and drop of semicombos 2020-01-06 16:00:48 +00:00
Quincy Morgan 0a3b3df80c Filter out values with fewer 10 or fewer uses from combo field suggestions (close #7203) 2020-01-03 11:49:43 -05:00
Quincy Morgan 38ebef10d2 Revalidate after reversing ways via the One Way field 2019-12-06 11:04:16 -05:00