Martin Raifer
e8ceba1107
only use long-press context menu behavior on touch/stylus inputs
...
closes #8105
2022-10-14 13:02:15 +02:00
Martin Raifer
8076f6f2fe
fix opening of context menu when pressing context menu key
2022-10-14 12:46:44 +02:00
Martin Raifer
ad67f81cfd
code quality improvements (unused vars, duplicate css selectors, etc.) ( #8965 )
...
* mark function parameter as currently unused
* refactor some unused function parameters
* consolidate some css selectors
2022-02-07 15:30:53 +01:00
Quincy Morgan
ba48a861bc
Enable curly and block-spacing eslint rules
2020-11-10 14:19:11 -05:00
Quincy Morgan
315ab27997
Fix issue with context menu key
2020-10-26 15:12:18 -04:00
Quincy Morgan
21a49bbec8
Initial support for D3 v6.2.0
2020-10-06 15:08:39 -04:00
Quincy Morgan
f08a9fdfb4
Close the edit menu if a pointer goes down in the map
2020-06-30 12:07:06 -04:00
Quincy Morgan
5eb0fc3e0e
Update comments
2020-06-02 15:58:35 -04:00
Quincy Morgan
1d377227d0
Enable dual-pointer multiselection even if neither feature is selected yet
...
Don't do dual-pointer multiselection if a pointer has moved too much since it went down
Properly switch the selection when right-clicking on an unselected feature during a multiselection
2020-06-02 15:44:58 -04:00
Quincy Morgan
e2cd879c81
Account for canceled pointers in behaviorSelect
2020-05-27 16:55:04 -04:00
Quincy Morgan
0c8d237d17
Don't let down pointers trigger selection when raised after a long press
2020-05-27 15:54:39 -04:00
Quincy Morgan
cb5365f743
Persist down pointer multiselection between browse/select mode transitions
2020-05-27 12:33:53 -04:00
Quincy Morgan
4646c11ff1
Continue multiselection while the triggering pointer is down even if the targeted feature is deselected
2020-05-27 11:33:32 -04:00
Quincy Morgan
5b399623e9
Enable multiselection on touch devices when tapping on features with a pointer already down on a selected feature ( close #7590 )
...
Reuse modeSelect when changing entity selection if possible
2020-05-26 17:21:48 -04:00
Quincy Morgan
95f8e36a2a
Add a small tolerance to node dragging so selecting them no longer requires zero movement ( close #1981 )
2020-05-19 17:24:47 -04:00
Quincy Morgan
c4f5dbbc4c
Don't register spacebar-to-select unless the pointer is over the map
2020-05-19 11:13:03 -04:00
Quincy Morgan
e319aebc41
Fix several circumstances where the edit menu could appear unexpectedly
2020-05-15 15:22:36 -04:00
Quincy Morgan
db9eed2434
Move the edit menu logic to uiInit
...
Make context the first argument of operation objects
Add Paste operation to edit menu when opening the context menu on a blank area of the map (close #2508 )
2020-05-14 15:49:35 -04:00
Quincy Morgan
c939924f83
Fix issue with pressing spacebar in select modes
2020-05-14 13:09:25 -04:00
Quincy Morgan
a0ad92e6e0
Always show the edit menu at the location of the triggering event
2020-05-14 12:32:43 -04:00
Quincy Morgan
dff4268256
Allow selection, deselection, and multiselection with the spacebar (re: #3843 )
...
Don't open the edit menu on single spacebar press
Open the edit menu for long spacebar press (re: #7577 )
2020-05-14 11:19:20 -04:00
Quincy Morgan
23714ba822
Position the edit menu above the anchor point if triggered via touch or stylus (re: #7577 )
...
Add additional code safety to behaivorSelect
2020-05-12 18:42:36 -04:00
Quincy Morgan
4fede5214a
Ensure that only one pointer is handled at a time in behaivorSelect
2020-05-12 16:10:07 -04:00
Quincy Morgan
4a3fc57742
Show the edit menu when long-pressing or long-clicking ( close #7577 )
2020-05-08 19:23:01 -07:00
Quincy Morgan
77061e9c6c
Fix lint warnings
2020-05-08 09:42:02 -07:00
Quincy Morgan
ff4eb971ac
Fix various issues that made the walkthrough non-completable
2020-05-07 13:27:20 -07:00
Quincy Morgan
a58abe3c6f
Move localStorage interface from a property of coreContext to a corePreferences function
2020-04-01 11:00:48 -07:00
Quincy Morgan
5195d8d95b
Don't use d3_mouse and cache client rect values as needed ( close #7489 )
2020-03-28 16:32:38 -07:00
Quincy Morgan
4a67e8c5dc
Remove delay in opening the edit menu
...
Don't show the edit menu for multiple selected relations
Streamline edit menu code, replacing the confusing "suppressMenu" system
2020-03-26 12:48:30 -07:00
Quincy Morgan
62607e1e1d
Fix issue where edit menu could not be opened by right-clicking on already selected feature
2020-03-25 16:10:24 -07:00
Quincy Morgan
eed7944a1a
Replace various uses of d3_select and d3_selectAll with selection on the container
2020-03-22 12:34:06 -07:00
Quincy Morgan
5fd25601fe
Convert map surface and supersurface from ids to classes
2020-03-21 13:41:06 -07:00
Quincy Morgan
f8f69a777a
Replace inconsistently-supported dblclick events with custom handler on platforms supporting pointer events
...
Fix issue where double-tap-to-zoom would not be properly disabled when drawing on touch devices (close #2128 )
Support adding nodes to ways with double-tap with on touch devices (close #2677 )
Support double-tap-to-zoom with styluses on touch devices
Don't accept double click/tap events if the taps are far apart
Don't re-enter modeSelect when clicking the selected feature again
2020-03-06 12:46:26 -08:00
Quincy Morgan
83d2656bbc
Fix responsiveness issue when selecting features on iPad
...
Implement an alternative solution for #6028 that doesn't rely on timeouts
2020-03-04 13:10:15 -08:00
Quincy Morgan
c41e0b9937
Use pointer events for hovering and selecting data on supported platforms (re: #5505 )
...
Fix issue where Apple Pencil stylus could not select map data (close #7396 )
Fix issue where features could not be selected in a single tap on iPad (close #7380 )
2020-03-04 12:18:43 -08:00
SilentSpike
51efd5b714
Update and standardise QA implementations
...
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible
Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
Bryan Housel
37557a7c98
Defer processing clicks in behaviorSelect
...
(closes #6028 ) (I hope?)
Because this click may trigger a blur event,
and the blur event may trigger a tag change,
and we really want that tag change to go to the already selected entity
and not the one that we are about to select with the click #6028 , #5878
(Be very careful entering modeSelect anywhere that might also blur a field!)
2019-05-01 14:47:29 -04:00
Bryan Housel
d3f767d6f4
Code cleanups, prefix state variables with _
2019-05-01 13:48:36 -04:00
Quincy Morgan
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
Bryan Housel
1ce4f0ad6a
Remove lodash without
...
(re: #6087 )
2019-03-25 21:56:54 -04:00
SilentSpike
781558e56b
Remove redundant source property
2019-02-04 18:40:06 +00:00
SilentSpike
3ed13e9a4a
Convert KeepRight to use generic error type
2019-02-04 16:54:07 +00:00
SilentSpike
20ed8b50c9
Add generic QA error
...
I've converted the improveOSM errors to use this new generic QA error
structure which should allow for more general code to be used in
behaviour and UI.
Sidebar preview is currently broken, but will be fixed shortly.
2019-02-04 16:53:59 +00:00
SilentSpike
ee5f9f3bf2
Use consistent short service name
2019-02-01 22:51:02 +00:00
SilentSpike
214cf41019
Use more generic classes for errors
2019-02-01 22:50:57 +00:00
SilentSpike
4f2646d567
Add basic title + description UI
2019-02-01 22:50:54 +00:00
Thomas Hervey
31f35b0389
added basics to sidebar
2018-12-19 13:35:26 -05:00
Bryan Housel
152022aec4
Use context.keybinding for keybindings that don't change
...
(closes #5487 )
2018-11-13 20:57:21 -05:00
Bryan Housel
cc938698e8
Add ability to select custom data
2018-08-25 11:14:04 -04:00
Thomas Hervey
73ee5c2fc9
fixed select_note mode, cleaned note_editor, TODO: enable note save
2018-07-03 22:45:51 -04:00
