Andrew Wong
6ae25eada7
fixing tests around issues
2018-12-19 13:34:16 -05:00
Quincy Morgan
14f62ec3b9
Merge branch 'master' into validation
2018-12-19 13:23:54 -05:00
Quincy Morgan
59b0252b0e
Fixed several linting errors
2018-12-19 13:22:48 -05:00
Quincy Morgan
fb182dca37
Removed unneeded code in the issues pane
2018-12-19 13:10:03 -05:00
Quincy Morgan
6a931f9be6
Added colors to issue list icons
...
Corrected icon for warnings
Made disconnected_highway issue a warning instead of an error
2018-12-19 13:07:47 -05:00
Quincy Morgan
a95af00b1d
Added icons to issues list
2018-12-19 12:40:42 -05:00
Bryan Housel
81b5fc788e
Merge pull request #5629 from openstreetmap/5587
...
5587 - make geolocation show geolocation
2018-12-19 12:14:36 -05:00
Quincy Morgan
c4fb38603e
Merge branch 'master' into validation
2018-12-19 12:14:32 -05:00
Bryan Housel
7db6133666
Merge pull request #5583 from quincylvania/field-prerequisite-tags
...
Mechanism for displaying fields conditionally based on tags
2018-12-19 12:08:15 -05:00
Xiaoming Gao
c1e3a7396f
filter validations early in history
...
Follow @wonga00's comment in https://github.com/openstreetmap/iD/pull/5627
2018-12-19 12:05:06 -05:00
Max Grossman
399e7781c1
remove dispatched changes and re-order layers
...
ref #5587
2018-12-19 11:54:39 -05:00
Quincy Morgan
a05e259628
Added some initial styling for issues list
2018-12-19 11:28:29 -05:00
Max Grossman
3755951009
remove unused vars
...
ref #5587
2018-12-19 11:24:26 -05:00
Max Grossman
83c0843e57
just call accuracy function when setting r attr
...
ref #5587
2018-12-19 11:23:19 -05:00
Max Grossman
b9ddfca152
implement point/puck geolocation
...
ref #5587
2018-12-19 11:06:41 -05:00
Quincy Morgan
ff95e6a337
Merge branch 'validationIssueDataModel' into validation
2018-12-19 10:59:45 -05:00
Quincy Morgan
903cb63efe
Renamed validations to issues in relevant places
...
Made the issue pane get the issues from the issue manager rather than validating itself
2018-12-19 10:41:58 -05:00
Xiaoming Gao
07a53fe6ea
Extend data model for validation issues
...
Add the Issues pane
1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
(1) add a severity level field (useful for identify save-blocking issues later)
(2) replace single entity with an array of entities (useful for issues involving multiple entities)
(3) add a coordinates field for highlighting the location of the issue on the map
(4) add a fixes field for possible automatic fixes
3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
Quincy Morgan
0d0521c936
Moved feature applicability into the issue manager class
2018-12-19 10:32:14 -05:00
Quincy Morgan
161311faa5
Merge pull request #5626 from wonga00/wonga_issue_manager
...
added IssueManager
2018-12-18 18:05:40 -05:00
Quincy Morgan
858a9606d5
Added entity display name or preset name to the disconnected highway message
2018-12-18 18:05:27 -05:00
Andrew Wong
30f25c6e8d
added IssueManager
...
- IssueManager performs validation on the current graph and also
stores the issues and notifies listeners when the issues changed
2018-12-18 17:52:23 -05:00
Quincy Morgan
c1240af464
Added options UI in the Issues pane with edited vs all features selection
...
Added basic issues list in the Issues pane
2018-12-18 17:04:40 -05:00
Quincy Morgan
982f226d07
Merge branch 'master' into validation
2018-12-18 15:56:15 -05:00
Quincy Morgan
6e1dd34447
Fixed an issue where a new container would be added in the Map Data pane every time a section was re-expanded
2018-12-18 15:55:50 -05:00
Bryan Housel
5a2049b421
Drop extra whitespace, make sure service exists before using it
2018-12-18 15:38:53 -05:00
Quincy Morgan
e87a7e1125
Merge branch 'master' into validation
2018-12-18 15:35:55 -05:00
Bryan Housel
814c72fe42
Merge branch 'remote-presets' of https://github.com/radiant-maxar/iD into radiant-maxar-remote-presets
2018-12-18 15:15:11 -05:00
Max Grossman
b7f0d86da9
working on geolocate layer
...
ref #5587
2018-12-18 14:19:36 -05:00
Max Grossman
1471b55122
lint!
...
ref #5614
2018-12-18 12:02:26 -05:00
Max Grossman
02261c96e0
adding svg layer...
...
ref #5587
2018-12-18 12:01:22 -05:00
Max Grossman
ae9d43b0ac
remove double class
...
ref #5614
2018-12-18 11:16:37 -05:00
Quincy Morgan
cf0214d06a
Add the Issues pane
2018-12-18 11:11:15 -05:00
Max Grossman
18c021b5d5
add css
...
ref #5614
2018-12-18 11:09:26 -05:00
Max Grossman
0328e4f9da
add close button w/out css
...
ref #5614
2018-12-18 11:00:40 -05:00
Max Grossman
6ba8bacb75
use severity in test
2018-12-18 10:27:15 -05:00
Quincy Morgan
7e9082b9ff
Merge branch 'master' into field-prerequisite-tags
2018-12-18 09:33:46 -05:00
Max Grossman
64f2d913e8
remove unused entities from test
2018-12-17 17:39:47 -05:00
Max Grossman
8f33a85a12
make collection.index function to handle failing tests
2018-12-17 17:16:10 -05:00
Max Grossman
d8de9e785e
do not add found presets to recent
2018-12-17 14:56:33 -05:00
Max Grossman
74a19a6d7f
remove a comment
2018-12-17 12:55:00 -05:00
Max Grossman
e0e6f5b918
remove non-used util class
2018-12-17 12:52:21 -05:00
RudyTheDev
743be30a76
Use water fill pattern for fountain area
2018-12-15 16:33:06 +02:00
RudyTheDev
89a128f14c
Allow directly specified fill pattern for entire tag (not using for anything as of yet)
2018-12-15 15:58:39 +02:00
RudyTheDev
b92592b6b4
Add fill pattern for reservoir
2018-12-15 15:32:48 +02:00
Bryan Housel
43cea82d6f
Make sure when selecting to restore the sidebar to select mode
...
(closes #5603 )
2018-12-14 17:31:10 -05:00
Max Grossman
d87b1822f7
add/make visible weakly matched presets
2018-12-14 15:42:25 -05:00
Max Grossman
f627f1e659
make all presets visible on init!!
2018-12-14 13:29:17 -05:00
Max Grossman
1b51b8bc57
adding tests and updating/fixing external presets logic
2018-12-14 13:23:58 -05:00
Bryan Housel
e5aa8a7058
Simplify setPattern
2018-12-14 12:57:28 -05:00