Commit Graph

1265 Commits

Author SHA1 Message Date
Bryan Housel
efddfd271c More flow coverage of geo submodule
(re: #3744)

also:
- Move types to index and export/import them
- add return types
2018-03-17 09:29:12 -04:00
Bryan Housel
3e47ca005c Started adding Flow annotations to functions in the geo submodule
(re: #3744)
2018-03-17 01:18:05 -04:00
Bryan Housel
61c7f64077 Remember changeset source, make it settable via url param
(closes #4899)
2018-03-16 09:20:32 -04:00
Bryan Housel
e66218e1ef Merge branch 'tooltip' of https://github.com/vershwal/iD into vershwal-tooltip 2018-03-15 14:30:25 -04:00
vershwal
04bc4b09f0 Added alt text for information icon. 2018-03-15 12:54:42 +05:30
Bryan Housel
4a71aa6146 Use safer field ids in classes, element ids, css selectors
Fixes issue with nested/namespaced fields, such as `maxspeed/advisory`,
in situations where would try to use a css selector or element id.
Can't use characters like '/' in a css selector.
2018-03-15 00:57:41 -04:00
Bryan Housel
d2558b950d v2.7.1 2018-03-11 11:52:48 -04:00
Bryan Housel
2810f690d7 Merge pull request #4860 from jguthrie100/fix_4845
Can Esc/finish drawing an Area when cursor is in invalid position
2018-03-10 21:25:12 -05:00
Bryan Housel
d4bf42b6c4 Remove code attempting to extend leaf ways
(closes #4869)

It was causing more rendering issues than it was solving
2018-03-10 17:51:17 -05:00
Bryan Housel
f8bbb995ac Properly split ways which are members of a via way turn restriction
(closes #4861)
2018-03-10 15:20:20 -05:00
Bryan Housel
aa1565baf8 Avoid reordering stops and platforms in PTv2 routes
(closes #4864)
2018-03-10 00:12:46 -05:00
Bryan Housel
88dea28cf7 only_ restrictions only count if they leave the FROM towards the VIA
(closes #4849)
2018-03-09 22:39:30 -05:00
J Guthrie
d35494d003 Can finish drawing when cursor is in invalid position
- When drawing an Area, the leading edge is allowed to temporarily be in an invalid position (see #4655)..
    .. Finishing a drawing is disabled if doing so would close with the invalid leading edge
2018-03-08 02:53:03 +00:00
Martin Raifer
846da84831 add support for 4326 WMS layers 2018-03-07 23:44:19 +01:00
Bryan Housel
8dd7fa611e Merge branch '3744' of https://github.com/Psigio/iD into Psigio-3744 2018-03-03 22:12:36 -05:00
Bryan Housel
0f7ef99dbc v2.7.0 2018-03-02 17:54:38 -05:00
Bryan Housel
ecd63cdad2 Use maxDistance passed in to osmIntersection() in turn search
(closes #4844)

The maxDistance was previously hardcoded to 30 meters.
Now we pass it in as a parameter when creating the intersection.
But we need to honor that same maxDistance later when walking the graph
to find turns from.
2018-03-02 17:27:57 -05:00
Bryan Housel
3917f02067 When combobox is attached to textarea, let user up/down arrow
(closes #4750)
2018-03-02 00:42:24 -05:00
Bryan Housel
668c17ad1e Do not localize decimalCoordinatePair appearing in info panels
(closes #4765)
2018-03-02 00:21:24 -05:00
Bryan Housel
cc79e2170b Only draw targets for lines and areas that have a valid path
Before, it was drawing svg path elements for all the segments,
even those that were clipped out of view (getPath returns null).
This was putting a lot of junk into the DOM.
2018-03-01 22:49:56 -05:00
Bryan Housel
410197ce00 Vertex navigation for home/end should work with way selected
(closes #4841)

Before, first/last keyboard shortcuts only worked if you had a vertex selected.
Now you can navigate to the first/last vertices even if you have the way selected.
2018-03-01 22:23:55 -05:00
Bryan Housel
d9ebdda105 Polyfill sinh for IE11, add tests for wms replacement tokens
(see #4814)
2018-03-01 22:08:39 -05:00
Bryan Housel
67c2dec800 Merge pull request #4814 from openstreetmap/wms-tiles
Load WMS tiles if EPSG:3857 (or equivalent) is supported by source
2018-03-01 15:16:31 -05:00
Bryan Housel
4b1f8a8f61 Merge pull request #4768 from openstreetmap/advanced_intersection
Add support for complex intersection and via way restrictions
2018-03-01 01:46:30 -05:00
Bryan Housel
78170f8fe9 Improve hint text to aid in localization
- change the "Up to {num} ways" to "Up to 2 ways"
  (we don't plan to go above 2 for now)
- enumerate all the turn types No/Only/Allowed x Left/Right/Straight/U
- Add a line for "Click for" to let user know they can click to toggle

see https://github.com/openstreetmap/iD/pull/4768#pullrequestreview-100256196
2018-03-01 00:58:53 -05:00
Bryan Housel
241159b547 Cleanup docs and tests for actionRestrictTurn / actionUnrestrictTurn
- actionRestrictTurn will no longer "infer" the turn type
- restrictionType *must* be passed in - this is ok because the only code
  we use this action (restrictions.js) already has inferred the type
- this simplifies what the action actually does
- moved the tests from restrict_turn.js that were really just testing
  the restriction type inferrence over to intersection.js
  (and added a few more tests for iD.osmInferRestriction)
2018-02-28 23:55:59 -05:00
Bryan Housel
f9d000a8a5 When switching to ONLY restriction remove all other restrictions
But we keep them around in `_oldTurns` and will put them back if the
user clicks again to unrestrict the ONLY.
2018-02-27 22:53:46 -05:00
Jon D
48577aeb63 Add Flow Type Alias for function which returns an object (session_mutex) 2018-02-27 22:25:30 +00:00
Bryan Housel
e9750140ec Finish help, improve text and styling 2018-02-27 15:51:51 -05:00
Bryan Housel
a700d42e7d Much improved field help
- absolutely positioned attach to inspector,
- float slightly above field
- looks much better
2018-02-26 21:42:45 -05:00
Bryan Housel
6c6b1378b2 Add some restriction help images, adjust styles 2018-02-26 16:31:00 -05:00
Bryan Housel
de1fdaa21f Add close button, remove _showing state variable 2018-02-26 13:58:50 -05:00
Bryan Housel
97cbfc5c67 Add icons and improve css styles for restriction field help 2018-02-25 22:38:13 -05:00
Martin Raifer
2b96a8ee0b load WMS tiles if EPSG:3857 (or equivalent) is supported 2018-02-25 20:17:21 +01:00
Jon D
8655ec6baf Start adding flow annotations, plus updates to build and linting processes to support 2018-02-25 15:44:41 +00:00
Bryan Housel
b3b2be95b1 WIP: Add content for turn restriction field help 2018-02-24 12:14:18 -05:00
Bryan Housel
57d2aee6c8 Add uiFieldHelp component, currently just for turn restrictions field 2018-02-23 15:09:05 -05:00
Bryan Housel
7fa27217b6 Return an indirect u-turn restriction for an only restriction 2018-02-23 11:59:44 -05:00
Bryan Housel
c63f79a753 Remove isComplex, not used
This was used to decide whether to show the "Max Via" control.
(It's not really needed for a simple intersection)

However since we added the "Max Distance" control, it just makes
sense to show both sliders, since the distance can affect the
complexity.
2018-02-22 22:36:04 -05:00
Bryan Housel
aaed678468 Localize all the strings 2018-02-22 22:26:45 -05:00
Bryan Housel
156d0fd681 Drop confusing fromOnly code, consolidate path highlighting code 2018-02-21 00:33:41 -05:00
Bryan Housel
419d1e124b Remove fromOnly highlighting (was confusing), try to simplify 2018-02-20 17:01:11 -05:00
Bryan Housel
7559ff68df Highlight all the paths when hoving on the from 2018-02-20 15:45:44 -05:00
Bryan Housel
bd46d0cc4a Highlight restriction when hovering on from 2018-02-20 13:57:51 -05:00
Bryan Housel
4ce0b62d05 Remove unneeded hover behavior, don't hover a way that can't be a FROM 2018-02-20 10:38:50 -05:00
Bryan Housel
eb3c1f07ec Always restyle a selected from way (don't reset it to grey) 2018-02-20 09:10:17 -05:00
Bryan Housel
200098dff9 Render restriction paths with red/green/blue shadow 2018-02-19 21:30:47 -05:00
Bryan Housel
d940200ef0 osmInferRestriction can just take a turn, instead of from/to
This is better because it makes explicit that osmInferRestriction
needs an actual turn now (from/to with vertex, etc)
2018-02-16 13:27:23 -05:00
Bryan Housel
aff9258dee Indirect restrictions now include only the partial path
This lets us properly infer the actual turn taken through the indirect
restriction using osmInferRestriction (an improvement over 5e9db0d)
2018-02-16 11:42:44 -05:00
Jordane Pelloux-Prayer
ca493ec47c fixes #4804: do not stop mapillary autoplaying if _mlyViewer is not initialized 2018-02-16 13:01:32 +01:00